From: Matthew Wilcox <willy@infradead.org>
To: linmiaohe <linmiaohe@huawei.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Question Resend] About z3fold page migration
Date: Mon, 12 Oct 2020 15:04:41 +0100 [thread overview]
Message-ID: <20201012140441.GZ20115@casper.infradead.org> (raw)
In-Reply-To: <6d803d0cf27840caa64619949c2c3dd1@huawei.com>
On Mon, Oct 12, 2020 at 02:00:17PM +0000, linmiaohe wrote:
> Hi all:
>
> Many thanks for brilliant z3fold code. I am reading it and have some questions about it. It's very nice of you if you can explain it for me.
> 1.page->private is used in z3fold but PagePrivate flag is never set, should we SetPagePrivate for it?
No. SetPagePrivate and page->private are related in interesting and
complicated ways. I'm working on some documentation for it at the moment,
but the short answer is: no.
> 2.Since PagePrivate flag is never set, why we ClearPagePrivate in free_z3fold_page and z3fold_page_migrate?
That's probably a bug.
> 3.Should we add page to the unbuddied list in z3fold_page_putback() when zhdr->refcount does not reach 0 since we remove it from unbuddied list
> in z3fold_page_isolate? Or When we will add page to the unbuddied list after z3fold_page_putback?
This one I do not know the answer to.
next prev parent reply other threads:[~2020-10-12 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 14:00 [Question Resend] About z3fold page migration linmiaohe
2020-10-12 14:04 ` Matthew Wilcox [this message]
2020-10-13 1:46 linmiaohe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012140441.GZ20115@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.