From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3124DC43457 for ; Mon, 12 Oct 2020 14:22:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD3112087E for ; Mon, 12 Oct 2020 14:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389539AbgJLOWN (ORCPT ); Mon, 12 Oct 2020 10:22:13 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:35204 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389097AbgJLOWM (ORCPT ); Mon, 12 Oct 2020 10:22:12 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 289818030867; Mon, 12 Oct 2020 14:22:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bHN2z32UxKxQ; Mon, 12 Oct 2020 17:22:03 +0300 (MSK) Date: Mon, 12 Oct 2020 17:22:01 +0300 From: Serge Semin To: Neil Armstrong CC: Serge Semin , Mathias Nyman , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Alexey Malahov , Pavel Parkhomenko , Andy Gross , Bjorn Andersson , Manu Gautam , Roger Quadros , Lad Prabhakar , Yoshihiro Shimoda , , , , , Subject: Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Message-ID: <20201012142201.7fr2n5xwvei23yog@mobilestation> References: <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> <20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru> <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > Hi, > > On 11/10/2020 00:41, Serge Semin wrote: > > An empty snps,quirk-frame-length-adjustment won't cause any change > > performed by the driver. Moreover the DT schema validation will fail, > > since it expects the property being assigned with some value. So just > > discard the property declaration then from the example. > > > > Signed-off-by: Serge Semin > > > > --- > > > > Note the same problem is in the DT source file > > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > > --- > > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > index 5b04a7dfa018..88184d7e26cc 100644 > > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > @@ -209,6 +209,5 @@ examples: > > interrupts = <30>; > > dr_mode = "host"; > > snps,dis_u2_susphy_quirk; > > - snps,quirk-frame-length-adjustment; > > }; > > }; > > > > Thanks for reporting this, actually the fladj must be 0x20 on this hw, > but we do set this on the PHY side, so we can let the dwc3 side 0 here. I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc of this patchset, that modification won't be too much work to do. What do you think? Anyway please note, that I've fixed the improper property usage in the DT schema example only. "snps,quirk-frame-length-adjustment" defined as boolean still persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . So if you ever try to validate that dts file with "make dtbs_check" scenario, it will fail. -Sergey > > Acked-by: Neil Armstrong > > Neil > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18579C433DF for ; Mon, 12 Oct 2020 14:23:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A4F82076C for ; Mon, 12 Oct 2020 14:23:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TG2tIeMy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A4F82076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baikalelectronics.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Welo0cddZlZHTuIsnv6hA2KWqHRwtyDqrwdq22hu8Pw=; b=TG2tIeMyJziFZj0ZuclXqNP2d PlTDOfqSrQN+xr48ChXYTRwgU8iteWEtVCeVT2Ah3dMKex7p2aalZKXKuDPFDDZLjVCtBVUSuFziO 0eDWDkN4pAgKnvOkpFxufWOlcrecW6Gr+llFIVe5toifh8KN546Xd9ZGqLiTVfpBinX7PmgzUYUXI MSvJk7frTt2dd6EgJZ3QFWvU0Mv0+sMlLb54Rc+w2eh0jYXv1pnF/DAzCfR6Rq6IyfSWpIef3Yxgg wd3E9cnYz6QznYJhR08Sr+pBbQimjieiyfd3g52k/LY7MZk/qLGjgAwd4GXtYTqN+AI5RmSwsjOv1 8rab+awMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRyiQ-00019F-GR; Mon, 12 Oct 2020 14:22:18 +0000 Received: from mail.baikalelectronics.com ([87.245.175.226] helo=mail.baikalelectronics.ru) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRyiL-00016b-Rs; Mon, 12 Oct 2020 14:22:15 +0000 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 289818030867; Mon, 12 Oct 2020 14:22:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bHN2z32UxKxQ; Mon, 12 Oct 2020 17:22:03 +0300 (MSK) Date: Mon, 12 Oct 2020 17:22:01 +0300 From: Serge Semin To: Neil Armstrong Subject: Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Message-ID: <20201012142201.7fr2n5xwvei23yog@mobilestation> References: <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> <20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru> <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_102214_175662_8501160B X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Felipe Balbi , Roger Quadros , Mathias Nyman , devicetree@vger.kernel.org, Martin Blumenstingl , Kevin Hilman , Lad Prabhakar , linux-usb@vger.kernel.org, Andy Gross , Serge Semin , Alexey Malahov , Manu Gautam , Rob Herring , Pavel Parkhomenko , Greg Kroah-Hartman , linux-amlogic@lists.infradead.org, Bjorn Andersson , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > Hi, > > On 11/10/2020 00:41, Serge Semin wrote: > > An empty snps,quirk-frame-length-adjustment won't cause any change > > performed by the driver. Moreover the DT schema validation will fail, > > since it expects the property being assigned with some value. So just > > discard the property declaration then from the example. > > > > Signed-off-by: Serge Semin > > > > --- > > > > Note the same problem is in the DT source file > > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > > --- > > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > index 5b04a7dfa018..88184d7e26cc 100644 > > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > @@ -209,6 +209,5 @@ examples: > > interrupts = <30>; > > dr_mode = "host"; > > snps,dis_u2_susphy_quirk; > > - snps,quirk-frame-length-adjustment; > > }; > > }; > > > > Thanks for reporting this, actually the fladj must be 0x20 on this hw, > but we do set this on the PHY side, so we can let the dwc3 side 0 here. I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc of this patchset, that modification won't be too much work to do. What do you think? Anyway please note, that I've fixed the improper property usage in the DT schema example only. "snps,quirk-frame-length-adjustment" defined as boolean still persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . So if you ever try to validate that dts file with "make dtbs_check" scenario, it will fail. -Sergey > > Acked-by: Neil Armstrong > > Neil > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66818C433DF for ; Mon, 12 Oct 2020 14:22:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E8142076C for ; Mon, 12 Oct 2020 14:22:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="usWd8IUy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E8142076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baikalelectronics.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AckMeT8Bk8INrN93jHW2zTBfh/NPrbBzRji5wracHmQ=; b=usWd8IUyMdwhhkL9R1XPZX0EH OmXC+epo7qchbSy7nH8RYHUPMx9Vm9il1FXLeypLWk0trYaMD/xSt5yVLoNm6/CA5xqZSbGptP/8m d0/Gj2CzRuJnIDDOoT+C0BytLuwXM/x2QHjCLZv/gIiRlmVmlLLuCvMv/wBFojQmMlUyUK5enLetD GNNBGkhhgMXJqrhIUed5Y+rTUZ2CcCMotwc9sR86AcICQ4yP/oqS/DdFvBB8tnTIsFn9Nc7KOsb4W F1aZ0AQd8spyZFLLMwCW04OW0/lPlxqhZkKKSLHQAR0pyrKitfAWYUghjPPlqOygAKhHaunviphWO /Zqj+nSgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRyiP-00018x-Eh; Mon, 12 Oct 2020 14:22:17 +0000 Received: from mail.baikalelectronics.com ([87.245.175.226] helo=mail.baikalelectronics.ru) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRyiL-00016b-Rs; Mon, 12 Oct 2020 14:22:15 +0000 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 289818030867; Mon, 12 Oct 2020 14:22:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bHN2z32UxKxQ; Mon, 12 Oct 2020 17:22:03 +0300 (MSK) Date: Mon, 12 Oct 2020 17:22:01 +0300 From: Serge Semin To: Neil Armstrong Subject: Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Message-ID: <20201012142201.7fr2n5xwvei23yog@mobilestation> References: <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> <20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru> <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_102214_175662_8501160B X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Felipe Balbi , Roger Quadros , Mathias Nyman , devicetree@vger.kernel.org, Martin Blumenstingl , Kevin Hilman , Lad Prabhakar , linux-usb@vger.kernel.org, Andy Gross , Serge Semin , Alexey Malahov , Manu Gautam , Rob Herring , Pavel Parkhomenko , Greg Kroah-Hartman , linux-amlogic@lists.infradead.org, Bjorn Andersson , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > Hi, > > On 11/10/2020 00:41, Serge Semin wrote: > > An empty snps,quirk-frame-length-adjustment won't cause any change > > performed by the driver. Moreover the DT schema validation will fail, > > since it expects the property being assigned with some value. So just > > discard the property declaration then from the example. > > > > Signed-off-by: Serge Semin > > > > --- > > > > Note the same problem is in the DT source file > > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > > --- > > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > index 5b04a7dfa018..88184d7e26cc 100644 > > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > @@ -209,6 +209,5 @@ examples: > > interrupts = <30>; > > dr_mode = "host"; > > snps,dis_u2_susphy_quirk; > > - snps,quirk-frame-length-adjustment; > > }; > > }; > > > > Thanks for reporting this, actually the fladj must be 0x20 on this hw, > but we do set this on the PHY side, so we can let the dwc3 side 0 here. I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc of this patchset, that modification won't be too much work to do. What do you think? Anyway please note, that I've fixed the improper property usage in the DT schema example only. "snps,quirk-frame-length-adjustment" defined as boolean still persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . So if you ever try to validate that dts file with "make dtbs_check" scenario, it will fail. -Sergey > > Acked-by: Neil Armstrong > > Neil > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic