From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97658C433E7 for ; Mon, 12 Oct 2020 15:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DA4020878 for ; Mon, 12 Oct 2020 15:13:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389693AbgJLPNd (ORCPT ); Mon, 12 Oct 2020 11:13:33 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:35408 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389640AbgJLPNc (ORCPT ); Mon, 12 Oct 2020 11:13:32 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 68C5F8030865; Mon, 12 Oct 2020 15:13:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18g_bu0glQOE; Mon, 12 Oct 2020 18:13:28 +0300 (MSK) Date: Mon, 12 Oct 2020 18:13:26 +0300 From: Serge Semin To: Neil Armstrong CC: Serge Semin , Mathias Nyman , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Alexey Malahov , Pavel Parkhomenko , Andy Gross , Bjorn Andersson , Manu Gautam , Roger Quadros , Lad Prabhakar , Yoshihiro Shimoda , , , , , Subject: Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Message-ID: <20201012151326.peu4yq6fhmi5utnb@mobilestation> References: <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> <20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru> <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> <20201012142201.7fr2n5xwvei23yog@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 05:01:43PM +0200, Neil Armstrong wrote: > Hi, > > On 12/10/2020 16:22, Serge Semin wrote: > > On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > >> Hi, > >> > >> On 11/10/2020 00:41, Serge Semin wrote: > >>> An empty snps,quirk-frame-length-adjustment won't cause any change > >>> performed by the driver. Moreover the DT schema validation will fail, > >>> since it expects the property being assigned with some value. So just > >>> discard the property declaration then from the example. > >>> > >>> Signed-off-by: Serge Semin > >>> > >>> --- > >>> > >>> Note the same problem is in the DT source file > >>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > >>> --- > >>> .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> index 5b04a7dfa018..88184d7e26cc 100644 > >>> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> @@ -209,6 +209,5 @@ examples: > >>> interrupts = <30>; > >>> dr_mode = "host"; > >>> snps,dis_u2_susphy_quirk; > >>> - snps,quirk-frame-length-adjustment; > >>> }; > >>> }; > >>> > >> > > > >> Thanks for reporting this, actually the fladj must be 0x20 on this hw, > >> but we do set this on the PHY side, so we can let the dwc3 side 0 here. > > > > I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" > > property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc > > of this patchset, that modification won't be too much work to do. What do you think? > > Yes, do this please, Ok. Shall I preserve your Acked-by tag in the new patch or you'd prefer to review it first? > anyway it's only an example so it's ok. Actually examples are also validated by "make dt_binding_check". That's why I had to fix the amlogic,meson-g12a-usb-ctrl example for at least so the new snps,dwc3.yaml DT schema wouldn't break that full DT bindings validation procedure.) -Sergey > > > > > Anyway please note, that I've fixed the improper property usage in the DT schema > > example only. "snps,quirk-frame-length-adjustment" defined as boolean still > > persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > > So if you ever try to validate that dts file with "make dtbs_check" scenario, it > > will fail. > > Yes, I'll push a fix to pass the dtbs_check when this is merged. > > Thanks, > Neil > > > > > -Sergey > > > >> > >> Acked-by: Neil Armstrong > >> > >> Neil > >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA34DC43457 for ; Mon, 12 Oct 2020 15:15:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D84C20878 for ; Mon, 12 Oct 2020 15:15:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bVMjiNRe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D84C20878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baikalelectronics.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JPBK/sMDZgArFgKh4flEy6HgeAJ7mA580yN3JjE1Nq0=; b=bVMjiNRehe87CwiXRIg/WUUrQ 0J4/GL3vf3hgTOoymyXCo8o8wecW6uHbqUHKuJ88zlJgbDaudl8epJcJ5ZJxdAG1LhMr0wKSQ6rhs XQNnWFeDdmYP7lePJmUnqZwbvqP1Rn7weFcWtFxpvujmHZBeA9WfIQtTnbVrIUKBY1YwG0vHQTCht sC9/mNxjjTqj/JI2ooa0lNz1W4qkxnmHcJBlntLqQgnCpmWJkMExYoSknsxM07eQjd5EaF+M71aXs LrvXPbs8X8dHBh27mB6rQrBc9vwHOJVFxJfjK0ZJ0SfQNzd9fe14DwcKoUezf3XxuPXsICbbcd/vy Es8d9R2fw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRzW2-0006I9-5p; Mon, 12 Oct 2020 15:13:34 +0000 Received: from mail.baikalelectronics.com ([87.245.175.226] helo=mail.baikalelectronics.ru) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRzVy-0006HV-6N; Mon, 12 Oct 2020 15:13:31 +0000 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 68C5F8030865; Mon, 12 Oct 2020 15:13:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18g_bu0glQOE; Mon, 12 Oct 2020 18:13:28 +0300 (MSK) Date: Mon, 12 Oct 2020 18:13:26 +0300 From: Serge Semin To: Neil Armstrong Subject: Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Message-ID: <20201012151326.peu4yq6fhmi5utnb@mobilestation> References: <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> <20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru> <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> <20201012142201.7fr2n5xwvei23yog@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_111330_487798_0C60D512 X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Felipe Balbi , Roger Quadros , Mathias Nyman , devicetree@vger.kernel.org, Martin Blumenstingl , Kevin Hilman , Lad Prabhakar , linux-usb@vger.kernel.org, Andy Gross , Serge Semin , Alexey Malahov , Manu Gautam , Rob Herring , Pavel Parkhomenko , Greg Kroah-Hartman , linux-amlogic@lists.infradead.org, Bjorn Andersson , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 05:01:43PM +0200, Neil Armstrong wrote: > Hi, > > On 12/10/2020 16:22, Serge Semin wrote: > > On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > >> Hi, > >> > >> On 11/10/2020 00:41, Serge Semin wrote: > >>> An empty snps,quirk-frame-length-adjustment won't cause any change > >>> performed by the driver. Moreover the DT schema validation will fail, > >>> since it expects the property being assigned with some value. So just > >>> discard the property declaration then from the example. > >>> > >>> Signed-off-by: Serge Semin > >>> > >>> --- > >>> > >>> Note the same problem is in the DT source file > >>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > >>> --- > >>> .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> index 5b04a7dfa018..88184d7e26cc 100644 > >>> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> @@ -209,6 +209,5 @@ examples: > >>> interrupts = <30>; > >>> dr_mode = "host"; > >>> snps,dis_u2_susphy_quirk; > >>> - snps,quirk-frame-length-adjustment; > >>> }; > >>> }; > >>> > >> > > > >> Thanks for reporting this, actually the fladj must be 0x20 on this hw, > >> but we do set this on the PHY side, so we can let the dwc3 side 0 here. > > > > I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" > > property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc > > of this patchset, that modification won't be too much work to do. What do you think? > > Yes, do this please, Ok. Shall I preserve your Acked-by tag in the new patch or you'd prefer to review it first? > anyway it's only an example so it's ok. Actually examples are also validated by "make dt_binding_check". That's why I had to fix the amlogic,meson-g12a-usb-ctrl example for at least so the new snps,dwc3.yaml DT schema wouldn't break that full DT bindings validation procedure.) -Sergey > > > > > Anyway please note, that I've fixed the improper property usage in the DT schema > > example only. "snps,quirk-frame-length-adjustment" defined as boolean still > > persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > > So if you ever try to validate that dts file with "make dtbs_check" scenario, it > > will fail. > > Yes, I'll push a fix to pass the dtbs_check when this is merged. > > Thanks, > Neil > > > > > -Sergey > > > >> > >> Acked-by: Neil Armstrong > >> > >> Neil > >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0977C433DF for ; Mon, 12 Oct 2020 15:13:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A63320878 for ; Mon, 12 Oct 2020 15:13:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lu/g/2DK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A63320878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baikalelectronics.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ia7trnXkuFz1pd1EcFPptY7NOclO1HeRIAsW4GSZR60=; b=lu/g/2DK2OpVqx62f1TvpSlGa pI4rLpulGnODcAJY++VQeRPXEfVnxyCQ1z/IfDEjr/U8sOxsZ3l8STYVrYTV9ydQBOiWMxwt1xpJg lu6stJp4T/tuU+iHnyPJGl/hgOZY6G2C4gBzLydYmW7+PwneHOLQTLMS7R4TT3wS5ZoqGofXSdsY0 XgX8VR7Fj1df2KM92cSrv8bjIjjOrGxYeWfRheS0e0VaK7Y9Ex7dafcNVvWxb8U650wGz4Mrb2XeZ aReDEMOPl9Co9QVfV/FR1ac9o9jLepeZET0C5TbQMn3Wo0l0wu4swNjo6ZrHsrJaL3LWVwq04o8nK SGFo83nGg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRzW1-0006Hw-7h; Mon, 12 Oct 2020 15:13:33 +0000 Received: from mail.baikalelectronics.com ([87.245.175.226] helo=mail.baikalelectronics.ru) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRzVy-0006HV-6N; Mon, 12 Oct 2020 15:13:31 +0000 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 68C5F8030865; Mon, 12 Oct 2020 15:13:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18g_bu0glQOE; Mon, 12 Oct 2020 18:13:28 +0300 (MSK) Date: Mon, 12 Oct 2020 18:13:26 +0300 From: Serge Semin To: Neil Armstrong Subject: Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Message-ID: <20201012151326.peu4yq6fhmi5utnb@mobilestation> References: <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> <20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru> <329129ac-ff44-4928-bca4-805297a8c456@baylibre.com> <20201012142201.7fr2n5xwvei23yog@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_111330_487798_0C60D512 X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Felipe Balbi , Roger Quadros , Mathias Nyman , devicetree@vger.kernel.org, Martin Blumenstingl , Kevin Hilman , Lad Prabhakar , linux-usb@vger.kernel.org, Andy Gross , Serge Semin , Alexey Malahov , Manu Gautam , Rob Herring , Pavel Parkhomenko , Greg Kroah-Hartman , linux-amlogic@lists.infradead.org, Bjorn Andersson , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 05:01:43PM +0200, Neil Armstrong wrote: > Hi, > > On 12/10/2020 16:22, Serge Semin wrote: > > On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > >> Hi, > >> > >> On 11/10/2020 00:41, Serge Semin wrote: > >>> An empty snps,quirk-frame-length-adjustment won't cause any change > >>> performed by the driver. Moreover the DT schema validation will fail, > >>> since it expects the property being assigned with some value. So just > >>> discard the property declaration then from the example. > >>> > >>> Signed-off-by: Serge Semin > >>> > >>> --- > >>> > >>> Note the same problem is in the DT source file > >>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > >>> --- > >>> .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> index 5b04a7dfa018..88184d7e26cc 100644 > >>> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> @@ -209,6 +209,5 @@ examples: > >>> interrupts = <30>; > >>> dr_mode = "host"; > >>> snps,dis_u2_susphy_quirk; > >>> - snps,quirk-frame-length-adjustment; > >>> }; > >>> }; > >>> > >> > > > >> Thanks for reporting this, actually the fladj must be 0x20 on this hw, > >> but we do set this on the PHY side, so we can let the dwc3 side 0 here. > > > > I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" > > property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc > > of this patchset, that modification won't be too much work to do. What do you think? > > Yes, do this please, Ok. Shall I preserve your Acked-by tag in the new patch or you'd prefer to review it first? > anyway it's only an example so it's ok. Actually examples are also validated by "make dt_binding_check". That's why I had to fix the amlogic,meson-g12a-usb-ctrl example for at least so the new snps,dwc3.yaml DT schema wouldn't break that full DT bindings validation procedure.) -Sergey > > > > > Anyway please note, that I've fixed the improper property usage in the DT schema > > example only. "snps,quirk-frame-length-adjustment" defined as boolean still > > persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > > So if you ever try to validate that dts file with "make dtbs_check" scenario, it > > will fail. > > Yes, I'll push a fix to pass the dtbs_check when this is merged. > > Thanks, > Neil > > > > > -Sergey > > > >> > >> Acked-by: Neil Armstrong > >> > >> Neil > >> > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic