From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF2F2C35271 for ; Mon, 12 Oct 2020 15:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79C412087D for ; Mon, 12 Oct 2020 15:41:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hpZcv3w9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390836AbgJLPlk (ORCPT ); Mon, 12 Oct 2020 11:41:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58863 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389974AbgJLPkA (ORCPT ); Mon, 12 Oct 2020 11:40:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602517199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tVvce4e6eIFCyn6Tznu2Pb8PdDR0S4LAYFGAeOch+LY=; b=hpZcv3w9oh4Ga6pBhmI0t15reXQLJ22pSmtia8ES97IZyFvMLZeB1UYgH2QyQmc7a2srpe bGNc/i7vwSG444eSwIdJiVWA5uzwBDloE2q79v1+WLihkx3kcP4uA2MgjEnFl/b8Fld4fl mTBsNuVd9nW7B18Zldi8c8QnKFVi2n8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-AIxEAjSVNEyJJFti44RVyw-1; Mon, 12 Oct 2020 11:39:55 -0400 X-MC-Unique: AIxEAjSVNEyJJFti44RVyw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9EA936408B; Mon, 12 Oct 2020 15:39:53 +0000 (UTC) Received: from treble (ovpn-118-167.rdu2.redhat.com [10.10.118.167]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F076973663; Mon, 12 Oct 2020 15:39:51 +0000 (UTC) Date: Mon, 12 Oct 2020 10:39:49 -0500 From: Josh Poimboeuf To: Masami Hiramatsu Cc: Borislav Petkov , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org, Martin Schwidefsky , Vasily Gorbik , x86 Subject: Re: [tip: objtool/core] x86/insn: Support big endian cross-compiles Message-ID: <20201012153949.jfwa7rgpzu5b7ld4@treble> References: <160208761921.7002.1321765913567405137.tip-bot2@tip-bot2> <20201009203822.GA2974@worktop.programming.kicks-ass.net> <20201009204921.GB21731@zn.tnic> <20201010174415.zwopoy6vpficoqlr@treble> <20201012091236.0f9a64bfedb8825732b65ea5@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201012091236.0f9a64bfedb8825732b65ea5@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 09:12:36AM +0900, Masami Hiramatsu wrote: > On Sat, 10 Oct 2020 12:44:15 -0500 > Josh Poimboeuf wrote: > > > On Fri, Oct 09, 2020 at 10:49:21PM +0200, Borislav Petkov wrote: > > > On Fri, Oct 09, 2020 at 10:38:22PM +0200, Peter Zijlstra wrote: > > > > On Wed, Oct 07, 2020 at 04:20:19PM -0000, tip-bot2 for Martin Schwidefsky wrote: > > > > > The following commit has been merged into the objtool/core branch of tip: > > > > > > > > > > Commit-ID: 2a522b53c47051d3bf98748418f4f8e5f20d2c04 > > > > > Gitweb: https://git.kernel.org/tip/2a522b53c47051d3bf98748418f4f8e5f20d2c04 > > > > > Author: Martin Schwidefsky > > > > > AuthorDate: Mon, 05 Oct 2020 17:50:31 +02:00 > > > > > Committer: Josh Poimboeuf > > > > > CommitterDate: Tue, 06 Oct 2020 09:32:29 -05:00 > > > > > > > > > > x86/insn: Support big endian cross-compiles > > > > > > > > > > x86 instruction decoder code is shared across the kernel source and the > > > > > tools. Currently objtool seems to be the only tool from build tools needed > > > > > which breaks x86 cross compilation on big endian systems. Make the x86 > > > > > instruction decoder build host endianness agnostic to support x86 cross > > > > > compilation and enable objtool to implement endianness awareness for > > > > > big endian architectures support. > > > > > > > > > > Signed-off-by: Martin Schwidefsky > > > > > Co-developed-by: Vasily Gorbik > > > > > Signed-off-by: Vasily Gorbik > > > > > Acked-by: Masami Hiramatsu > > > > > Signed-off-by: Josh Poimboeuf > > > > > > > > This commit breaks the x86 build with CONFIG_X86_DECODER_SELFTEST=y. > > > > > > > > I've asked Boris to truncate tip/objtool/core. > > > > > > Yeah, top 4 are gone until this is resolved. > > > > Masami, I wonder if we even need these selftests anymore? Objtool > > already decodes the entire kernel. > > No, they have different roles. The selftest checks if the decoder > works correctly by comparing with the output of objdump. > > As far as I can see, the objtool relies on the sanity of the decoder > (it trusts the output of the decoder). Ok. I wonder if we should move the decoder selftest to the 'tools' subdirectory. -- Josh