From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E99C433DF for ; Mon, 12 Oct 2020 18:14:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CABF92080A for ; Mon, 12 Oct 2020 18:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602526454; bh=1bQ7pVB0yuVhNgRH7iBjAzMumTKHCjzRzsxFTosK4YU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kvP2H+zSZ/A4H+eX8BEjSgBt5i0hzCr+0oAtwlB5wV/aURFPjkWnyXlCDcGTZVDV7 Q0RjUzwrRvG6M5Iq7FLttwImUhYvdMPzAmlUUuPXS7wedjYMK3s5RmKIukXanHS+g9 C33qyRSJpRdbLVT5hNHb4gdfJ7bl6qjkrHVPRMNY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404183AbgJLSON (ORCPT ); Mon, 12 Oct 2020 14:14:13 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:44432 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404152AbgJLSOL (ORCPT ); Mon, 12 Oct 2020 14:14:11 -0400 Received: by mail-oi1-f196.google.com with SMTP id x62so19596162oix.11; Mon, 12 Oct 2020 11:14:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=J3q7xHuH0aR/mKQTWSzv+4bd6O+Z10supV2gdoPo7Lo=; b=Ew2499x4LmgZqJg7/faouURyB3dhB6irypikPNyKFXbVvBkw9JE1xfqX4++thzwMJ1 zGRvy5xydJ7d/BxyMAD6hbbGgL/OfNgIEKJQFKtfXU8e6YZpkwL5QgiMlEiIpYiqml1K iBhkE3a2VLNGw08y/yUOuJeXKfsNlav/tkBwquK30/C5+362t0bARMa8dq5OIEkRwh8q tERkjkKP2LmyXVUhPSN2kT3RbIDA6pX1YcrOmxebkFdBpy0cn/D9XEG9sw6GuS18zbxl o3fkJEW58QRy9xwXr0JA1d5rq2Mh5zJnca5hpY2PXZjAl/InfWW+sZ2qi+wcKYQjUAci bymw== X-Gm-Message-State: AOAM533HIb8JPdVjOfnwc9L6il2kpNnQyaSA9tHMCjdnrKBrg/gJ/foy UtMS38LNew5sAuArOPnNHA== X-Google-Smtp-Source: ABdhPJxEUqKxSDYUb/dWoUKkqguMsBXKOfsJi4XsgrQSu5P3tIoepRAQCg4Kb7WGp2CkRnNpo8Kn8Q== X-Received: by 2002:aca:4e05:: with SMTP id c5mr12111904oib.99.1602526448601; Mon, 12 Oct 2020 11:14:08 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 189sm9779176oid.40.2020.10.12.11.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 11:14:06 -0700 (PDT) Received: (nullmailer pid 1850043 invoked by uid 1000); Mon, 12 Oct 2020 18:14:04 -0000 Date: Mon, 12 Oct 2020 13:14:04 -0500 From: Rob Herring To: Thierry Reding Cc: Krzysztof Kozlowski , linux-pwm@vger.kernel.org, Philipp Zabel , devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles Message-ID: <20201012181404.GA1846397@bogus> References: <20200925212609.23093-1-krzk@kernel.org> <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> <20200926134157.GA4730@kozik-lap> <20201009120239.GA450876@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201009120239.GA450876@ulmo> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2020 at 02:02:39PM +0200, Thierry Reding wrote: > On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote: > > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote: > > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote: > > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check > > > > warnings like: > > > > > > > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0: > > > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm'] > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++ > > > > 1 file changed, 11 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > > index 473863eb67e5..379d693889f6 100644 > > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > > @@ -25,6 +25,17 @@ properties: > > > > - fsl,imx27-pwm > > > > - items: > > > > - enum: > > > > + - fsl,imx25-pwm > > > > > > The driver actually used fsl,imx27-pwm to bind ... > > > > Yes, most of i.MX drivers use only few compatibles but DTSes and > > bindings use multiple of them. I was convinced during various talks > > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are > > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it > > to the another level creating compatibles for absolutely every flavor of > > their CPU. And they mainlined it in DTSes... > > > > The PWM is this crazy examples where, as you say, only two compatibles > > are actually used for binding but DTSes uses more. > > Yeah, these new compatible strings all seem to be used in the kernel, so > we might as well document them. > > That said, I did want to apply this patch, but that fails. Am I missing > some other patch that you have sent out that touches this file? Actually > it looks like this is because you've based this patch on linux-next, or > perhaps the devicetree tree, because that contains commit d058717bdff4 > ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that > adds a couple more compatible strings. Probably best for Rob to pick > this up, then: > > Acked-by: Thierry Reding > > Rob, here's a patchwork link for you if you need one: > > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/ > > Although, looking at the devicetree-bindings instance version of that > patch, I see that it's got a failing check attached (which looks like > it can be ignored) and it's marked "Changes Requested", but no comments > saying so. I was assuming a rename at least. > Not sure if you want anything done here? I guess not, so I've applied it. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5A0C433DF for ; Mon, 12 Oct 2020 18:15:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AAD12080A for ; Mon, 12 Oct 2020 18:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KeGyEOjI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AAD12080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u+ig2Kyr7O+j4Lt/sXiWVqptDs93g3D3IB1f9Ua7XNA=; b=KeGyEOjIiqmOEYyh2NduhuLY3 +nByz8sGHoYFbtdh79EqqcEEV0oaeOTI85JwG/3YUeBEL1bGJjAavHZZVWAShszgPHdIPpicuMivE Vzb0/isTG795oR74WnFze6sxCfIPKuFQEJHukY987lVLoGSkdO4JWNxKSI7WtRhBDWy5JVEzzXpjy qecNDAgGvqjG88gAwyqpcAvRsRz88h1VtMUay+sIrndpTCbKoDIG1iFm2GH9lc8us/EATXegkzdB4 yBVtC6p2U+2Jqql57ffzkNugB16844eC659fZVQzpFIvI/6UP/jqpAXi6rMSj4POXG6oWcnGGtnDe /zzJq8jzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS2Kq-0002XL-Rz; Mon, 12 Oct 2020 18:14:12 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS2Ko-0002Wp-CT for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 18:14:11 +0000 Received: by mail-oi1-f194.google.com with SMTP id u17so19650255oie.3 for ; Mon, 12 Oct 2020 11:14:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=J3q7xHuH0aR/mKQTWSzv+4bd6O+Z10supV2gdoPo7Lo=; b=Sk18uBLHM4mYGGCf5ALvq8cE/gMKUZpy1LywFtWDfKZd2eOC8RFRF3M9lppjiFUxYt HRsMYraMTLkMba8I4HS4JDKRHfl+GrbUQpHiwuukyrAobDre9pUvol6DsOLTWxSZpyt8 /O2bQk3K571g1pG7ybL5QNwmH+IdEtXrCHOgl7lXTddrsAnUdjisk4ChCXuD5CZzqFEX 4D9eeFjeMeG6lLW1vrTr/rhQvFBCnd3TN/O479UbalWQjOWuqej9jJja7KVZiwJzi6CS LASxti8Q7zUsZnXAkoA3x0X0v61NpO2rx3VjxvDyezibV1ATWm1BQrK+OTpf4IuwB2FM jJiA== X-Gm-Message-State: AOAM533pa1nXx4zb3hn/D8+886/g8ZA2goVVkC1bgjFvRLY7hvLYejwX RC8CriPMbJytKACSAP9Jfw== X-Google-Smtp-Source: ABdhPJxEUqKxSDYUb/dWoUKkqguMsBXKOfsJi4XsgrQSu5P3tIoepRAQCg4Kb7WGp2CkRnNpo8Kn8Q== X-Received: by 2002:aca:4e05:: with SMTP id c5mr12111904oib.99.1602526448601; Mon, 12 Oct 2020 11:14:08 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 189sm9779176oid.40.2020.10.12.11.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 11:14:06 -0700 (PDT) Received: (nullmailer pid 1850043 invoked by uid 1000); Mon, 12 Oct 2020 18:14:04 -0000 Date: Mon, 12 Oct 2020 13:14:04 -0500 From: Rob Herring To: Thierry Reding Subject: Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles Message-ID: <20201012181404.GA1846397@bogus> References: <20200925212609.23093-1-krzk@kernel.org> <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> <20200926134157.GA4730@kozik-lap> <20201009120239.GA450876@ulmo> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201009120239.GA450876@ulmo> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_141410_435127_65014D04 X-CRM114-Status: GOOD ( 31.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Pengutronix Kernel Team , devicetree@vger.kernel.org, Lee Jones , Sascha Hauer , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , NXP Linux Team , Philipp Zabel , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Shawn Guo , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 09, 2020 at 02:02:39PM +0200, Thierry Reding wrote: > On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote: > > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-K=F6nig wrote: > > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote: > > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_ch= eck > > > > warnings like: > > > > = > > > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: co= mpatible:0: > > > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pw= m', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm'] > > > > = > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++ > > > > 1 file changed, 11 insertions(+) > > > > = > > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/D= ocumentation/devicetree/bindings/pwm/imx-pwm.yaml > > > > index 473863eb67e5..379d693889f6 100644 > > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > > @@ -25,6 +25,17 @@ properties: > > > > - fsl,imx27-pwm > > > > - items: > > > > - enum: > > > > + - fsl,imx25-pwm > > > = > > > The driver actually used fsl,imx27-pwm to bind ... > > = > > Yes, most of i.MX drivers use only few compatibles but DTSes and > > bindings use multiple of them. I was convinced during various talks > > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are > > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it > > to the another level creating compatibles for absolutely every flavor of > > their CPU. And they mainlined it in DTSes... > > = > > The PWM is this crazy examples where, as you say, only two compatibles > > are actually used for binding but DTSes uses more. > = > Yeah, these new compatible strings all seem to be used in the kernel, so > we might as well document them. > = > That said, I did want to apply this patch, but that fails. Am I missing > some other patch that you have sent out that touches this file? Actually > it looks like this is because you've based this patch on linux-next, or > perhaps the devicetree tree, because that contains commit d058717bdff4 > ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that > adds a couple more compatible strings. Probably best for Rob to pick > this up, then: > = > Acked-by: Thierry Reding > = > Rob, here's a patchwork link for you if you need one: > = > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202009252= 12609.23093-1-krzk@kernel.org/ > = > Although, looking at the devicetree-bindings instance version of that > patch, I see that it's got a failing check attached (which looks like > it can be ignored) and it's marked "Changes Requested", but no comments > saying so. I was assuming a rename at least. > Not sure if you want anything done here? I guess not, so I've applied it. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel