From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F97C433E7 for ; Tue, 13 Oct 2020 12:27:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A14F222D5 for ; Tue, 13 Oct 2020 12:27:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ova8boCd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbgJMM07 (ORCPT ); Tue, 13 Oct 2020 08:26:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbgJMM06 (ORCPT ); Tue, 13 Oct 2020 08:26:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A389AC0613D0; Tue, 13 Oct 2020 05:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7Vx9B6T8bICpioAlzEd5JffMc8VKDN49NunY21LOeXI=; b=Ova8boCdYxsjqoPe5SgGZE9a6p c57sdOEboKXe4T0r4yu5+BaXyF6bxeK6h/AkSd9P1PFwhCTABSRnObkN5tzBMsNIN7QAeqvtG/z52 vyRGfre4+fZ1yV3A1TzteDF1UguEyWSFaImr1dY0S0ylvb7nn9ARGzXeFPyvkQi7ugJOMx8Mphauz /pHUgavIymQvd0CpGVeTN9b8NU5kTIyoCpH1owGnqBlNCKcRwyYlnN3lnU1laEIzV0gOndI10mCBr WavkXbtSvJ1EzmLyvzAf3jKkiZlJjys8chkKnzmAlNi17Q/XlFRTUN7feyfJL8QM7kT4JzMMnMmnd t22YBLJQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSJOI-0006CZ-6I; Tue, 13 Oct 2020 12:26:54 +0000 Date: Tue, 13 Oct 2020 13:26:54 +0100 From: Matthew Wilcox To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Jonathan Corbet , Andreas Gruenbacher , Andrew Morton , Guoqing Jiang , Jens Axboe , Johannes Weiner , Stephen Rothwell , Thomas Gleixner , William Kucharski , Yang Shi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/24] mm: pagemap.h: fix two kernel-doc markups Message-ID: <20201013122654.GE20115@casper.infradead.org> References: <54ea6dd0fc37c48aef3fc3ae454c54a80db313dc.1602590106.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54ea6dd0fc37c48aef3fc3ae454c54a80db313dc.1602590106.git.mchehab+huawei@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2020 at 02:14:37PM +0200, Mauro Carvalho Chehab wrote: > Changeset 6c8adf8446a3 ("mm: add find_lock_head") renamed the > index parameter, but forgot to update the kernel-doc markups > accordingly. The patch is correct (thank you!), but the description here references a git commit id that's only found in the -next tree and is unstable. Andrew, can you fold this into the offending commit? > Fixes: 6c8adf8446a3 ("mm: add find_lock_head") > Signed-off-by: Mauro Carvalho Chehab > --- > include/linux/pagemap.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 7dd3523093db..932a260a29f2 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -342,9 +342,9 @@ static inline struct page *find_get_page_flags(struct address_space *mapping, > /** > * find_lock_page - locate, pin and lock a pagecache page > * @mapping: the address_space to search > - * @offset: the page index > + * @index: the page index > * > - * Looks up the page cache entry at @mapping & @offset. If there is a > + * Looks up the page cache entry at @mapping & @index. If there is a > * page cache page, it is returned locked and with an increased > * refcount. > * > @@ -361,9 +361,9 @@ static inline struct page *find_lock_page(struct address_space *mapping, > /** > * find_lock_head - Locate, pin and lock a pagecache page. > * @mapping: The address_space to search. > - * @offset: The page index. > + * @index: The page index. > * > - * Looks up the page cache entry at @mapping & @offset. If there is a > + * Looks up the page cache entry at @mapping & @index. If there is a > * page cache page, its head page is returned locked and with an increased > * refcount. > * > -- > 2.26.2 >