All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: Ido Schimmel <idosch@mellanox.com>,
	Network Development <netdev@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: vxlan_asymmetric.sh test failed every time
Date: Wed, 14 Oct 2020 09:39:16 +0800	[thread overview]
Message-ID: <20201014013916.GM2531@dhcp-12-153.nay.redhat.com> (raw)
In-Reply-To: <20201013074930.GA4024934@shredder>

On Tue, Oct 13, 2020 at 10:49:30AM +0300, Ido Schimmel wrote:
> On Tue, Oct 13, 2020 at 12:39:43PM +0800, Hangbin Liu wrote:
> > Hi Ido,
> > 
> > When run vxlan_asymmetric.sh on RHEL8, It failed every time. I though that
> > it may failed because the kernel version is too old. But today I tried with
> > latest kernel, it still failed. Would you please help check if I missed
> > any configuration?
> 
> Works OK for me:
> 
> $ sudo ./vxlan_asymmetric.sh veth0 veth1 veth2 veth3 veth4 veth5
> TEST: ping: local->local vid 10->vid 20                             [ OK ]
> TEST: ping: local->remote vid 10->vid 10                            [ OK ]
> TEST: ping: local->remote vid 20->vid 20                            [ OK ]
> TEST: ping: local->remote vid 10->vid 20                            [ OK ]
> TEST: ping: local->remote vid 20->vid 10                            [ OK ]
> INFO: deleting neighbours from vlan interfaces
> TEST: ping: local->local vid 10->vid 20                             [ OK ]
> TEST: ping: local->remote vid 10->vid 10                            [ OK ]
> TEST: ping: local->remote vid 20->vid 20                            [ OK ]
> TEST: ping: local->remote vid 10->vid 20                            [ OK ]
> TEST: ping: local->remote vid 20->vid 10                            [ OK ]
> TEST: neigh_suppress: on / neigh exists: yes                        [ OK ]
> TEST: neigh_suppress: on / neigh exists: no                         [ OK ]
> TEST: neigh_suppress: off / neigh exists: no                        [ OK ]
> TEST: neigh_suppress: off / neigh exists: yes                       [ OK ]
> 
> # uname -r
> 5.9.0-rc8-custom-36808-gccdf7fae3afa
> 
> # ip -V
> ip utility, iproute2-5.8.0
> 
> # netsniff-ng -v
> netsniff-ng 0.6.7 (Polygon Window), Git id: (none)
> 
> The first failure might be related to your rp_filter settings. Can you
> please try with this patch?
> 
> diff --git a/tools/testing/selftests/net/forwarding/vxlan_asymmetric.sh b/tools/testing/selftests/net/forwarding/vxlan_asymmetric.sh
> index a0b5f57d6bd3..0727e2012b68 100755
> --- a/tools/testing/selftests/net/forwarding/vxlan_asymmetric.sh
> +++ b/tools/testing/selftests/net/forwarding/vxlan_asymmetric.sh
> @@ -215,10 +215,16 @@ switch_create()
>  
>         bridge fdb add 00:00:5e:00:01:01 dev br1 self local vlan 10
>         bridge fdb add 00:00:5e:00:01:01 dev br1 self local vlan 20
> +
> +       sysctl_set net.ipv4.conf.all.rp_filter 0
> +       sysctl_set net.ipv4.conf.vlan10-v.rp_filter 0
> +       sysctl_set net.ipv4.conf.vlan20-v.rp_filter 0
>  }
>  
>  switch_destroy()
>  {
> +       sysctl_restore net.ipv4.conf.all.rp_filter
> +
>         bridge fdb del 00:00:5e:00:01:01 dev br1 self local vlan 20
>         bridge fdb del 00:00:5e:00:01:01 dev br1 self local vlan 10
>  
> @@ -359,6 +365,10 @@ ns_switch_create()
>  
>         bridge fdb add 00:00:5e:00:01:01 dev br1 self local vlan 10
>         bridge fdb add 00:00:5e:00:01:01 dev br1 self local vlan 20
> +
> +       sysctl_set net.ipv4.conf.all.rp_filter 0
> +       sysctl_set net.ipv4.conf.vlan10-v.rp_filter 0
> +       sysctl_set net.ipv4.conf.vlan20-v.rp_filter 0
>  }
>  export -f ns_switch_create

Thanks a lot for help debugging this issue, this patch works for me.

Tested-by: Hangbin Liu <liuhangbin@gmail.com>

  reply	other threads:[~2020-10-14  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  4:39 vxlan_asymmetric.sh test failed every time Hangbin Liu
2020-10-13  7:49 ` Ido Schimmel
2020-10-14  1:39   ` Hangbin Liu [this message]
2020-10-14 14:45     ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014013916.GM2531@dhcp-12-153.nay.redhat.com \
    --to=liuhangbin@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=idosch@idosch.org \
    --cc=idosch@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.