All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be,
	laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
	robh+dt@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: media: renesas,vin: Add V3U support
Date: Wed, 14 Oct 2020 12:11:52 +0200	[thread overview]
Message-ID: <20201014101152.mqmv2klq2mwsjlpf@oden.dyn.berto.se> (raw)
In-Reply-To: <20201014094443.11070-6-jacopo+renesas@jmondi.org>

Hi Jacopo,

Thanks for your patch.

On 2020-10-14 11:44:42 +0200, Jacopo Mondi wrote:
> Add compatible string definition for R-Car V3U.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  Documentation/devicetree/bindings/media/renesas,vin.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> index ad2fe660364b..7b629a6ea035 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> @@ -51,6 +51,7 @@ properties:
>                - renesas,vin-r8a77980 # R-Car V3H
>                - renesas,vin-r8a77990 # R-Car E3
>                - renesas,vin-r8a77995 # R-Car D3
> +              - renesas,vin-r8a779a0 # R-Car V3U

Documenting the compat string here might give the wrong impression the 
IP is supported. Which it's not as the V3U is quiet different then the 
it's siblings. Whit a new pipeline and small but important changes in in 
the register set. I'm primarily thinking about that the IFMD register is 
gone and dealing with that will be quiet significant work in the driver.

I'm not yet 100% sure the best idea is to support V3U with this driver, 
maybe it's finally time to make it more modular, with more distinct 
support for Gen2, Gen3 and a new module for V3U?

> 
>    reg:
>      maxItems: 1
> --
> 2.28.0
> 

-- 
Regards,
Niklas Söderlund

  reply	other threads:[~2020-10-14 10:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14  9:44 [PATCH 0/6] r8a779a0: Add CSI and VIN Jacopo Mondi
2020-10-14  9:44 ` [PATCH 1/6] clk: renesas: r8a779a0: Add CSI4[0-3] clocks Jacopo Mondi
2020-10-15 12:35   ` Geert Uytterhoeven
2020-10-14  9:44 ` [PATCH 2/6] dt-bindings: media: renesas,csi2: Add V3U support Jacopo Mondi
2020-10-14  9:44 ` [PATCH 3/6] arm64: dts: renesas: r8a779a0: Add CSI-2 nodes Jacopo Mondi
2020-10-15 12:43   ` Geert Uytterhoeven
2020-10-15 15:12     ` Jacopo Mondi
2020-10-14  9:44 ` [PATCH 4/6] clk: renesas: r8a779a0: Add VIN[00-31] clocks Jacopo Mondi
2020-10-14 18:55   ` Sergei Shtylyov
2020-10-15  9:32     ` Jacopo Mondi
2020-10-15  8:00       ` Sergei Shtylyov
2020-10-15 16:30       ` Geert Uytterhoeven
2020-10-16 10:01         ` Jacopo Mondi
2020-10-14  9:44 ` [PATCH 5/6] dt-bindings: media: renesas,vin: Add V3U support Jacopo Mondi
2020-10-14 10:11   ` Niklas Söderlund [this message]
2020-10-14 10:27     ` Jacopo Mondi
2020-10-14  9:44 ` [PATCH 6/6] arm64: dts: r8a779a0: Add VIN nodes Jacopo Mondi
2020-10-14 10:19   ` Niklas Söderlund
2020-10-14 10:29     ` Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014101152.mqmv2klq2mwsjlpf@oden.dyn.berto.se \
    --to=niklas.soderlund@ragnatech.se \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=jacopo+renesas@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.