* [PATCH 1/2] build: pass -no-undefined properly
@ 2020-10-14 10:46 Ross Burton
2020-10-14 10:46 ` [PATCH 2/2] build: don't check for or use libdl Ross Burton
2020-10-20 15:02 ` [PATCH 1/2] build: pass -no-undefined properly Denis Kenzior
0 siblings, 2 replies; 4+ messages in thread
From: Ross Burton @ 2020-10-14 10:46 UTC (permalink / raw)
To: ell
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
From: Ross Burton <ross.burton@arm.com>
-no-undefined was added to the libell.la LDFLAGS in commit 8391d72d,
back in 2012, as part of adding versioning. I believe there was some
confusion here as passing -no-undefined to libtool is different to
passing -no-undefined to the linker. The former changes libtool's
behaviour on Windows hosts related to static libraries, the latter will
warn if symbols are used but not defined.
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 9b3e3c9..7518c6a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -141,7 +141,7 @@ ell_libell_la_SOURCES = $(linux_headers) \
ell/icmp6.c \
ell/icmp6-private.h
-ell_libell_la_LDFLAGS = -no-undefined \
+ell_libell_la_LDFLAGS = -Wl,--no-undefined \
-Wl,--version-script=$(top_srcdir)/ell/ell.sym \
-version-info $(ELL_CURRENT):$(ELL_REVISION):$(ELL_AGE)
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] build: don't check for or use libdl
2020-10-14 10:46 [PATCH 1/2] build: pass -no-undefined properly Ross Burton
@ 2020-10-14 10:46 ` Ross Burton
2020-10-20 15:02 ` [PATCH 1/2] build: pass -no-undefined properly Denis Kenzior
1 sibling, 0 replies; 4+ messages in thread
From: Ross Burton @ 2020-10-14 10:46 UTC (permalink / raw)
To: ell
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
From: Ross Burton <ross.burton@arm.com>
Commit e129cb4 removed the plugin interface entirely, so there's no need
to look for dlopen() or pass -ldl when building.
---
configure.ac | 3 ---
ell/ell.pc.in | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 490784f..b8347e4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -108,9 +108,6 @@ AC_CHECK_FUNC(timerfd_create, dummy=yes,
AC_CHECK_FUNC(epoll_create, dummy=yes,
AC_MSG_ERROR(epoll support is required))
-AC_CHECK_LIB(dl, dlopen, dummy=yes,
- AC_MSG_ERROR(dynamic linking loader is required))
-
AC_CHECK_HEADERS(linux/types.h linux/if_alg.h)
AC_ARG_ENABLE(glib, AC_HELP_STRING([--enable-glib],
diff --git a/ell/ell.pc.in b/ell/ell.pc.in
index 4fc933b..414ea75 100644
--- a/ell/ell.pc.in
+++ b/ell/ell.pc.in
@@ -6,5 +6,5 @@ includedir=@includedir@
Name: ELL
Description: Embedded Linux library
Version: @VERSION@
-Libs: -L${libdir} -lell -ldl
+Libs: -L${libdir} -lell
Cflags: -I${includedir}
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] build: pass -no-undefined properly
2020-10-14 10:46 [PATCH 1/2] build: pass -no-undefined properly Ross Burton
2020-10-14 10:46 ` [PATCH 2/2] build: don't check for or use libdl Ross Burton
@ 2020-10-20 15:02 ` Denis Kenzior
1 sibling, 0 replies; 4+ messages in thread
From: Denis Kenzior @ 2020-10-20 15:02 UTC (permalink / raw)
To: ell
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
Hi Ross,
On 10/14/20 5:46 AM, Ross Burton wrote:
> From: Ross Burton <ross.burton@arm.com>
>
> -no-undefined was added to the libell.la LDFLAGS in commit 8391d72d,
> back in 2012, as part of adding versioning. I believe there was some
> confusion here as passing -no-undefined to libtool is different to
> passing -no-undefined to the linker. The former changes libtool's
> behaviour on Windows hosts related to static libraries, the latter will
> warn if symbols are used but not defined.
> ---
> Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Both applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] build: pass -no-undefined properly
@ 2020-09-15 18:00 Ross Burton
0 siblings, 0 replies; 4+ messages in thread
From: Ross Burton @ 2020-09-15 18:00 UTC (permalink / raw)
To: ell
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
From: Ross Burton <ross.burton@arm.com>
-no-undefined was added to the libell.la LDFLAGS in commit 8391d72d,
back in 2012, as part of adding versioning. I believe there was some
confusion here as passing -no-undefined to libtool is different to
passing -no-undefined to the linker. The former changes libtool's
behaviour on Windows hosts related to static libraries, the latter will
warn if symbols are used but not defined.
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 4eb20c6..395edc3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -138,7 +138,7 @@ ell_libell_la_SOURCES = $(linux_headers) \
ell/gpio.c \
ell/path.c
-ell_libell_la_LDFLAGS = -no-undefined \
+ell_libell_la_LDFLAGS = -Wl,--no-undefined \
-Wl,--version-script=$(top_srcdir)/ell/ell.sym \
-version-info $(ELL_CURRENT):$(ELL_REVISION):$(ELL_AGE)
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-20 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 10:46 [PATCH 1/2] build: pass -no-undefined properly Ross Burton
2020-10-14 10:46 ` [PATCH 2/2] build: don't check for or use libdl Ross Burton
2020-10-20 15:02 ` [PATCH 1/2] build: pass -no-undefined properly Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2020-09-15 18:00 Ross Burton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.