From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A497FC433DF for ; Wed, 14 Oct 2020 11:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42B0320878 for ; Wed, 14 Oct 2020 11:05:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EACMHFtl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730282AbgJNLFi (ORCPT ); Wed, 14 Oct 2020 07:05:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33281 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbgJNLFh (ORCPT ); Wed, 14 Oct 2020 07:05:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602673536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ingjVkHesWJGOLcfOeCRQ+XyVe9OrHcQ8bIZZXuyEHc=; b=EACMHFtlI95U5rLiF9xFAuSIcEaeDbXmzBCCC8zUQvBT1EWf/1cLLu04Qb7S7/7gVUNvVF GCeUrxBxb4ijvlHIRgxryYdGvi90gM/JHQCjVyN2178lob/po8MmqJDuKWlW8daLQ2EagY /AdSIQo61NPHXXyGfJt6+JsUlAcQR+k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-B6guhdFVN-6dJ49MtygEJA-1; Wed, 14 Oct 2020 07:05:34 -0400 X-MC-Unique: B6guhdFVN-6dJ49MtygEJA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17AE185C737; Wed, 14 Oct 2020 11:05:32 +0000 (UTC) Received: from krava (unknown [10.40.195.92]) by smtp.corp.redhat.com (Postfix) with SMTP id 274D55D9CD; Wed, 14 Oct 2020 11:05:27 +0000 (UTC) Date: Wed, 14 Oct 2020 13:05:27 +0200 From: Jiri Olsa To: Rob Herring Cc: Will Deacon , Catalin Marinas , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexander Shishkin , Namhyung Kim , Raphael Gault , Mark Rutland , Jonathan Cameron , Ian Rogers , honnappa.nagarahalli@arm.com, Itaru Kitayama Subject: Re: [PATCH v4 4/9] libperf: Add libperf_evsel__mmap() Message-ID: <20201014110527.GA1349644@krava> References: <20201001140116.651970-1-robh@kernel.org> <20201001140116.651970-5-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001140116.651970-5-robh@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2020 at 09:01:11AM -0500, Rob Herring wrote: SNIP > > +void *perf_evsel__mmap(struct perf_evsel *evsel, int pages) > +{ > + int ret; > + struct perf_mmap *map; > + struct perf_mmap_param mp = { > + .prot = PROT_READ | PROT_WRITE, > + }; > + > + if (FD(evsel, 0, 0) < 0) > + return NULL; > + > + mp.mask = (pages * page_size) - 1; > + > + map = zalloc(sizeof(*map)); > + if (!map) > + return NULL; > + > + perf_mmap__init(map, NULL, false, NULL); > + > + ret = perf_mmap__mmap(map, &mp, FD(evsel, 0, 0), 0); hum, so you map event for FD(0,0) but later in perf_evsel__read you allow to read any cpu/thread combination ending up reading data from FD(0,0) map: int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread, struct perf_counts_values *count) { size_t size = perf_evsel__read_size(evsel); memset(count, 0, sizeof(*count)); if (FD(evsel, cpu, thread) < 0) return -EINVAL; if (evsel->mmap && !perf_mmap__read_self(evsel->mmap, count)) return 0; I think we should either check cpu == 0, thread == 0, or make it general and store perf_evsel::mmap in xyarray as we do for fds thanks, jirka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43569C433E7 for ; Wed, 14 Oct 2020 11:07:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA2D1206D5 for ; Wed, 14 Oct 2020 11:07:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y5FB4Q6E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O40PUEsd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA2D1206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QNaWxW8Z8qwJ0BvoC2e+q/fRYgMj1S35bHwp6etEjw8=; b=Y5FB4Q6EseLgdL5t0NHHYV3Er M1rruOIE7R0sRYRdVeMyUBQuJDeM/5T28QJdDw/mgYSBBrMsHiQLfqyU0oAgD6X52qdj1VT+TDSNO 1+dr2jTgRbiffp3f3wH2VUvQdxr2W6Ub7zBl/rroL2uo9u5/gOwcz/rD4azHxBer9H+QxnfRvWsTF tLP8huxrSefBmaSwF+LpJierJOQ8FblUVrrE6JoUSPt8nKss2LX8tp3djGvhOcczzt/9IacEhbAEp w5WflNKK5JSup7GtNpFZ2k32cjRYVicB3R29MAnKhZFGTms8QfXNRCF1JEpQRtrhbSKhsEoE1yAnC Lzn1uHMlQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSebG-0004jO-RP; Wed, 14 Oct 2020 11:05:42 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSebD-0004iS-Bg for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 11:05:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602673538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ingjVkHesWJGOLcfOeCRQ+XyVe9OrHcQ8bIZZXuyEHc=; b=O40PUEsdJREjpquJG67GCVccZgb0XFbiFHXpX5XUGGYeTn3XCNScMa8MwrTEllsL74i2rk ARaQT1vB+2LhahPoot1GzRlRCi4qejynhyWB1FVXugTPLLIZC2EaTrgIpIEKbx+NWpvEeP e4YBUZb1JKTr14GdL11UkOtEU7jHhuA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-B6guhdFVN-6dJ49MtygEJA-1; Wed, 14 Oct 2020 07:05:34 -0400 X-MC-Unique: B6guhdFVN-6dJ49MtygEJA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17AE185C737; Wed, 14 Oct 2020 11:05:32 +0000 (UTC) Received: from krava (unknown [10.40.195.92]) by smtp.corp.redhat.com (Postfix) with SMTP id 274D55D9CD; Wed, 14 Oct 2020 11:05:27 +0000 (UTC) Date: Wed, 14 Oct 2020 13:05:27 +0200 From: Jiri Olsa To: Rob Herring Subject: Re: [PATCH v4 4/9] libperf: Add libperf_evsel__mmap() Message-ID: <20201014110527.GA1349644@krava> References: <20201001140116.651970-1-robh@kernel.org> <20201001140116.651970-5-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201001140116.651970-5-robh@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_070539_535605_14226A9F X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ian Rogers , Peter Zijlstra , Catalin Marinas , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Alexander Shishkin , Raphael Gault , Ingo Molnar , honnappa.nagarahalli@arm.com, Jonathan Cameron , Namhyung Kim , Itaru Kitayama , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 01, 2020 at 09:01:11AM -0500, Rob Herring wrote: SNIP > > +void *perf_evsel__mmap(struct perf_evsel *evsel, int pages) > +{ > + int ret; > + struct perf_mmap *map; > + struct perf_mmap_param mp = { > + .prot = PROT_READ | PROT_WRITE, > + }; > + > + if (FD(evsel, 0, 0) < 0) > + return NULL; > + > + mp.mask = (pages * page_size) - 1; > + > + map = zalloc(sizeof(*map)); > + if (!map) > + return NULL; > + > + perf_mmap__init(map, NULL, false, NULL); > + > + ret = perf_mmap__mmap(map, &mp, FD(evsel, 0, 0), 0); hum, so you map event for FD(0,0) but later in perf_evsel__read you allow to read any cpu/thread combination ending up reading data from FD(0,0) map: int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread, struct perf_counts_values *count) { size_t size = perf_evsel__read_size(evsel); memset(count, 0, sizeof(*count)); if (FD(evsel, cpu, thread) < 0) return -EINVAL; if (evsel->mmap && !perf_mmap__read_self(evsel->mmap, count)) return 0; I think we should either check cpu == 0, thread == 0, or make it general and store perf_evsel::mmap in xyarray as we do for fds thanks, jirka _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel