From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A90C433E7 for ; Thu, 15 Oct 2020 00:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 404A222242 for ; Thu, 15 Oct 2020 00:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602721459; bh=Xey4zQhBNv/J5a2JLBvAXKtB17xeVR+0afr6hb53bSI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VQK6wCDSGNkzYKUXMwArgFBlk6G/+MdGNL/q1bgLEtQXOpdq8wtnqsfYc6FVMyzvV d5Jl8kilrAeRbkfnuhDepzu+VlV2VKh4IMJd/VRiUmWMQ4NUKOzF12y+vKvW6wg+Kw wDIeAREBGcpI6QkV1+rOMTHRrz8bH39cK891Xv3Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732156AbgJOAYS (ORCPT ); Wed, 14 Oct 2020 20:24:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:57690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728617AbgJOAYR (ORCPT ); Wed, 14 Oct 2020 20:24:17 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 058642223F; Thu, 15 Oct 2020 00:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602721457; bh=Xey4zQhBNv/J5a2JLBvAXKtB17xeVR+0afr6hb53bSI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U7x9AdzulI/LLzSNlxR3ffJAhM6+sl1z1+OuzEG3kiaQbvOmYkp5f1DZxU5G+z/o4 cs/twMGM79t2vw3YUldgw3GlkqQVdH2+C1xIpyZ8yKWAU7XYgKHz46N6IKp8fs/g/U OnApSeCaRgmpFAraEuFCL0i2zzIKZHgy2a3Qx2qg= Date: Wed, 14 Oct 2020 17:24:15 -0700 From: Jakub Kicinski To: Mathieu Desnoyers Cc: David Ahern , "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] l3mdev icmp error route lookup fixes Message-ID: <20201014172415.4c7c1e2c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201012145016.2023-1-mathieu.desnoyers@efficios.com> References: <20201012145016.2023-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Oct 2020 10:50:13 -0400 Mathieu Desnoyers wrote: > Here is a series of fixes for ipv4 and ipv6 which ensure the route > lookup is performed on the right routing table in VRF configurations > when sending TTL expired icmp errors (useful for traceroute). > > It includes tests for both ipv4 and ipv6. > > These fixes address specifically address the code paths involved in > sending TTL expired icmp errors. As detailed in the individual commit > messages, those fixes do not address similar icmp errors related to > network namespaces and unreachable / fragmentation needed messages, > which appear to use different code paths. Applied, thank you!