All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/mtd/nand/raw/ams-delta.c:202 gpio_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR'
Date: Wed, 14 Oct 2020 19:01:46 +0800	[thread overview]
Message-ID: <202010141937.aSf3FwoI-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4121 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Miquel Raynal <miquel.raynal@bootlin.com>
CC: Boris Brezillon <bbrezillon@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b5fc7a89e58bcc059a3d5e4db79c481fb437de59
commit: 4c46667b3d67253604ee42840917844548c86657 mtd: rawnand: s/data_interface/interface_config/
date:   4 months ago
:::::: branch date: 11 hours ago
:::::: commit date: 4 months ago
config: i386-randconfig-m021-20201014 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mtd/nand/raw/ams-delta.c:202 gpio_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +202 drivers/mtd/nand/raw/ams-delta.c

3d12c0c75db0cd drivers/mtd/nand/ams-delta.c     Jonathan McDowell  2006-05-21  193  
4c46667b3d6725 drivers/mtd/nand/raw/ams-delta.c Miquel Raynal      2020-05-29  194  static int gpio_nand_setup_interface(struct nand_chip *this, int csline,
4c46667b3d6725 drivers/mtd/nand/raw/ams-delta.c Miquel Raynal      2020-05-29  195  				     const struct nand_interface_config *cf)
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  196  {
16d00cd6120689 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  197  	struct gpio_nand *priv = nand_get_controller_data(this);
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  198  	const struct nand_sdr_timings *sdr = nand_get_sdr_timings(cf);
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  199  	struct device *dev = &nand_to_mtd(this)->dev;
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  200  
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  201  	if (IS_ERR(sdr))
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 @202  		return PTR_ERR(sdr);
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  203  
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  204  	if (csline == NAND_DATA_IFACE_CHECK_ONLY)
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  205  		return 0;
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  206  
586a746b326c35 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  207  	if (priv->gpiod_nre) {
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  208  		priv->tRP = DIV_ROUND_UP(sdr->tRP_min, 1000);
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  209  		dev_dbg(dev, "using %u ns read pulse width\n", priv->tRP);
586a746b326c35 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  210  	}
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  211  
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  212  	priv->tWP = DIV_ROUND_UP(sdr->tWP_min, 1000);
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  213  	dev_dbg(dev, "using %u ns write pulse width\n", priv->tWP);
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  214  
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  215  	return 0;
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  216  }
ccada49b050f44 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12  217  

:::::: The code at line 202 was first introduced by commit
:::::: ccada49b050f44df9499859f09b822b8aebc3a4d mtd: rawnand: ams-delta: Don't hardcode read/write pulse widths

:::::: TO: Janusz Krzysztofik <jmkrzyszt@gmail.com>
:::::: CC: Miquel Raynal <miquel.raynal@bootlin.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44301 bytes --]

             reply	other threads:[~2020-10-14 11:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 11:01 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-11-14 23:49 drivers/mtd/nand/raw/ams-delta.c:202 gpio_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR' kernel test robot
2020-09-12 21:19 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202010141937.aSf3FwoI-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.