From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89411C433E7 for ; Thu, 15 Oct 2020 04:26:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B56F22257 for ; Thu, 15 Oct 2020 04:26:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mkrqoz3v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728970AbgJOE05 (ORCPT ); Thu, 15 Oct 2020 00:26:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725208AbgJOE0x (ORCPT ); Thu, 15 Oct 2020 00:26:53 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE6D9C061755; Wed, 14 Oct 2020 21:26:52 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id o7so953390pgv.6; Wed, 14 Oct 2020 21:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iNHVFd5PlmYNkQaZe4PpF7uyhE4h5AcVhJcsViTjG4s=; b=mkrqoz3vvDN/NMvvhVzk3DaTdtwjh8PG2ub0JPFYkF6/Jrxiy+XvCBt9WGb5dW+2UF UAkFTaLyrwC3kuuKbVrM5QzCHn8l/VZ7D9J2EjjtxFshy3RZTEQVKchrCE1s87LB9QBo VdruAwYXBzttt/EvywxQg55de302N6nvGE50UK8+gBub4GiPwmIRTVJ0nVxxwDPrB6tc 4Wm/AMoN/hUgaVCtpGNHmVKjooRvSsFlzqvtxJhBQT87xGQCroPDJPwJb8yKK+39AOzZ JSpBlS7+z8aNWmFwTWuNPyVYI/eEoG/8omjZVJG3BWglDc3GTfdSnY2tzz5HN7t4hGXI hY+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iNHVFd5PlmYNkQaZe4PpF7uyhE4h5AcVhJcsViTjG4s=; b=AUfQDJyVRSPZGXN4mU8zeNMnhPeMc/8JbRcyetxFzZitSj6RZAzMZcefE9iA6ie94n MAAZ5hlP2/hGb6Fz+YAD8ncfumfP6jhq3PNZOh1Q/fiS3nGfc2m50FbSlkqYbZIPkXHn S8kwPkBkT7i4gxIoVJSuou9EmOSS7U0PA3dZvMfXbWcvTyfTxFV3DTLn4NCZU2lz2n8P 19Ml/Pkfrr6LMq6PgiqHNr+zs98HG0PIrWTodCN8IRUsPuZBzlfUXvR9u7EpW08u5bt0 usFYfvJNX2hee9PaSWPeoGBcv1t1OSK1UaKeY8zkPhAWkswmGkwLXb/8Q+TZJl3VBr8p vPkQ== X-Gm-Message-State: AOAM5323nSS+nSeSHBH6yC3Gw9gvxXxEMpnFq5W7A6PtSuTLTgSgyJ6D HB+ISMeaKLWcIDBsrKAEiGE= X-Google-Smtp-Source: ABdhPJx+azL3ac6FwTk5uZqWdTaTc/lgmXZS7FZPyYt5I7pOC7d4UxouNE32nRvJZEVgyR4JlJUelg== X-Received: by 2002:aa7:9a4a:0:b029:155:323e:adae with SMTP id x10-20020aa79a4a0000b0290155323eadaemr2407909pfj.70.1602736012489; Wed, 14 Oct 2020 21:26:52 -0700 (PDT) Received: from localhost ([2001:e42:102:1532:160:16:113:140]) by smtp.gmail.com with ESMTPSA id e4sm1230371pgg.37.2020.10.14.21.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 21:26:52 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 15 Oct 2020 12:26:28 +0800 To: Benjamin Poirier Cc: devel@driverdev.osuosl.org, Shung-Hsi Yu , Willem de Bruijn , Dan Carpenter , Manish Chopra , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Greg Kroah-Hartman , "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" , open list Subject: Re: [PATCH v2 1/7] staging: qlge: replace ql_* with qlge_* to avoid namespace clashes with other qlogic drivers Message-ID: <20201015042628.42evgens2z47x3d6@Rk> References: <20201014104306.63756-1-coiby.xu@gmail.com> <20201014104306.63756-2-coiby.xu@gmail.com> <20201015010136.GB31835@f3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201015010136.GB31835@f3> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 15, 2020 at 10:01:36AM +0900, Benjamin Poirier wrote: >On 2020-10-14 18:43 +0800, Coiby Xu wrote: >> To avoid namespace clashes with other qlogic drivers and also for the >> sake of naming consistency, use the "qlge_" prefix as suggested in >> drivers/staging/qlge/TODO. >> >> Suggested-by: Benjamin Poirier >> Signed-off-by: Coiby Xu >> --- >> drivers/staging/qlge/TODO | 4 - >> drivers/staging/qlge/qlge.h | 190 ++-- >> drivers/staging/qlge/qlge_dbg.c | 1073 ++++++++++++----------- >> drivers/staging/qlge/qlge_ethtool.c | 231 ++--- >> drivers/staging/qlge/qlge_main.c | 1257 +++++++++++++-------------- >> drivers/staging/qlge/qlge_mpi.c | 352 ++++---- >> 6 files changed, 1551 insertions(+), 1556 deletions(-) >> >> diff --git a/drivers/staging/qlge/TODO b/drivers/staging/qlge/TODO >> index f93f7428f5d5..5ac55664c3e2 100644 >> --- a/drivers/staging/qlge/TODO >> +++ b/drivers/staging/qlge/TODO >> @@ -28,10 +28,6 @@ >> * the driver has a habit of using runtime checks where compile time checks are >> possible (ex. ql_free_rx_buffers(), ql_alloc_rx_buffers()) >> * reorder struct members to avoid holes if it doesn't impact performance >> -* in terms of namespace, the driver uses either qlge_, ql_ (used by >> - other qlogic drivers, with clashes, ex: ql_sem_spinlock) or nothing (with >> - clashes, ex: struct ob_mac_iocb_req). Rename everything to use the "qlge_" >> - prefix. > >You only renamed ql -> qlge. The prefix needs to be added where there is >currently none like the second example of that text. > Thank you for reminding me of the second example! >Besides, the next patch reintroduces the name struct ql_adapter. Oh, there is still a left-over ql_adapter in qlge.h (I renamed ql->qlge after initializing the devlink framework earlier but did a git rebase to make the order of the changes more reasonable). Thank you for the reminding! -- Best regards, Coiby From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FBF6C43457 for ; Thu, 15 Oct 2020 04:27:02 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC79D22243 for ; Thu, 15 Oct 2020 04:27:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mkrqoz3v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC79D22243 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4E5B22E602; Thu, 15 Oct 2020 04:27:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ECz3Xoh1QckH; Thu, 15 Oct 2020 04:26:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 0E4612E603; Thu, 15 Oct 2020 04:26:58 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id E5D231BF31D for ; Thu, 15 Oct 2020 04:26:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id DB31E2E605 for ; Thu, 15 Oct 2020 04:26:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zLp9u3TBCnoO for ; Thu, 15 Oct 2020 04:26:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by silver.osuosl.org (Postfix) with ESMTPS id D501E2E604 for ; Thu, 15 Oct 2020 04:26:52 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id 10so1209711pfp.5 for ; Wed, 14 Oct 2020 21:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iNHVFd5PlmYNkQaZe4PpF7uyhE4h5AcVhJcsViTjG4s=; b=mkrqoz3vvDN/NMvvhVzk3DaTdtwjh8PG2ub0JPFYkF6/Jrxiy+XvCBt9WGb5dW+2UF UAkFTaLyrwC3kuuKbVrM5QzCHn8l/VZ7D9J2EjjtxFshy3RZTEQVKchrCE1s87LB9QBo VdruAwYXBzttt/EvywxQg55de302N6nvGE50UK8+gBub4GiPwmIRTVJ0nVxxwDPrB6tc 4Wm/AMoN/hUgaVCtpGNHmVKjooRvSsFlzqvtxJhBQT87xGQCroPDJPwJb8yKK+39AOzZ JSpBlS7+z8aNWmFwTWuNPyVYI/eEoG/8omjZVJG3BWglDc3GTfdSnY2tzz5HN7t4hGXI hY+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iNHVFd5PlmYNkQaZe4PpF7uyhE4h5AcVhJcsViTjG4s=; b=IO1UxKusULu+sSGjzUGLue0rZ9B3Md0HXJOfWwNC0rQ7UVfAm0FgYEnOqFA66J/hPq Zuny9awpcJCF+fss0D6ZCYI2h6OnhGXlRN+WGht2JixFUovY01NtKiN7V7iVUpMcNoh3 O4YO0diq4ffrrFU6LwIKFyyW4MomTkQpVS++tcZ14k/iZX3+N97OcViCBKvy1WxVSifp fEoHlJPx2IJ5HD5WFwwIvsX4t3X44AqLMjWnixcJBj7CAPsUpvzMvi6gVs/mPtXUbN94 QrOS5p5kkWkxvvA63e2jIkR0whKuwJ1iF+QNspgDJAHLeIqJ506HUUYMgFLjv5m7u5lp JfPA== X-Gm-Message-State: AOAM533cczhNoQxUWp3V6SBwurdGxs3Bbakog9LSRdzYCx8S3M1lzTXJ o6Bof8Q+OUzPZ3CLOIs+vC9GB4R7r80UMM8J X-Google-Smtp-Source: ABdhPJx+azL3ac6FwTk5uZqWdTaTc/lgmXZS7FZPyYt5I7pOC7d4UxouNE32nRvJZEVgyR4JlJUelg== X-Received: by 2002:aa7:9a4a:0:b029:155:323e:adae with SMTP id x10-20020aa79a4a0000b0290155323eadaemr2407909pfj.70.1602736012489; Wed, 14 Oct 2020 21:26:52 -0700 (PDT) Received: from localhost ([2001:e42:102:1532:160:16:113:140]) by smtp.gmail.com with ESMTPSA id e4sm1230371pgg.37.2020.10.14.21.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 21:26:52 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 15 Oct 2020 12:26:28 +0800 To: Benjamin Poirier Subject: Re: [PATCH v2 1/7] staging: qlge: replace ql_* with qlge_* to avoid namespace clashes with other qlogic drivers Message-ID: <20201015042628.42evgens2z47x3d6@Rk> References: <20201014104306.63756-1-coiby.xu@gmail.com> <20201014104306.63756-2-coiby.xu@gmail.com> <20201015010136.GB31835@f3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201015010136.GB31835@f3> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Willem de Bruijn , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Manish Chopra , Greg Kroah-Hartman , Shung-Hsi Yu , open list , "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Dan Carpenter Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Oct 15, 2020 at 10:01:36AM +0900, Benjamin Poirier wrote: >On 2020-10-14 18:43 +0800, Coiby Xu wrote: >> To avoid namespace clashes with other qlogic drivers and also for the >> sake of naming consistency, use the "qlge_" prefix as suggested in >> drivers/staging/qlge/TODO. >> >> Suggested-by: Benjamin Poirier >> Signed-off-by: Coiby Xu >> --- >> drivers/staging/qlge/TODO | 4 - >> drivers/staging/qlge/qlge.h | 190 ++-- >> drivers/staging/qlge/qlge_dbg.c | 1073 ++++++++++++----------- >> drivers/staging/qlge/qlge_ethtool.c | 231 ++--- >> drivers/staging/qlge/qlge_main.c | 1257 +++++++++++++-------------- >> drivers/staging/qlge/qlge_mpi.c | 352 ++++---- >> 6 files changed, 1551 insertions(+), 1556 deletions(-) >> >> diff --git a/drivers/staging/qlge/TODO b/drivers/staging/qlge/TODO >> index f93f7428f5d5..5ac55664c3e2 100644 >> --- a/drivers/staging/qlge/TODO >> +++ b/drivers/staging/qlge/TODO >> @@ -28,10 +28,6 @@ >> * the driver has a habit of using runtime checks where compile time checks are >> possible (ex. ql_free_rx_buffers(), ql_alloc_rx_buffers()) >> * reorder struct members to avoid holes if it doesn't impact performance >> -* in terms of namespace, the driver uses either qlge_, ql_ (used by >> - other qlogic drivers, with clashes, ex: ql_sem_spinlock) or nothing (with >> - clashes, ex: struct ob_mac_iocb_req). Rename everything to use the "qlge_" >> - prefix. > >You only renamed ql -> qlge. The prefix needs to be added where there is >currently none like the second example of that text. > Thank you for reminding me of the second example! >Besides, the next patch reintroduces the name struct ql_adapter. Oh, there is still a left-over ql_adapter in qlge.h (I renamed ql->qlge after initializing the devlink framework earlier but did a git rebase to make the order of the changes more reasonable). Thank you for the reminding! -- Best regards, Coiby _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel