From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C4BC433DF for ; Thu, 15 Oct 2020 08:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FB4622249 for ; Thu, 15 Oct 2020 08:29:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="pgkE/6OO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728072AbgJOI3y (ORCPT ); Thu, 15 Oct 2020 04:29:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726996AbgJOI3y (ORCPT ); Thu, 15 Oct 2020 04:29:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F8CC061755 for ; Thu, 15 Oct 2020 01:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SAm3ygmYG5mR1kg+ndf0KkSBRNrx3+O+9Fxp+RHtxcQ=; b=pgkE/6OOEPxvekUybVOnv5yy5W CucufnEu26NyuG3Hokr+1rOaud8ggU/X2PUWpuyx8Z+03IZfWFHBCnAx4BbdPN8fObSQ4j5Gu8uFB otifKYxzqsd99Qc6MOZNwqqu29RPqZ5WLMQfy6OfZ/obHQ6JHWQd6uscy6d3rHQ9GCmgTgVyfKJBm GasEF4wDv2Yu6DDm8/vaBBNVV8EueFGqbqUALwOSSU8m291a4m6wdbnLKGFeeQWMA7dQNSSOCnMAE ZkZg28L3HOsPQTomsynKbIMO65wHu+sZp4H63ob881PGw7quUOVohZK17iHV8kILBXoWJuo1UOsmV JkSdk5/g==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSydq-0001MW-ED; Thu, 15 Oct 2020 08:29:42 +0000 Date: Thu, 15 Oct 2020 09:29:42 +0100 From: Christoph Hellwig To: xiakaixu1987@gmail.com Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com, Kaixu Xia Subject: Re: [RFC PATCH] xfs: remove unnecessary null check in xfs_generic_create Message-ID: <20201015082942.GD4450@infradead.org> References: <1602232150-28805-1-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1602232150-28805-1-git-send-email-kaixuxia@tencent.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Oct 09, 2020 at 04:29:10PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The function posix_acl_release() test the passed-in argument and > move on only when it is non-null, so maybe the null check in > xfs_generic_create is unnecessary. > > Signed-off-by: Kaixu Xia Looks good, Reviewed-by: Christoph Hellwig