Re: [dpdk-dev] [PATCH] net/failsafe: check correct error code while handling sub-device add

From: "Gaëtan Rivet" <grive@u256.net>
To: Long Li <longli@linuxonhyperv.com>
Cc: dev@dpdk.org, Long Li <longli@microsoft.com>, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: check correct error code while handling sub-device add
Date: Thu, 15 Oct 2020 12:11:42 +0200	[thread overview]
Message-ID: <20201015101142.or6nuf675qtwgmws@u256.net> (raw)
In-Reply-To: <1601683308-18738-1-git-send-email-longli@linuxonhyperv.com>

On 02/10/20 17:01 -0700, Long Li wrote:
> From: Long Li <longli@microsoft.com>
> 
> When adding a sub-device, it's possible that the sub-device is configured
> successfully but later fails to start. This error should not be masked.
> The driver needs to check the error status to prevent endless loop of
> trying to start the sub-device.
> 
> fixes (ae80146c5a1b net/failsafe: fix removed device handling)
> 
> cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
>  drivers/net/failsafe/failsafe_private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h
> index 651578a..c58c0de 100644
> --- a/drivers/net/failsafe/failsafe_private.h
> +++ b/drivers/net/failsafe/failsafe_private.h
> @@ -497,7 +497,7 @@ int failsafe_eth_new_event_callback(uint16_t port_id,
>  fs_err(struct sub_device *sdev, int err)
>  {
>  	/* A device removal shouldn't be reported as an error. */
> -	if (sdev->remove == 1 || err == -EIO)
> +	if (sdev->remove == 1 && err == -EIO)
>  		return rte_errno = 0;
>  	return err;
>  }
> -- 
> 1.8.3.1
> 

This bug has been fixed by the following commit:
http://mails.dpdk.org/archives/dev/2020-October/185921.html

Thanks for validating this other fix Li, it has been
integrated.

This patch can be dropped (nack).

-- 
Gaëtan