All of
 help / color / mirror / Atom feed
From: Marek Vasut <>
Cc: Marek Vasut <>, Angus Ainslie <>,
	"David S . Miller" <>,
	Jakub Kicinski <>,
	Kalle Valo <>,
	Lee Jones <>,
	Martin Kepplinger <>,
	Sebastian Krzyszkowiak <>,
	Siva Rebbagondla <>,
Subject: [PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP
Date: Thu, 15 Oct 2020 13:16:16 +0200	[thread overview]
Message-ID: <> (raw)

In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode,
the association fails. The former is using wpa_supplicant during association,
the later is set up using hostapd:

iwl$ cat hostapd.conf
iwl$ hostapd -d hostapd.conf

rsi$ wpa_supplicant -i wlan0 -c <(wpa_passphrase test test)

The problem is that the TX EAPOL data descriptor RSI_DESC_REQUIRE_CFM_TO_HOST
flag and extended descriptor EAPOL4_CONFIRM frame type are not set in case the
AP is iwlwifi, because in that case the TX EAPOL packet is 2 bytes shorter.

The downstream vendor driver has this change in place already [1], however
there is no explanation for it, neither is there any commit history from which
such explanation could be obtained.


Signed-off-by: Marek Vasut <>
Cc: Angus Ainslie <>
Cc: David S. Miller <>
Cc: Jakub Kicinski <>
Cc: Kalle Valo <>
Cc: Lee Jones <>
Cc: Martin Kepplinger <>
Cc: Sebastian Krzyszkowiak <>
Cc: Siva Rebbagondla <>
 drivers/net/wireless/rsi/rsi_91x_hal.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
index 3f7e3cfb6f00..ce9892152f4d 100644
--- a/drivers/net/wireless/rsi/rsi_91x_hal.c
+++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
@@ -248,7 +248,8 @@ int rsi_prepare_data_desc(struct rsi_common *common, struct sk_buff *skb)
 					(skb->len - FRAME_DESC_SZ),
-		if ((skb->len - header_size) == EAPOL4_PACKET_LEN) {
+		if (((skb->len - header_size) == EAPOL4_PACKET_LEN) ||
+		    ((skb->len - header_size) == EAPOL4_PACKET_LEN - 2)) {
 			data_desc->misc_flags |=
 			xtend_desc->confirm_frame_type = EAPOL4_CONFIRM;

             reply	other threads:[~2020-10-15 11:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 11:16 Marek Vasut [this message]
2020-11-07 11:32 ` [PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP Kalle Valo
2021-05-27 16:52 ` Martin Fuzzey
2021-05-27 17:07   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.