From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F33C433DF for ; Thu, 15 Oct 2020 17:26:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C5852225E for ; Thu, 15 Oct 2020 17:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602782796; bh=3O/eM9/wBpQabvttClKuMGrs50v76YaYlpO9NRumXDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mlsFZ48+BZN4VLd8LpHoUpugnXjVjjW6DVbq5tCgMz0CLCbguaLgEtpl5z6hy5fOn DAtmBWyo6pM40jTmJ9t1U+vFIuoRucorwBZKJ7271cjOgUlwnpmGJ8+33kD3bo+POg igxYIn7CF9wUEy58f0Zx0fLAEDAt/Q+jffB9Qfb0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728720AbgJOR0f (ORCPT ); Thu, 15 Oct 2020 13:26:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:42288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgJOR0e (ORCPT ); Thu, 15 Oct 2020 13:26:34 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DB1822210; Thu, 15 Oct 2020 17:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602782793; bh=3O/eM9/wBpQabvttClKuMGrs50v76YaYlpO9NRumXDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AZk+EfB5w2VcyWwWdRH6LPD8cCpS4IphLNnX7Om1oR33bkZPndkUmy9uwyrHk8edM a2a/V4+t1Hfaf4s+/TPS7rPR7if7YnoeAWNkJKPHOeWRFOGmbTD/FXruAvsLxHeZcC HCW1VYZmmBwCeOA+Sp9PdFSGL9WDhqjivei7Jg2I= Date: Thu, 15 Oct 2020 19:27:06 +0200 From: Greg KH To: Alex Williamson Cc: Laurentiu Tudor , Diana Craciun , linux-kernel@vger.kernel.org, stuyoder@gmail.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 00/13] bus/fsl-mc: Extend mc-bus driver functionalities in preparation for mc-bus VFIO support Message-ID: <20201015172706.GA85496@kroah.com> References: <20200929085441.17448-1-diana.craciun@oss.nxp.com> <8b3c1222-5dbd-5c51-ac10-8b1c1a69d2d5@nxp.com> <20201002135512.GA3466738@kroah.com> <9e5576fb-6e42-4216-286c-7afb7979ed0b@nxp.com> <20201002140549.GA3492850@kroah.com> <20201014202742.43b0ff18@x1.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201014202742.43b0ff18@x1.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 08:27:42PM -0600, Alex Williamson wrote: > On Fri, 2 Oct 2020 16:05:49 +0200 > Greg KH wrote: > > > On Fri, Oct 02, 2020 at 04:56:52PM +0300, Laurentiu Tudor wrote: > > > Hi Greg, > > > > > > On 10/2/2020 4:55 PM, Greg KH wrote: > > > > On Tue, Sep 29, 2020 at 02:06:41PM +0300, Laurentiu Tudor wrote: > > > >> > > > >> > > > >> On 9/29/2020 11:54 AM, Diana Craciun wrote: > > > >>> The vfio-mc bus driver needs some additional services to be exported by the > > > >>> mc-bus driver like: > > > >>> - a way to reset the DPRC container > > > >>> - driver_override support > > > >>> - functions to setup/tear down a DPRC > > > >>> - functions for allocating the pool of interrupts. In case of VFIO the > > > >>> interrupts are not configured at probe time, but later by userspace > > > >>> request > > > >>> > > > >>> v4 -> v5 > > > >>> - dprc_celanup should not fail > > > >>> > > > >>> v3 -> v4 > > > >>> - Rebased on the latest kernel. > > > >>> - Exported a dprc_remove function > > > >>> > > > >>> v2 -> v3 > > > >>> - Add a new version for dprc_get_obj_region > > > >>> - Export the cacheability bus specific bits defines > > > >>> > > > >>> v1 -> v2 > > > >>> - Remove driver_override propagation through various functions > > > >>> - Cache the DPRC API version > > > >>> > > > >>> The patches are related with "vfio/fsl-mc: VFIO support for FSL-MC > > > >>> devices" patches, but the series were split because they are targeting > > > >>> different subsystems. However, the mc-bus patches may suffer changes > > > >>> when addressing the VFIO review comments. > > > >>> > > > >>> The patches do not address the comment regarding moving driver_override > > > >>> in the core code. I prefer not to tie these patches on that change and > > > >>> address that separately. > > > >>> > > > >>> Bharat Bhushan (3): > > > >>> bus/fsl-mc: add support for 'driver_override' in the mc-bus > > > >>> bus/fsl-mc: Add dprc-reset-container support > > > >>> bus/fsl-mc: Extend ICID size from 16bit to 32bit > > > >>> > > > >>> Diana Craciun (10): > > > >>> bus/fsl-mc: Do no longer export the total number of irqs outside > > > >>> dprc_scan_objects > > > >>> bus/fsl-mc: Add a new parameter to dprc_scan_objects function > > > >>> bus/fsl-mc: Set the QMAN/BMAN region flags > > > >>> bus/fsl-mc: Cache the DPRC API version > > > >>> bus/fsl-mc: Export dprc_scan/dprc_remove functions to be used by > > > >>> multiple entities > > > >>> bus/fsl-mc: Export a cleanup function for DPRC > > > >>> bus/fsl-mc: Add a container setup function > > > >>> bus/fsl_mc: Do not rely on caller to provide non NULL mc_io > > > >>> bus/fsl-mc: Export IRQ pool handling functions to be used by VFIO > > > >>> bus/fsl-mc: Add a new version for dprc_get_obj_region command > > > >>> > > > >>> drivers/bus/fsl-mc/dprc-driver.c | 190 ++++++++++++++++---------- > > > >>> drivers/bus/fsl-mc/dprc.c | 141 +++++++++++++++---- > > > >>> drivers/bus/fsl-mc/fsl-mc-allocator.c | 12 +- > > > >>> drivers/bus/fsl-mc/fsl-mc-bus.c | 64 ++++++++- > > > >>> drivers/bus/fsl-mc/fsl-mc-private.h | 31 ++--- > > > >>> drivers/bus/fsl-mc/mc-io.c | 7 +- > > > >>> include/linux/fsl/mc.h | 41 +++++- > > > >>> 7 files changed, 359 insertions(+), 127 deletions(-) > > > >>> > > > >> > > > >> For the series: > > > >> Reviewed-by: Laurentiu Tudor > > > >> Acked-by: Laurentiu Tudor > > > > > > > > Do you want me to take these patches in my tree, or are they going to > > > > Linus some other way? > > > > > > I'm prefectly fine with you picking up the patches through your tree. > > > > Great, now queued up. > > Hi Greg, > > Diana has a vfio bus driver for fsl-mc devices queued up in my tree as > well. After a linux-next build failure due to our branches being > applied in the wrong order, Stephen advised that the proper way to > handle this is to merge a shared branch with this series. Do you have > a pull request imminent with this series or if not, would you mind > pushing such a branch? Thanks, This should all now be in Linus's tree, so I don't think you need any shared branch anymore :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D390C43457 for ; Thu, 15 Oct 2020 17:28:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2399222210 for ; Thu, 15 Oct 2020 17:28:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w9vVbqoc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AZk+EfB5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2399222210 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=35VyTK6tdWWXmTSBYY6UpTmwIwn1BQCUEzBVGR4Lhbs=; b=w9vVbqoc2VMHYoME31SDX99GS cAvsshR6Fl9QcH94yJHjVv9xd+Wshj1xw+usLeCsYRkxyW/YjAWK5zZb1KakOXbwmLZOE0w2ZenPc 3QEx6H6H+njo5BumY9EFY/Gm67wrElVYXDe+xgs4CENqDQXYZPUu99R8saq5/ul7FshsIpu96XJps IFMEM4yQgaknoCxV/Fth374wyUcN53Rbz6NBbLj6//QwkxpcWioW8/GIzTeh91vTs3e4YUgHVcPJp fIfUD5+DcydE6waJdHfzUxR4XTU7QsYwn7SmZnZt3HpLTbNtax+zBpw1MM5LEJwsiFphpGpMdQ/0f fK3qRipZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT71T-00069H-5G; Thu, 15 Oct 2020 17:26:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT71Q-00068h-F7 for linux-arm-kernel@lists.infradead.org; Thu, 15 Oct 2020 17:26:37 +0000 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DB1822210; Thu, 15 Oct 2020 17:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602782793; bh=3O/eM9/wBpQabvttClKuMGrs50v76YaYlpO9NRumXDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AZk+EfB5w2VcyWwWdRH6LPD8cCpS4IphLNnX7Om1oR33bkZPndkUmy9uwyrHk8edM a2a/V4+t1Hfaf4s+/TPS7rPR7if7YnoeAWNkJKPHOeWRFOGmbTD/FXruAvsLxHeZcC HCW1VYZmmBwCeOA+Sp9PdFSGL9WDhqjivei7Jg2I= Date: Thu, 15 Oct 2020 19:27:06 +0200 From: Greg KH To: Alex Williamson Subject: Re: [PATCH v5 00/13] bus/fsl-mc: Extend mc-bus driver functionalities in preparation for mc-bus VFIO support Message-ID: <20201015172706.GA85496@kroah.com> References: <20200929085441.17448-1-diana.craciun@oss.nxp.com> <8b3c1222-5dbd-5c51-ac10-8b1c1a69d2d5@nxp.com> <20201002135512.GA3466738@kroah.com> <9e5576fb-6e42-4216-286c-7afb7979ed0b@nxp.com> <20201002140549.GA3492850@kroah.com> <20201014202742.43b0ff18@x1.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014202742.43b0ff18@x1.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_132636_661164_203B5DAB X-CRM114-Status: GOOD ( 35.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stuyoder@gmail.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, Diana Craciun , linux-arm-kernel@lists.infradead.org, Laurentiu Tudor Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 08:27:42PM -0600, Alex Williamson wrote: > On Fri, 2 Oct 2020 16:05:49 +0200 > Greg KH wrote: > > > On Fri, Oct 02, 2020 at 04:56:52PM +0300, Laurentiu Tudor wrote: > > > Hi Greg, > > > > > > On 10/2/2020 4:55 PM, Greg KH wrote: > > > > On Tue, Sep 29, 2020 at 02:06:41PM +0300, Laurentiu Tudor wrote: > > > >> > > > >> > > > >> On 9/29/2020 11:54 AM, Diana Craciun wrote: > > > >>> The vfio-mc bus driver needs some additional services to be exported by the > > > >>> mc-bus driver like: > > > >>> - a way to reset the DPRC container > > > >>> - driver_override support > > > >>> - functions to setup/tear down a DPRC > > > >>> - functions for allocating the pool of interrupts. In case of VFIO the > > > >>> interrupts are not configured at probe time, but later by userspace > > > >>> request > > > >>> > > > >>> v4 -> v5 > > > >>> - dprc_celanup should not fail > > > >>> > > > >>> v3 -> v4 > > > >>> - Rebased on the latest kernel. > > > >>> - Exported a dprc_remove function > > > >>> > > > >>> v2 -> v3 > > > >>> - Add a new version for dprc_get_obj_region > > > >>> - Export the cacheability bus specific bits defines > > > >>> > > > >>> v1 -> v2 > > > >>> - Remove driver_override propagation through various functions > > > >>> - Cache the DPRC API version > > > >>> > > > >>> The patches are related with "vfio/fsl-mc: VFIO support for FSL-MC > > > >>> devices" patches, but the series were split because they are targeting > > > >>> different subsystems. However, the mc-bus patches may suffer changes > > > >>> when addressing the VFIO review comments. > > > >>> > > > >>> The patches do not address the comment regarding moving driver_override > > > >>> in the core code. I prefer not to tie these patches on that change and > > > >>> address that separately. > > > >>> > > > >>> Bharat Bhushan (3): > > > >>> bus/fsl-mc: add support for 'driver_override' in the mc-bus > > > >>> bus/fsl-mc: Add dprc-reset-container support > > > >>> bus/fsl-mc: Extend ICID size from 16bit to 32bit > > > >>> > > > >>> Diana Craciun (10): > > > >>> bus/fsl-mc: Do no longer export the total number of irqs outside > > > >>> dprc_scan_objects > > > >>> bus/fsl-mc: Add a new parameter to dprc_scan_objects function > > > >>> bus/fsl-mc: Set the QMAN/BMAN region flags > > > >>> bus/fsl-mc: Cache the DPRC API version > > > >>> bus/fsl-mc: Export dprc_scan/dprc_remove functions to be used by > > > >>> multiple entities > > > >>> bus/fsl-mc: Export a cleanup function for DPRC > > > >>> bus/fsl-mc: Add a container setup function > > > >>> bus/fsl_mc: Do not rely on caller to provide non NULL mc_io > > > >>> bus/fsl-mc: Export IRQ pool handling functions to be used by VFIO > > > >>> bus/fsl-mc: Add a new version for dprc_get_obj_region command > > > >>> > > > >>> drivers/bus/fsl-mc/dprc-driver.c | 190 ++++++++++++++++---------- > > > >>> drivers/bus/fsl-mc/dprc.c | 141 +++++++++++++++---- > > > >>> drivers/bus/fsl-mc/fsl-mc-allocator.c | 12 +- > > > >>> drivers/bus/fsl-mc/fsl-mc-bus.c | 64 ++++++++- > > > >>> drivers/bus/fsl-mc/fsl-mc-private.h | 31 ++--- > > > >>> drivers/bus/fsl-mc/mc-io.c | 7 +- > > > >>> include/linux/fsl/mc.h | 41 +++++- > > > >>> 7 files changed, 359 insertions(+), 127 deletions(-) > > > >>> > > > >> > > > >> For the series: > > > >> Reviewed-by: Laurentiu Tudor > > > >> Acked-by: Laurentiu Tudor > > > > > > > > Do you want me to take these patches in my tree, or are they going to > > > > Linus some other way? > > > > > > I'm prefectly fine with you picking up the patches through your tree. > > > > Great, now queued up. > > Hi Greg, > > Diana has a vfio bus driver for fsl-mc devices queued up in my tree as > well. After a linux-next build failure due to our branches being > applied in the wrong order, Stephen advised that the proper way to > handle this is to merge a shared branch with this series. Do you have > a pull request imminent with this series or if not, would you mind > pushing such a branch? Thanks, This should all now be in Linus's tree, so I don't think you need any shared branch anymore :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel