From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E66ABC433DF for ; Thu, 15 Oct 2020 21:39:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A958320759 for ; Thu, 15 Oct 2020 21:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="cygGspVM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A958320759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2F8289C9A; Thu, 15 Oct 2020 21:39:35 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2CB089C9A for ; Thu, 15 Oct 2020 21:39:34 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id b8so328183wrn.0 for ; Thu, 15 Oct 2020 14:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VkmG945wFzG5BfT2NTULPP0qWg5gV/q6DoFymEiqOoY=; b=cygGspVM6eMrfeBQrTbykOtkdrMODza1BGfnjZKt3Hlfhewv1KqiRHCxd7/dV80lDh gfHrBKx02l1fTFd4kefE5hHUmqvtevZE+9DC5RvExje/CJ7kF4uUhzAal5YKJpHcXqZx DJ2SbsQPPzBbmn3smx5ncNgPGskdNrhMGnPrg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VkmG945wFzG5BfT2NTULPP0qWg5gV/q6DoFymEiqOoY=; b=MqMcqijSpK4iB7rbUl6o0YQ2VpnX2giftFDxHvZXYdVRzfTNzulMPdpoe+qhLzFhoy vKzYqrHkOAM4l9qpBCadfZ/7Iurkhy9g82URPkQQtEtnq4EBR6ZtJSeHBhzIeiholWsC kaI1SGnd5mP0rXdO+zNmsRq2BXaKWm9qqH/LTy3h3bB+kkLrmESAcyE2XK89zT50y1By 3gRSbfJXehJc9sKO2rVF/kXuLwSuOi+DfvxLQjdqIZpD0rXQpvd9ZEUxHFAJ6aovZGYd h+iMkR4rVxaNxX5MYWs8uLzDnzxR4hehcM42XEqOazKgetUSEsGlhlt3Z2nF1hVnGzLU 41mg== X-Gm-Message-State: AOAM532bt30Rl7WrGh6bJXFCrHXM4LCgJq3C+OdGSJgcR6/XFJiUVXJy ANIPbg8oJBPsNq/fLMahwha/tA== X-Google-Smtp-Source: ABdhPJzPrO6RkyHXwphh3j6TPS/10ZzEaI84CS0+Gw5CeeQCAHg17C4Vmy/9tYHT/bH8/Rb0mIfFhg== X-Received: by 2002:adf:8462:: with SMTP id 89mr252640wrf.389.1602797973652; Thu, 15 Oct 2020 14:39:33 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b15sm807134wrm.65.2020.10.15.14.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 14:39:32 -0700 (PDT) Date: Thu, 15 Oct 2020 23:39:30 +0200 From: Daniel Vetter To: Melissa Wen Subject: Re: [PATCH 1/3] drm/vkms: Set preferred depth correctly Message-ID: <20201015213930.GD401619@phenom.ffwll.local> References: <20201009232156.3916879-1-daniel.vetter@ffwll.ch> <20201012125922.utoehriuovbs66bk@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201012125922.utoehriuovbs66bk@smtp.gmail.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , Rodrigo Siqueira , Daniel Vetter , DRI Development , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 12, 2020 at 09:59:22AM -0300, Melissa Wen wrote: > On 10/10, Daniel Vetter wrote: > > The only thing we support is xrgb8888. > > > > Signed-off-by: Daniel Vetter > > Cc: Rodrigo Siqueira > > Cc: Melissa Wen > > Cc: Haneen Mohammed > > Cc: Daniel Vetter > > --- > > drivers/gpu/drm/vkms/vkms_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > > index 726801ab44d4..eb4007443706 100644 > > --- a/drivers/gpu/drm/vkms/vkms_drv.c > > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > > @@ -124,7 +124,7 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev) > > dev->mode_config.max_height = YRES_MAX; > > dev->mode_config.cursor_width = 512; > > dev->mode_config.cursor_height = 512; > > - dev->mode_config.preferred_depth = 24; > > + dev->mode_config.preferred_depth = 32; > nice catch! > > > dev->mode_config.helper_private = &vkms_mode_config_helpers; > > > > return vkms_output_init(vkmsdev, 0); > > -- > > 2.28.0 > > > Thanks, > > Reviewed-by: Melissa Wen I merged the first 2 patches of this series, but noticed that you didn't reply with a r-b tag on the 3rd patch. Is that intentional or just oversight? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel