From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD79C433DF for ; Fri, 16 Oct 2020 03:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4992E2087D for ; Fri, 16 Oct 2020 03:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602817898; bh=tkkofZ7qD82CsOvPieJHBNYt4OyOhg5WwZnbkEnr6T8=; h=Date:From:To:Subject:In-Reply-To:Reply-To:List-ID:From; b=JbwljEV+XjQT+4R0KA9wabWt1ff04UUrlttlMD1ZsohYeqfDrUvTbsWkDlDWAr797 /cqp1/QAyvXRlUdRqc558ZMZWKiyualEaa1AizMMCFHc5jgyCC0yfHGkemUafyt/86 ctXfNKvNPyWdXbrPsujd9XvLkxlKyu2AtPCLNkKk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388468AbgJPDLh (ORCPT ); Thu, 15 Oct 2020 23:11:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:48064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387864AbgJPDLh (ORCPT ); Thu, 15 Oct 2020 23:11:37 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 787D820878; Fri, 16 Oct 2020 03:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602817895; bh=tkkofZ7qD82CsOvPieJHBNYt4OyOhg5WwZnbkEnr6T8=; h=Date:From:To:Subject:In-Reply-To:From; b=UEB7ev0ynGWQSIopc5q/oyfHxNL1pIVRPgIrMqvq2YsCAsZP9/iwLwIRZ2K/GYTh6 uzDd02JQk6XOMyf1aPqEKil4z3VM+tyd3fY+uH/ko9/sznnTQhtwh6QxAS3XSY222D 2wgQ1DsmmwcnH/J/or4CIMHRJvf0zmq8hR1CZQCw= Date: Thu, 15 Oct 2020 20:11:34 -0700 From: Andrew Morton To: akpm@linux-foundation.org, dan.carpenter@oracle.com, dan.j.williams@intel.com, jgg@ziepe.ca, jglisse@redhat.com, mm-commits@vger.kernel.org, rcampbell@nvidia.com, sfr@canb.auug.org.au, torvalds@linux-foundation.org Subject: [patch 117/156] lib/test_hmm.c: fix an error code in dmirror_allocate_chunk() Message-ID: <20201016031134.vgIvSP9No%akpm@linux-foundation.org> In-Reply-To: <20201015194043.84cda0c1d6ca2a6847f2384a@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Dan Carpenter Subject: lib/test_hmm.c: fix an error code in dmirror_allocate_chunk() This is supposed to return false on failure, not a negative error code. Link: https://lkml.kernel.org/r/20201010200812.GA1886610@mwanda Fixes: 170e38548b81 ("mm/hmm/test: use after free in dmirror_allocate_chunk()") Signed-off-by: Dan Carpenter Reviewed-by: Ralph Campbell Cc: Jerome Glisse Cc: Stephen Rothwell Cc: Jason Gunthorpe Cc: Dan Williams Signed-off-by: Andrew Morton --- lib/test_hmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/test_hmm.c~mm-hmm-test-fix-an-error-code-in-dmirror_allocate_chunk +++ a/lib/test_hmm.c @@ -461,7 +461,7 @@ static bool dmirror_allocate_chunk(struc devmem = kzalloc(sizeof(*devmem), GFP_KERNEL); if (!devmem) - return -ENOMEM; + return false; res = request_free_mem_region(&iomem_resource, DEVMEM_CHUNK_SIZE, "hmm_dmirror"); _