From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33955C433E7 for ; Fri, 16 Oct 2020 10:11:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FD9820848 for ; Fri, 16 Oct 2020 10:11:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DRC+1IKG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FD9820848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A63556E9C0; Fri, 16 Oct 2020 10:11:05 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 902C06E9C0 for ; Fri, 16 Oct 2020 10:11:04 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id s9so2070780wro.8 for ; Fri, 16 Oct 2020 03:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OqgK8GE8u8GgE7hCKgynT+rKrVW8dlpriZEb87vuAJM=; b=DRC+1IKG80ExkDHK/pP2DhvMdszkHIcaOw2nDv7BEjmpsGyM1MSi9YCX8ZdmimwXqu wjL6XOCkfKO9IBk8fGPrC7C54RQuokjuflCJgymxYlwgUtB2LwFZeM5ElArFOLJEUdh6 Y8shi5MXlDcy4d9Zz41VDBJcoJTzL9Coy2rrIFlxAplsZ9WGxfuHn7hGwgVElWBS+MjG /t1o0CwOSVTA6/hCtgFEigRHggU6IH4n70MTnI6GEWLbsTSLk6/w8QxZNgGao2t9hXYC +dNU8x3bKPbHkUhqvUR8SnOOzWuOcj5yaYETOjluCyLA7raePXWBu8IZLiNjrZdNALeG YaVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OqgK8GE8u8GgE7hCKgynT+rKrVW8dlpriZEb87vuAJM=; b=GLcljnHwyk6Z4XaybVn0/2TidKuSanulJDgIwHc3lAQUWAgsE8CfCTGTK+yweifslg F4ykM2fjTBCzig6WI8SOzW6gpP33nRY2CyQrrKpjQ1RbzpH9uo6vSd+jPrRkDWJdVdvg MXTSiVWXAfu5lS+nTTfwZN6EOtCjaGs2WZAs21gKkKGmbLByjz5g2BEYGoqn0VjrhCEE P9CLHQ07XZHHe+4xyP2MRo6GK2Rxk/t7NDG4A+tOi0s6AA5ivKMPP0lSn0262X4zE4Bl PwEMjN1c9rjHn7g2twJDyYjHCxKw9Mqw45JSAyQ+/A0D4fIv3fQdHctdV+QI92Krvagl 370g== X-Gm-Message-State: AOAM5338QiHW0v7kZNmId1FQpWsRdo6BKmW/gwLcUQH3xpY1Kh4dBavE Pwsnr0mjNeuXnK4ryi3e/wZP0jIqO6E= X-Google-Smtp-Source: ABdhPJzWx4nuYV2O1JANxMaqzOIf1HDkolPDy4Dn4737wbGU4k//EBz2c6wC4ZZMy9b2y7bTuckSxg== X-Received: by 2002:a5d:6592:: with SMTP id q18mr3015599wru.293.1602843063248; Fri, 16 Oct 2020 03:11:03 -0700 (PDT) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id k18sm2787625wrx.96.2020.10.16.03.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 03:11:02 -0700 (PDT) Date: Fri, 16 Oct 2020 07:10:56 -0300 From: Melissa Wen To: Daniel Vetter Subject: Re: [PATCH 3/3] drm/vkms: fbdev emulation support Message-ID: <20201016101056.gqp4ezu7pyeqa6el@smtp.gmail.com> References: <20201009232156.3916879-1-daniel.vetter@ffwll.ch> <20201009232156.3916879-3-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201009232156.3916879-3-daniel.vetter@ffwll.ch> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Rodrigo Siqueira , DRI Development , Haneen Mohammed Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Thanks for this improvement. I could see that it increased the IGT test coverage, including now the fbdev test cases. On 10/10, Daniel Vetter wrote: > Hooray for generic fbdev support, making this a oneliner. We just > needed to fix preferred_depth fixed and the vmap support added first. I consider that including in the msg that, with this patch, both fbdev test cases [info and mmap] are passing would be interesting for future debugs. > > Signed-off-by: Daniel Vetter > Cc: Rodrigo Siqueira > Cc: Melissa Wen > Cc: Haneen Mohammed > Cc: Daniel Vetter > --- > drivers/gpu/drm/vkms/vkms_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index 6221e5040264..cc09e2df5cb1 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -169,6 +169,8 @@ static int __init vkms_init(void) > if (ret) > goto out_devres; > > + drm_fbdev_generic_setup(&vkms_device->drm, 0); > + > return 0; > > out_devres: > -- > 2.28.0 > Looks good to me, Reviewed-by: Melissa Wen _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel