From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C17C433E7 for ; Fri, 16 Oct 2020 11:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A44620EDD for ; Fri, 16 Oct 2020 11:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602847021; bh=9O2VsNOj0Pl896NsOWT55a1CGfW1jErCtAHYmNumc58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PhdARUNIT6iBO8qHuIZa4K7p11SInN+cdodlLraffKVEmtc2tJVzPBnqUykOLnp/N IhCqPc06g5Ggad7o50ri67NmA6/gE8wws0ksd+UBHNMB4FeR5KfnhXHDJg6CsQ/qGz ND6mUTyrZJYw/OXQ3VBrzYnu/S79/xeWZpcdzdFk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405481AbgJPLRA (ORCPT ); Fri, 16 Oct 2020 07:17:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:58210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405440AbgJPLQ7 (ORCPT ); Fri, 16 Oct 2020 07:16:59 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7964820878; Fri, 16 Oct 2020 11:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602847018; bh=9O2VsNOj0Pl896NsOWT55a1CGfW1jErCtAHYmNumc58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GefhZu0pi7Kyd3g7+HhdWWen52jVybrN5Q6NONX9so3K11g0/qPdDKMM4aK9fBY63 j63U84EAkNzRoY3tV1P5stiI0yv2XXcvBepKwmye6/9/TCCWQlbQPobwv9qV/ZdCNE 3Kpr6521HiIruqx8Hs4X0CdqO4pmMWh41wCkLTsA= Date: Fri, 16 Oct 2020 13:17:29 +0200 From: Greg Kroah-Hartman To: Alexander A Sverdlin Cc: devel@driverdev.osuosl.org, Aaro Koskinen , Ralf Baechle , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error Message-ID: <20201016111729.GB1785357@kroah.com> References: <20201016101858.11374-1-alexander.sverdlin@nokia.com> <20201016101858.11374-2-alexander.sverdlin@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201016101858.11374-2-alexander.sverdlin@nokia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 16, 2020 at 12:18:58PM +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > Currently in case of alignment or FCS error if the packet cannot be > corrected it's still not dropped. Report the error properly and drop the > packet while making the code around a little bit more readable. > > Signed-off-by: Alexander Sverdlin > Fixes: 80ff0fd3ab ("Staging: Add octeon-ethernet driver files.") > > Change-Id: Ie1fadcc57cb5e221cf3e83c169b53a5533b8edff You didn't run checkpatch :( From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B03C433DF for ; Fri, 16 Oct 2020 11:17:01 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 648DA212CC for ; Fri, 16 Oct 2020 11:17:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GefhZu0p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 648DA212CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CC24C886AA; Fri, 16 Oct 2020 11:17:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ADbRQKJjDOK; Fri, 16 Oct 2020 11:17:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 73CE888902; Fri, 16 Oct 2020 11:17:00 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 128181BF30E for ; Fri, 16 Oct 2020 11:16:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 09CE788902 for ; Fri, 16 Oct 2020 11:16:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yaHX2GiWszmp for ; Fri, 16 Oct 2020 11:16:58 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 7B0D7886AA for ; Fri, 16 Oct 2020 11:16:58 +0000 (UTC) Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7964820878; Fri, 16 Oct 2020 11:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602847018; bh=9O2VsNOj0Pl896NsOWT55a1CGfW1jErCtAHYmNumc58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GefhZu0pi7Kyd3g7+HhdWWen52jVybrN5Q6NONX9so3K11g0/qPdDKMM4aK9fBY63 j63U84EAkNzRoY3tV1P5stiI0yv2XXcvBepKwmye6/9/TCCWQlbQPobwv9qV/ZdCNE 3Kpr6521HiIruqx8Hs4X0CdqO4pmMWh41wCkLTsA= Date: Fri, 16 Oct 2020 13:17:29 +0200 From: Greg Kroah-Hartman To: Alexander A Sverdlin Subject: Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error Message-ID: <20201016111729.GB1785357@kroah.com> References: <20201016101858.11374-1-alexander.sverdlin@nokia.com> <20201016101858.11374-2-alexander.sverdlin@nokia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201016101858.11374-2-alexander.sverdlin@nokia.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, "David S. Miller" , Ralf Baechle , Aaro Koskinen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Oct 16, 2020 at 12:18:58PM +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > Currently in case of alignment or FCS error if the packet cannot be > corrected it's still not dropped. Report the error properly and drop the > packet while making the code around a little bit more readable. > > Signed-off-by: Alexander Sverdlin > Fixes: 80ff0fd3ab ("Staging: Add octeon-ethernet driver files.") > > Change-Id: Ie1fadcc57cb5e221cf3e83c169b53a5533b8edff You didn't run checkpatch :( _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel