All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Han Xu <xhnjupt@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	Fabio Estevam <festevam@gmail.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>
Subject: Re: [PATCH v13 09/20] mtd: rawnand: Separate the ECC engine type and the ECC byte placement
Date: Fri, 16 Oct 2020 20:00:40 +0200	[thread overview]
Message-ID: <20201016200040.7cac8c9a@xps13> (raw)
In-Reply-To: <CA+EcR20Lm2m-bkECKWC5RvB8wb1C_s7uH2PENzLK0iD14oAGUg@mail.gmail.com>

Hi Han,

Han Xu <xhnjupt@gmail.com> wrote on Fri, 16 Oct 2020 12:51:24 -0500:

> On Fri, Oct 16, 2020 at 12:14 PM Miquel Raynal
> <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Han,
> >
> > Han Xu <xhnjupt@gmail.com> wrote on Fri, 16 Oct 2020 12:09:22 -0500:
> >  
> > > On Thu, Oct 15, 2020 at 2:25 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:  
> > > >
> > > > Hi Han,
> > > >
> > > > Han Xu <xhnjupt@gmail.com> wrote on Wed, 14 Oct 2020 22:09:56 -0500:
> > > >  
> > > > > On Wed, Oct 14, 2020 at 8:35 PM Fabio Estevam <festevam@gmail.com> wrote:  
> > > > > >
> > > > > > Hi Han Xu,
> > > > > >
> > > > > > On Wed, Oct 14, 2020 at 6:38 PM Han Xu <xhnjupt@gmail.com> wrote:
> > > > > >  
> > > > > > > Hi Miquel, the changes to the nested switch statement make the logic
> > > > > > > of this break wrong.  
> > > > > >
> > > > > > Care to send a fix, please?
> > > > > >
> > > > > > We have seen ECC NAND regressions on mx27 and LS2088 platforms.
> > > > > >
> > > > > > In which platform did you noticed the ECC issue?
> > > > > >
> > > > > > Thanks  
> > > > >
> > > > > Hi Fabio,
> > > > >
> > > > > CI test reported all LS platforms have the ECC regression. The error
> > > > > is "Driver must set ecc.strength when using hardware ECC"
> > > > >
> > > > > I haven't worked on any LS platforms so I tested on i.MX platforms
> > > > > with gpmi NAND controller,
> > > > > the code ran into NAND_ECC_ENGINE_TYPE_SOFT due to this issue. So
> > > > > these are two different issues, I can send a patch to fix the nested
> > > > > switch statement problem but won't fix the LS platform issue.  
> > > >
> > > >
> > > > I think the fact that the execution ran into NAND_ECC_ENGINE_TYPE_SOFT
> > > > has been fixed. However there is still the other issue that I am unable
> > > > to find just by reading the code :/  
> > >
> > > Could you please send me the link of the fix patch, I can test it on
> > > i.MX platforms.  
> >
> > The fix is in next since more than a week, if you still have the issue
> > then it's probably the same issue that sascha reported in another
> > thread and in this case debugging from your side is welcome.  
> 
> If I am correct, the patch "mtd: rawnand: Fix wrongful fallthrough
> NAND_ECC_SOFT" is the fix. But I didn't see it in the next branch,
> only the other two patches in the patch set applied.

Indeed, I squashed that patch with the faulty commit to try keeping a
clean/understandable history.


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-10-16 18:01 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  8:51 [PATCH v13 00/20] Introduction of the generic ECC framework Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 01/20] mtd: rawnand: Add a kernel doc to the ECC algorithm enumeration Miquel Raynal
2020-09-07  7:25   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 02/20] mtd: rawnand: Rename the ECC algorithm enumeration items Miquel Raynal
2020-09-07  7:25   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 03/20] mtd: rawnand: Move the nand_ecc_algo enum to the generic NAND layer Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 04/20] mtd: nand: Add a NAND page I/O request type Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 05/20] dt-bindings: mtd: Document nand-ecc-placement Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 06/20] dt-bindings: mtd: Document nand-ecc-engine Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 07/20] dt-bindings: mtd: Document boolean NAND ECC properties Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 08/20] mtd: nand: Introduce the ECC engine framework Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 09/20] mtd: rawnand: Separate the ECC engine type and the ECC byte placement Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-10-14 21:36   ` Han Xu
2020-10-15  1:35     ` Fabio Estevam
2020-10-15  3:09       ` Han Xu
2020-10-15  7:25         ` Miquel Raynal
2020-10-16 17:09           ` Han Xu
2020-10-16 17:14             ` Miquel Raynal
2020-10-16 17:51               ` Han Xu
2020-10-16 18:00                 ` Miquel Raynal [this message]
2020-10-16 21:03                 ` Fabio Estevam
2020-10-19 15:51                   ` Han Xu
2020-10-19 16:52                     ` Fabio Estevam
2020-08-27  8:51 ` [PATCH v13 10/20] mtd: rawnand: Use the new ECC engine type enumeration Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:51 ` [PATCH v13 11/20] mtd: nand: Create a helper to extract the ECC configuration Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:52 ` [PATCH v13 12/20] mtd: spinand: Use nanddev_get_ecc_conf() when relevant Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:52 ` [PATCH v13 13/20] mtd: nand: Create helpers to set/extract the ECC requirements Miquel Raynal
2020-09-07  7:24   ` Miquel Raynal
2020-08-27  8:52 ` [PATCH v13 14/20] mtd: rawnand: Use nanddev_get/set_ecc_requirements() when relevant Miquel Raynal
2020-09-07  7:23   ` Miquel Raynal
2020-08-27  8:52 ` [PATCH v13 15/20] mtd: nand: Use the new generic ECC object Miquel Raynal
2020-09-07  7:23   ` Miquel Raynal
2020-08-27  8:52 ` [PATCH v13 16/20] mtd: rawnand: Make use of the ECC framework Miquel Raynal
2020-09-07  7:23   ` Miquel Raynal
2020-08-27  8:52 ` [PATCH v13 17/20] mtd: rawnand: Use the ECC framework OOB layouts Miquel Raynal
2020-09-07  7:23   ` Miquel Raynal
2020-09-20 12:21   ` Janusz Krzysztofik
2020-09-29  8:15     ` Miquel Raynal
2020-09-29 21:26       ` Janusz Krzysztofik
2020-08-27  8:52 ` [PATCH v13 18/20] mtd: rawnand: Use the ECC framework nand_ecc_is_strong_enough() helper Miquel Raynal
2020-09-07  7:23   ` Miquel Raynal
2020-08-27  8:52 ` [PATCH v13 19/20] mtd: rawnand: Use the ECC framework user input parsing bits Miquel Raynal
2020-09-07  7:23   ` Miquel Raynal
2020-09-21  9:36   ` Sascha Hauer
2020-09-28 15:18     ` Miquel Raynal
2020-08-27  8:52 ` [PATCH v13 20/20] mtd: rawnand: Use the NAND framework user_conf object for ECC flags Miquel Raynal
2020-09-07  7:23   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016200040.7cac8c9a@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=festevam@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=xhnjupt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.