From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA00C433DF for ; Sat, 17 Oct 2020 18:27:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE1A9206DD for ; Sat, 17 Oct 2020 18:27:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438161AbgJQS1m (ORCPT ); Sat, 17 Oct 2020 14:27:42 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60946 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437529AbgJQS1l (ORCPT ); Sat, 17 Oct 2020 14:27:41 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kTqva-002B95-Vf; Sat, 17 Oct 2020 20:27:38 +0200 Date: Sat, 17 Oct 2020 20:27:38 +0200 From: Andrew Lunn To: Ard Biesheuvel Cc: Ilias Apalodimas , "open list:BPF JIT for MIPS (32-BIT AND 64-BIT)" , Willy Liu , "David S. Miller" , Jakub Kicinski , Sasha Levin , Florian Fainelli , Heiner Kallweit , Masahisa Kojima Subject: Re: realtek PHY commit bbc4d71d63549 causes regression Message-ID: <20201017182738.GN456889@lunn.ch> References: <20201017144430.GI456889@lunn.ch> <20201017151132.GK456889@lunn.ch> <20201017161435.GA1768480@apalos.home> <20201017180453.GM456889@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Oct 17, 2020 at 08:11:24PM +0200, Ard Biesheuvel wrote: > On Sat, 17 Oct 2020 at 20:04, Andrew Lunn wrote: > > > > > I have tried this, and it seems to fix the issue. I will send out a > > > patch against the netsec driver. > > > > Please also fix the firmware so it does not pass rgmii. > > > > If there are pure DT systems, which do require phy-mode to be used, we > > will need to revert your proposed change in order to make the MAC > > driver work as it should, rather than work around the broken firmware. > > > > What do you mean by 'pure' DT system? Only EDK2 based firmware exists > for this platform Currently, only EDK2 based firmware exists. Is there anything stopping somebody using u-boot? ACPI is aimed for server class systems, on ARM. If anybody wants to use this SoC in am embedded setting, not server, then they are more likely to use DT, especially when you need a complex network, eg. an Ethernet switch. It seems like ACPI is too simple to support complex network hardware found in some embedded systems. > So what I propose to do is drop the handling of the [mandatory] > phy-mode device property from the netsec driver (which is really only > used by this board). As we don't really need a phy-mode to begin with, > and given that firmware exists in the field that passes the wrong > value, the only option I see for passing a value here is to use a > different, *optional* DT property (force-phy-mode or > phy-mode-override) that takes the place of phy-mode. No, sorry, this is an ACPI problem, not a DT problem. I don't want to accept DT hacks because of broken ACPI. We have been through this before, when the Atheros PHY fixed is RGMII delay support, and lots of platforms broke. Everybody just updated their DT and were happy. I see no reason why ACPI should be different. Andrew