All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] vfs: fix boolreturn.cocci warnings
Date: Sun, 18 Oct 2020 02:46:18 +0800	[thread overview]
Message-ID: <20201017184618.GA89156@4242b66620aa> (raw)
In-Reply-To: <202010180212.7bnkpexK-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

From: kernel test robot <lkp@intel.com>

mm/truncate.c:41:9-10: WARNING: return of 0/1 in function '__clear_shadow_entry' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 78a9d82e733f ("vfs: keep inodes with page cache off the inode shrinker LRU")
CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/zen-kernel/zen-kernel 5.9/zen-sauce
head:   a49dc684580cbc31949bfc4220f8ed5346382c49
commit: 78a9d82e733f1eae572c07bd62a40a405f9ae87a [19/24] vfs: keep inodes with page cache off the inode shrinker LRU

 truncate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/truncate.c
+++ b/mm/truncate.c
@@ -38,7 +38,7 @@ static bool __must_check __clear_shadow_
 
 	xas_set_update(&xas, workingset_update_node);
 	if (xas_load(&xas) != entry)
-		return 0;
+		return false;
 	xas_store(&xas, NULL);
 	mapping->nrexceptional--;
 

  reply	other threads:[~2020-10-17 18:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 18:46 [zen-kernel-zen-kernel:5.9/zen-sauce 19/24] mm/truncate.c:41:9-10: WARNING: return of 0/1 in function '__clear_shadow_entry' with return type bool kernel test robot
2020-10-17 18:46 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-08-04  5:00 [zen-kernel-zen-kernel:5.8/zen-sauce 20/26] " kernel test robot
2020-08-04  5:01 ` [PATCH] vfs: fix boolreturn.cocci warnings kernel test robot
2020-02-11 17:55 [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU Johannes Weiner
2020-02-14 21:30 ` [PATCH] vfs: fix boolreturn.cocci warnings kbuild test robot
2020-02-14 21:30   ` kbuild test robot
2016-11-14 23:58 [linux-next:master 5439/5763] fs/namespace.c:1185:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint' with return type bool kbuild test robot
2016-11-14 23:58 ` [PATCH] vfs: fix boolreturn.cocci warnings kbuild test robot
2016-11-14 23:58   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201017184618.GA89156@4242b66620aa \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.