From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AD0C433E7 for ; Sun, 18 Oct 2020 19:36:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED8D22274 for ; Sun, 18 Oct 2020 19:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049782; bh=Cf5hZJ1OuNNK3oLI0/j/J8SLXiDMr90JtPLHcPIBgCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uinbzF0kzPWZG/CJ0iJ1xmvnw8XcLfwwYMBsoGRT2neL1Q7GIjVEHjlJ6PonL1Qx4 6+PEwY4wOLKhlZrfnxuRY2tTRWFiN/rdQaIbsJxBc5ZTpgrUKsUDCA6/jWkURbl91i 8EWgrz3m4fULpaKNLHVAqu6n8EiMklpo1EAaVjXg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731374AbgJRTZn (ORCPT ); Sun, 18 Oct 2020 15:25:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:40356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731335AbgJRTZk (ORCPT ); Sun, 18 Oct 2020 15:25:40 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98163223AB; Sun, 18 Oct 2020 19:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049139; bh=Cf5hZJ1OuNNK3oLI0/j/J8SLXiDMr90JtPLHcPIBgCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z3FIRKQg0zuwXM28HXx7w1s7zFVT+mfR8Ef597IezRSdT0nBfJvpUqUzXcjYAASZ3 9io0D78N5wbcE/o+Yzje++6K1pDKFBoPBx+4aellHjdQmL+Q//5hsuWSb2c9Nw/iEW WRJmVW9P3gll1hDY733DMxi+rD3txZDSAXDRitpE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qiushi Wu , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 07/52] media: exynos4-is: Fix a reference count leak due to pm_runtime_get_sync Date: Sun, 18 Oct 2020 15:24:44 -0400 Message-Id: <20201018192530.4055730-7-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201018192530.4055730-1-sashal@kernel.org> References: <20201018192530.4055730-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu [ Upstream commit c47f7c779ef0458a58583f00c9ed71b7f5a4d0a2 ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Qiushi Wu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/exynos4-is/media-dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index f772c9b92d9ba..1cab30578e166 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -479,8 +479,10 @@ static int fimc_md_register_sensor_entities(struct fimc_md *fmd) return -ENXIO; ret = pm_runtime_get_sync(fmd->pmf); - if (ret < 0) + if (ret < 0) { + pm_runtime_put(fmd->pmf); return ret; + } fmd->num_sensors = 0; -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4894C433E7 for ; Sun, 18 Oct 2020 19:29:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A77820791 for ; Sun, 18 Oct 2020 19:29:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uUjXO4SN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="L9Il04uq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z3FIRKQg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A77820791 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iyI6oRqfnDXpuQGKkoanJlWiDRQh640Nq3bnG+biyyA=; b=uUjXO4SN76bNFolb5aiDn3oPo ZGpNlaPZqnelKnWyNDb8MszFBqJeNAZ1S8V9oicLo916rGsszVKCYObNN7L/Ky/f7gCxF5QxkqqAG m9BZ0KeK5ijOz+z5m/SOS6tcmqc1AQ3vLnGrYrXr6Yt6X6BRaZrVqSNTWWiI412MEFnscEUZipXH6 rfO7p5O+fjkj7BGsDY6hzryvxnvkbQaMawAVXNojqMDQBh4XqBik+xHn2Tqs1ewm8PgldxxdXBKFD S85HlSAe3MOypZ0HdRI6qbGu9gH0wP6YIBmzSmGgj110okl87v/YhI0fJlOt9vu+cSb1WzcgECA6p JT/+wp71w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUEKg-0001y7-Do; Sun, 18 Oct 2020 19:27:06 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUEJj-0001Yh-G5 for linux-arm-kernel@merlin.infradead.org; Sun, 18 Oct 2020 19:26:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=4kR1efwi5i2X7Q2Mr2erimkUsg+2MIEakRlZkzAWVZQ=; b=L9Il04uqq147dTdGRVutddaY2C C4XWucoikZ94jsIK9YP6NUdVcE+5Fcrdxfk/jAqMqHbxrYpDcpF6G7xukcwbs03vWozQ6pczJnXZ+ NimSBI7eca7dvAHfhyN4lezpC80fuA56K/ZZN5TCzB/3ENnlN7SNX5LXgylLRyUtaCX5OofAJIH2O +qEYL4XiqUrhvBuX98pKb9l8eVdmONwnX/JM7uVxzD/z2CoN00RQGbqGnVT3NKvfc9rO5PBsiIwQn MFjEa8WEDGNgSqX/tVnlrMJX0rEVyxdqfYvdmI41oMK5FlKyyVmq8aT1WoHBVILKiJCCA0VK5nY1a 3pjYScNQ==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUEJJ-0001D4-Ez for linux-arm-kernel@lists.infradead.org; Sun, 18 Oct 2020 19:26:05 +0000 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98163223AB; Sun, 18 Oct 2020 19:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049139; bh=Cf5hZJ1OuNNK3oLI0/j/J8SLXiDMr90JtPLHcPIBgCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z3FIRKQg0zuwXM28HXx7w1s7zFVT+mfR8Ef597IezRSdT0nBfJvpUqUzXcjYAASZ3 9io0D78N5wbcE/o+Yzje++6K1pDKFBoPBx+4aellHjdQmL+Q//5hsuWSb2c9Nw/iEW WRJmVW9P3gll1hDY733DMxi+rD3txZDSAXDRitpE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 07/52] media: exynos4-is: Fix a reference count leak due to pm_runtime_get_sync Date: Sun, 18 Oct 2020 15:24:44 -0400 Message-Id: <20201018192530.4055730-7-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201018192530.4055730-1-sashal@kernel.org> References: <20201018192530.4055730-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201018_202543_336582_F639E8C8 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-samsung-soc@vger.kernel.org, Mauro Carvalho Chehab , Qiushi Wu , Hans Verkuil , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Qiushi Wu [ Upstream commit c47f7c779ef0458a58583f00c9ed71b7f5a4d0a2 ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Qiushi Wu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/exynos4-is/media-dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index f772c9b92d9ba..1cab30578e166 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -479,8 +479,10 @@ static int fimc_md_register_sensor_entities(struct fimc_md *fmd) return -ENXIO; ret = pm_runtime_get_sync(fmd->pmf); - if (ret < 0) + if (ret < 0) { + pm_runtime_put(fmd->pmf); return ret; + } fmd->num_sensors = 0; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel