From: Michal Hocko <mhocko@suse.com>
To: pintu@codeaurora.org
Cc: willy@infradead.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
pintu.ping@gmail.com
Subject: Re: [PATCH] mm/util.c: Add error logs for commitment overflow
Date: Mon, 19 Oct 2020 15:06:37 +0200 [thread overview]
Message-ID: <20201019130637.GJ27114@dhcp22.suse.cz> (raw)
In-Reply-To: <0e9255fcac61ae6ce90bbdde6421b148@codeaurora.org>
On Mon 19-10-20 08:32:34, pintu@codeaurora.org wrote:
[...]
> b) This can be invoked from many places so we are adding the logging at
> wrong layer?
> If so, any other better places which can be explored?
dup_mmap?
> c) Adding logging at kernel layer is not the right approach to tackle this
> problem ?
>
> d) Another thing we can do is, update the man page with more detailed
> information about this commitment overflow ?
This is a good thing in general
> e) May be returning ENOMEM (Cannot allocate memory) from VM path is slightly
> misleading for user space folks even though there are enough memory?
> => Either we can introduce ENOVMEM (Cannot create virtual memory mapping)
> => Or, update the documentation with approach to further debug this issue?
No, it is close to impossible to add a new error code for interface that
is used so heavily.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2020-10-19 13:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 11:57 [PATCH] mm/util.c: Add error logs for commitment overflow Pintu Kumar
2020-10-02 12:11 ` Matthew Wilcox
2020-10-02 16:18 ` pintu
2020-10-02 12:17 ` Michal Hocko
2020-10-02 16:23 ` pintu
2020-10-05 7:20 ` Michal Hocko
2020-10-19 3:02 ` pintu
2020-10-19 13:06 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019130637.GJ27114@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pintu.ping@gmail.com \
--cc=pintu@codeaurora.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.