All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	Realtek linux nic maintainers <nic_swsd@realtek.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] r8169: fix operation under forced interrupt threading
Date: Mon, 19 Oct 2020 16:58:45 -0700	[thread overview]
Message-ID: <20201019165845.61fe6b6e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <4d3ef84a-c812-5072-918a-22a6f6468310@gmail.com>

On Sun, 18 Oct 2020 18:38:59 +0200 Heiner Kallweit wrote:
> For several network drivers it was reported that using
> __napi_schedule_irqoff() is unsafe with forced threading. One way to
> fix this is switching back to __napi_schedule, but then we lose the
> benefit of the irqoff version in general. As stated by Eric it doesn't
> make sense to make the minimal hard irq handlers in drivers using NAPI
> a thread. Therefore ensure that the hard irq handler is never
> thread-ified.
> 
> Fixes: 9a899a35b0d6 ("r8169: switch to napi_schedule_irqoff")
> Link: https://lkml.org/lkml/2020/10/18/19
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied, thank you!

  reply	other threads:[~2020-10-19 23:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-18 16:38 [PATCH net] r8169: fix operation under forced interrupt threading Heiner Kallweit
2020-10-19 23:58 ` Jakub Kicinski [this message]
2020-10-28 11:43 ` Serge Belyshev
2020-10-28 12:17   ` Heiner Kallweit
2020-10-28 13:24     ` Thomas Gleixner
2020-10-28 23:29     ` Jakub Kicinski
2020-10-29  8:42       ` Heiner Kallweit
2020-10-29  9:42         ` Thomas Gleixner
2020-10-29 10:19           ` Heiner Kallweit
2020-10-29 12:25             ` Thomas Gleixner
2020-10-28 14:04   ` Heiner Kallweit
2020-10-28 14:34     ` Serge Belyshev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019165845.61fe6b6e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.