From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422F6C433DF for ; Mon, 19 Oct 2020 22:11:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6BD622400 for ; Mon, 19 Oct 2020 22:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603145469; bh=4xdTj5Y4VJ/3BEN7HRpzd+X3zOWHsYAtusdSthtK/fI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QJUs7vSm/70+1oguRI03+uH4GORBC3vcFJgORDNM4Su20uFFhowcznORJhLlaYbsC 0NfPNtzA36royM2ghSio582fEx8XeUOGysxzdb8n9b03q53fT24FzEWBFAKuNJsy5W Ni3QRfbNusOkjvfogvTvqggu5FJTOi6KFYMzllB0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387839AbgJSWLJ (ORCPT ); Mon, 19 Oct 2020 18:11:09 -0400 Received: from mail-oo1-f68.google.com ([209.85.161.68]:46781 "EHLO mail-oo1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387779AbgJSWLJ (ORCPT ); Mon, 19 Oct 2020 18:11:09 -0400 Received: by mail-oo1-f68.google.com with SMTP id c25so339054ooe.13; Mon, 19 Oct 2020 15:11:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YAcxqz4gzIZRTswKLMgM+/6nLU+BPO60IaB6aMIKPFs=; b=XbQIvIXdHc7Yv9SpPbbDUZatNrjXBbWr367bUvf0MyA4Ep57lki2LCQ8+8YxlatmyT VaULmseVRE8/KmBmjYHvdv4dqIDfkimBmgCdPwkClxTFEP1bedsK+jHaItlADoOVaJJj rRz0TxqtTa1Z/Y8oN8OeI5zLWR+IyOAwdolC717/fLCFynTwnmoZ0OVe8cEu8F4BrTaI a4DNcE03+N1A6jvHclYCk+Z5lsduOpxt+zwi6zBHm2GYj55DzqS6UIzZa1+3W9GnesdD MdpjSfATdbamq1cSCxiknTaNEv7dCAO8cOYRDuLrUEKU1xuGn+dMwUh2wXTYegP2XAUo FwMA== X-Gm-Message-State: AOAM532jXLMo8P80fMLOcEDaGFh9syXEwJvgQahAuiKQBaOSPeXc/jYC BhsM353DKBIuKScb3ZU7lg== X-Google-Smtp-Source: ABdhPJwRFkQroby+u4ICY2NJLUAU/9hZmS0o+Tf0mlbmQ+dO75MkbVoF+8Wwz8jdOtiUcjy2KT6FqA== X-Received: by 2002:a4a:c68d:: with SMTP id m13mr1485011ooq.64.1603145467832; Mon, 19 Oct 2020 15:11:07 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 38sm269664ota.42.2020.10.19.15.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 15:11:06 -0700 (PDT) Received: (nullmailer pid 3688686 invoked by uid 1000); Mon, 19 Oct 2020 22:11:05 -0000 Date: Mon, 19 Oct 2020 17:11:05 -0500 From: Rob Herring To: Sameer Pujar Cc: broonie@kernel.org, lgirdwood@gmail.com, kuninori.morimoto.gx@renesas.com, pierre-louis.bossart@linux.intel.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, thierry.reding@gmail.com, jonathanh@nvidia.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com, rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com, nwartikar@nvidia.com, swarren@nvidia.com, nicoleotsuka@gmail.com Subject: Re: [PATCH v4 10/15] ASoC: dt-bindings: tegra: Add graph bindings Message-ID: <20201019221105.GA3679866@bogus> References: <1602859382-19505-1-git-send-email-spujar@nvidia.com> <1602859382-19505-11-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1602859382-19505-11-git-send-email-spujar@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Fri, Oct 16, 2020 at 08:12:57PM +0530, Sameer Pujar wrote: > Add device tree binding properties of generic graph to ASoC component > devices. This allows to define audio ports out of these components or > DAIs and audio graph based sound card can be realised with this. > > Signed-off-by: Sameer Pujar > --- > Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +++++++ > .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 7 +++++++ > 5 files changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > index ed2fb32..23875b1 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > @@ -55,6 +55,13 @@ properties: > The name can be "DSPK1" or "DSPKx", where x depends on the maximum > available instances on a Tegra SoC. > > + ports: > + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports > + > +patternProperties: > + "^port(@[0-9a-f]+)?$": > + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port You should have either 'ports' or a single 'port' (yes, the graph binding allowed multiple port nodes without 'ports', but that should be deprecated IMO) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 532D3C433DF for ; Mon, 19 Oct 2020 22:12:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 385A0207C3 for ; Mon, 19 Oct 2020 22:12:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="d/ZewM61" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 385A0207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 60E1F16F4; Tue, 20 Oct 2020 00:11:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 60E1F16F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603145527; bh=4xdTj5Y4VJ/3BEN7HRpzd+X3zOWHsYAtusdSthtK/fI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=d/ZewM61cUcWDPA8zmLv5Y83Gq7kO3WVO6XwwQMcXCf7SEr6Tk72YAXin6IjM/ZkY MsY3TtA/GB4TryA2jZKMiMaNj4dtfj/E+oP6A1i2FmstBcX7QtNxJG0Ox0zXlRu79R WDk+SwMGzkrVWe6Co2N6T0vfyFLtRCU3WrnM9qZg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E88FFF801D5; Tue, 20 Oct 2020 00:11:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C33E3F80247; Tue, 20 Oct 2020 00:11:15 +0200 (CEST) Received: from mail-oo1-f67.google.com (mail-oo1-f67.google.com [209.85.161.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C192FF80121 for ; Tue, 20 Oct 2020 00:11:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C192FF80121 Received: by mail-oo1-f67.google.com with SMTP id w25so342816oos.10 for ; Mon, 19 Oct 2020 15:11:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YAcxqz4gzIZRTswKLMgM+/6nLU+BPO60IaB6aMIKPFs=; b=jlvKnLrG/EMVBzubuZ69E9EaAafBja4Y0byN2hSghhUyQsbpV1d4ACyfAWWIhb9xqq HXZDPZzQsptoV2qaMjPEXnNNmdJElT/Y7XrdDp2Y1Y08uQVZ6YVvUNTEcDRWhj/F9Rrm x+7eIkzFm/EFTHtB9fOOtru/y8X3db5O2/osTACQClWxID1FWa5Saf6OmUVy6SSZ9uFi V2BIb2ppmuURWezKcip2jp4CFVKkz2sbwPDa/e5FtM0KlSf0kYiNu0/RROnW0W4vGVG2 bCVaODZcDvVpFK8T2iGDH2WgxSiBvXeYevNaOchwhg142g//BNG6Ezl39MLP9srJzm5s ZxWg== X-Gm-Message-State: AOAM532Sl9vS16EsRoMMaPpVfuYXjTX8K1jd5NKvDCNX9TJgCzrEDf7y t3INsRgw0Vf8EeU1HSVRXw== X-Google-Smtp-Source: ABdhPJwRFkQroby+u4ICY2NJLUAU/9hZmS0o+Tf0mlbmQ+dO75MkbVoF+8Wwz8jdOtiUcjy2KT6FqA== X-Received: by 2002:a4a:c68d:: with SMTP id m13mr1485011ooq.64.1603145467832; Mon, 19 Oct 2020 15:11:07 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 38sm269664ota.42.2020.10.19.15.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 15:11:06 -0700 (PDT) Received: (nullmailer pid 3688686 invoked by uid 1000); Mon, 19 Oct 2020 22:11:05 -0000 Date: Mon, 19 Oct 2020 17:11:05 -0500 From: Rob Herring To: Sameer Pujar Subject: Re: [PATCH v4 10/15] ASoC: dt-bindings: tegra: Add graph bindings Message-ID: <20201019221105.GA3679866@bogus> References: <1602859382-19505-1-git-send-email-spujar@nvidia.com> <1602859382-19505-11-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1602859382-19505-11-git-send-email-spujar@nvidia.com> Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, rlokhande@nvidia.com, swarren@nvidia.com, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, jonathanh@nvidia.com, devicetree@vger.kernel.org, nicoleotsuka@gmail.com, broonie@kernel.org, linux-tegra@vger.kernel.org, mkumard@nvidia.com, viswanathl@nvidia.com, lgirdwood@gmail.com, nwartikar@nvidia.com, p.zabel@pengutronix.de, sharadg@nvidia.com, dramesh@nvidia.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Oct 16, 2020 at 08:12:57PM +0530, Sameer Pujar wrote: > Add device tree binding properties of generic graph to ASoC component > devices. This allows to define audio ports out of these components or > DAIs and audio graph based sound card can be realised with this. > > Signed-off-by: Sameer Pujar > --- > Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +++++++ > .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 7 +++++++ > 5 files changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > index ed2fb32..23875b1 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > @@ -55,6 +55,13 @@ properties: > The name can be "DSPK1" or "DSPKx", where x depends on the maximum > available instances on a Tegra SoC. > > + ports: > + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports > + > +patternProperties: > + "^port(@[0-9a-f]+)?$": > + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port You should have either 'ports' or a single 'port' (yes, the graph binding allowed multiple port nodes without 'ports', but that should be deprecated IMO)