From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc: rafael.j.wysocki@intel.com, swboyd@chromium.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 1/1] kobject: Don't emit change events if not in sysfs
Date: Tue, 20 Oct 2020 07:57:38 +0200 [thread overview]
Message-ID: <20201020055738.GD3437534@kroah.com> (raw)
In-Reply-To: <20201019153232.1.I797f9874972a07fc381fe586b6748ce71c7b1fda@changeid>
On Mon, Oct 19, 2020 at 03:32:57PM -0700, Abhishek Pandit-Subedi wrote:
> Add a check to make sure the kobj is created and in sysfs before sending
> a change event notification. Otherwise, udev rules that depend on the
> change notification may find that the path that changed doesn't actually
> exist.
Why is the user of the kobject trying to emit a uevent before it is
registered? Shouldn't we fix the root problem here instead? Otherwise
the event is still "gone", the caller will not know what to do about it.
Please fix the root problem here.
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-20 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:32 [PATCH 0/1] kobject: Don't emit change events if not in sysfs Abhishek Pandit-Subedi
2020-10-19 22:32 ` [PATCH 1/1] " Abhishek Pandit-Subedi
2020-10-20 5:57 ` Greg Kroah-Hartman [this message]
2020-10-21 3:27 ` Abhishek Pandit-Subedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020055738.GD3437534@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abhishekpandit@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.