From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD13FC433DF for ; Tue, 20 Oct 2020 07:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57BE5222E8 for ; Tue, 20 Oct 2020 07:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729020AbgJTHip (ORCPT ); Tue, 20 Oct 2020 03:38:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:59830 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727313AbgJTHio (ORCPT ); Tue, 20 Oct 2020 03:38:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5E78CAD1E; Tue, 20 Oct 2020 07:38:43 +0000 (UTC) Date: Tue, 20 Oct 2020 09:38:41 +0200 From: Daniel Wagner To: James Smart Cc: linux-scsi@vger.kernel.org, Ram Vegesna Subject: Re: [PATCH v4 05/31] elx: libefc_sli: Populate and post different WQEs Message-ID: <20201020073841.a2hr5qwssr262hib@beryllium.lan> References: <20201012225147.54404-1-james.smart@broadcom.com> <20201012225147.54404-6-james.smart@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201012225147.54404-6-james.smart@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Mon, Oct 12, 2020 at 03:51:21PM -0700, James Smart wrote: > This patch continues the libefc_sli SLI-4 library population. > > This patch adds service routines to create different WQEs and adds > APIs to issue iread, iwrite, treceive, tsend and other work queue > entries. > > Co-developed-by: Ram Vegesna > Signed-off-by: Ram Vegesna > Signed-off-by: James Smart Looks goods to me. Reviewed-by: Daniel Wagner > + case SLI4_CQE_CODE_RELEASE_WQE: { > + struct sli4_fc_wqec *wqec = (void *)cqe; > + > + *etype = SLI4_QENTRY_WQ_RELEASE; > + *r_id = le16_to_cpu(wqec->wq_id); > + rc = EFC_SUCCESS; > + break; > + } Nitpick, the rest of the cases do case XXX : { [...] }