From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EF61C4363D for ; Tue, 20 Oct 2020 21:43:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FC512224A for ; Tue, 20 Oct 2020 21:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603230233; bh=FmYy3cdKdcZnVWppAPofL56Fg9vXaupW07qBZifg0Co=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=irv99Q6N3rwQuntWWUm4cWcxyo+DHaGbJSdxC4IPyvA8T3CuqyPq2teIWdxxwnvDE f+gskSeaC4TIbCGNB3L2fF3Hbls0Okv1t2fGZCNkRKW8YmklSN6ifdw67h8y4KDQTZ 2IPJgPaHdR2z6BO4q2S1c+6cfjCCEerbO2w6ZS78= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438731AbgJTVnw (ORCPT ); Tue, 20 Oct 2020 17:43:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:47058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392089AbgJTVnv (ORCPT ); Tue, 20 Oct 2020 17:43:51 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 44C9D22244; Tue, 20 Oct 2020 21:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603230231; bh=FmYy3cdKdcZnVWppAPofL56Fg9vXaupW07qBZifg0Co=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c3m7+rCOhvzKIHDrI/jXQLmw2DAbJsxv7oeiBXopx1AxfqhsmczAhk6Z55NiTV0n1 NEaiaaiFwRbkmVz/xDT9w0ugD/1ZqlkTGMqGR+ZuZHv2lngntEN1y7PkiEdGLWzYmx 59SpgGd5YTn1H6KO5C1lcnrMxBjv9ENwaayw5anw= Date: Tue, 20 Oct 2020 14:43:48 -0700 From: Jakub Kicinski To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Tonghao Zhang , Willem de Bruijn , kernel test robot , Jason Wang , "David S. Miller" , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net v2] Revert "virtio-net: ethtool configurable RXCSUM" Message-ID: <20201020144348.29af571a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201020073651-mutt-send-email-mst@kernel.org> References: <20201018103122.454967-1-mst@redhat.com> <20201019121500.4620e276@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201020073651-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Oct 2020 07:45:09 -0400 Michael S. Tsirkin wrote: > On Mon, Oct 19, 2020 at 12:15:00PM -0700, Jakub Kicinski wrote: > > On Mon, 19 Oct 2020 13:32:12 -0400 Michael S. Tsirkin wrote: > > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > > > > > When the device does not have a control vq (e.g. when using a > > > version of QEMU based on upstream v0.10 or older, or when specifying > > > ctrl_vq=off,ctrl_rx=off,ctrl_vlan=off,ctrl_rx_extra=off,ctrl_mac_addr=off > > > for the device on the QEMU command line), that commit causes a crash: > > > > Hi Michael! > > > > Only our very first (non-resend) version got into patchwork: > > > > https://patchwork.ozlabs.org/project/netdev/list/?submitter=2235&state=* > > > > Any ideas why? > > I really don't! Any ideas? No idea. I have a local instance of patchwork to test things, and it didn't pick your patch up either. Weird. Looks like there will be v3, let's not worry about it for this single patch, worst case I'll pick it up from inbox or lore.