From: Adrian Perez de Castro <aperez@igalia.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/webkitgtk: fix build with ENABLE_C_LOOP=ON
Date: Tue, 20 Oct 2020 18:53:10 +0300 [thread overview]
Message-ID: <20201020155311.3493430-2-aperez@igalia.com> (raw)
In-Reply-To: <20201020155311.3493430-1-aperez@igalia.com>
The ENABLE_C_LOOP option conflicts with ENABLE_SAMPLING_PROFILER, so
the WebKit CMake build system will emit an error when both are enabled
at the same time. To avoid hitting that situation, explicitly disable
ENABLE_SAMPLING_PROFILER as needed.
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/webkitgtk/webkitgtk.mk | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index 5293d2d0ff..7fab924cc8 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -108,9 +108,12 @@ endif
# have a check for these processors. Disable JIT forcibly here and use
# the CLoop interpreter instead.
#
+# Also, we have to disable the sampling profiler, which does NOT work
+# with ENABLE_C_LOOP.
+#
# Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=191258
ifeq ($(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
-WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON
+WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON -DENABLE_SAMPLING_PROFILER=OFF
endif
$(eval $(cmake-package))
--
2.28.0
next prev parent reply other threads:[~2020-10-20 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 15:53 [Buildroot] [PATCH 0/2] package/webkitgtk: build fixes for CPUs which need CLoop Adrian Perez de Castro
2020-10-20 15:53 ` Adrian Perez de Castro [this message]
2020-10-29 19:01 ` [Buildroot] [PATCH 1/2] package/webkitgtk: fix build with ENABLE_C_LOOP=ON Peter Korsgaard
2020-10-20 15:53 ` [Buildroot] [PATCH 2/2] package/webkitgtk: disable JIT for ARMv5 and ARMv6 Adrian Perez de Castro
2020-10-29 19:01 ` Peter Korsgaard
2020-10-25 8:57 ` [Buildroot] [PATCH 0/2] package/webkitgtk: build fixes for CPUs which need CLoop Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020155311.3493430-2-aperez@igalia.com \
--to=aperez@igalia.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.