From: Xi Wang <xii@google.com>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Josh Don <joshdon@google.com>,
linux-kernel@vger.kernel.org, Xi Wang <xii@google.com>
Subject: [PATCH v2 0/1] Touch kernel watchdog with sched count
Date: Tue, 20 Oct 2020 13:57:03 -0700 [thread overview]
Message-ID: <20201020205704.1741543-1-xii@google.com> (raw)
The main purpose of kernel watchdog is to test whether scheduler can
still schedule tasks on a cpu. In order to reduce latency / jitter
from periodically invoking watchdog reset in thread context, we can
simply test if pick_next_task can run. This is done by forcing resched
and checking rq->sched_count. Compared to actually resetting watchdog
from cpu stop / migration threads, we lose coverage on: a migration
thread actually get picked and we actually context switch to the
migration thread. These steps are unlikely to silently fail. The
change would provide nearly the same level of protection with less
overhead.
With this patch we can still switch back to the old method with the
boot option watchdog_touch_with_thread. However code for the old
method can be completely removed in the future.
v2:
- Use sched_count instead of having sched calling into watchdog code
- Remove the sysctl and add a boot option, which can be removed later
- Changed the subject line
Xi Wang (1):
sched: watchdog: Touch kernel watchdog with sched count
include/linux/sched.h | 4 ++++
kernel/sched/core.c | 23 ++++++++++++++++++++--
kernel/sched/sched.h | 6 +++++-
kernel/watchdog.c | 44 +++++++++++++++++++++++++++++++++++++------
4 files changed, 68 insertions(+), 9 deletions(-)
--
2.29.0.rc1.297.gfa9743e501-goog
next reply other threads:[~2020-10-20 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 20:57 Xi Wang [this message]
2020-10-20 20:57 ` [PATCH v2 1/1] sched: watchdog: Touch kernel watchdog with sched count Xi Wang
2020-10-21 9:59 ` Peter Zijlstra
2020-10-21 10:12 ` Peter Zijlstra
2020-10-21 10:24 ` Peter Zijlstra
2020-10-21 11:11 ` Peter Zijlstra
2020-10-21 23:48 ` Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020205704.1741543-1-xii@google.com \
--to=xii@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.