From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1167C5517A for ; Wed, 21 Oct 2020 04:53:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D97D22200 for ; Wed, 21 Oct 2020 04:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603255980; bh=UraehopB91mJB0sVQ3c9WR4rOSBImtDbOcY3TERhXzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qS+M6YLVlHS/fFCdJlMt0kct2yHAuUaiHQCNhhZrSdAXpTPXJrgN2zhAiAlJBSmfW PLoGMnLjY3VooUJNBBGPWD7+oPDTfoYXnlpkGMPB1gWuFYEe8ztjf6IktOtks6MvPe rNRScvAmAHowo/nqjzVQ2qr72o+CLAThewXQgLos= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440275AbgJUEw6 (ORCPT ); Wed, 21 Oct 2020 00:52:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:58260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440209AbgJUEw6 (ORCPT ); Wed, 21 Oct 2020 00:52:58 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A664C207FF; Wed, 21 Oct 2020 04:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603255977; bh=UraehopB91mJB0sVQ3c9WR4rOSBImtDbOcY3TERhXzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jzl/5GKkO/PhDhfyZu328++s/nVgy36QFKK22ppo1rhvoc1zgHe/EnBUycMrPUDAS i3Zg8DC1oamM9qGPQlZWVqiQwOD8+fbK7fdU6vHAcqnzJ+/U2lctcou2YzNghVDlBA qGWKjMHG494eqO6sf5GjzZWFgxt7GYtY3UFUV34I= Date: Tue, 20 Oct 2020 21:52:57 -0700 From: jaegeuk@kernel.org To: Can Guo Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Alim Akhtar , Avri Altman Subject: Re: [PATCH v2 3/5] scsi: ufs: use WQ_HIGHPRI for gating work Message-ID: <20201021045257.GC3004521@google.com> References: <20201020195258.2005605-1-jaegeuk@kernel.org> <20201020195258.2005605-4-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/21, Can Guo wrote: > On 2020-10-21 03:52, Jaegeuk Kim wrote: > > From: Jaegeuk Kim > > > > Must have WQ_MEM_RECLAIM > > ``WQ_MEM_RECLAIM`` > > All wq which might be used in the memory reclaim paths **MUST** > > have this flag set. The wq is guaranteed to have at least one > > execution context regardless of memory pressure. > > > > You misunderstood my point. I meant you need to give more info about why > we are adding WQ_HIGHPRI flag but not why WQ_MEM_RECLAIM must be there. Oh, I thought that WQ_HIGHPRI is telling everything tho. > > Thanks, > > Can Guo. > > > Cc: Alim Akhtar > > Cc: Avri Altman > > Cc: Can Guo > > Signed-off-by: Jaegeuk Kim > > --- > > drivers/scsi/ufs/ufshcd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index feb10ebf7a35..0858c0b55eac 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -1867,7 +1867,7 @@ static void ufshcd_init_clk_gating(struct ufs_hba > > *hba) > > snprintf(wq_name, ARRAY_SIZE(wq_name), "ufs_clk_gating_%d", > > hba->host->host_no); > > hba->clk_gating.clk_gating_workq = alloc_ordered_workqueue(wq_name, > > - WQ_MEM_RECLAIM); > > + WQ_MEM_RECLAIM | WQ_HIGHPRI); > > > > hba->clk_gating.is_enabled = true; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B6CC55ABD for ; Wed, 21 Oct 2020 04:53:14 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BE7C207FF; Wed, 21 Oct 2020 04:53:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="gJ6IMG35"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="G4O0RAWa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jzl/5GKk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BE7C207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kV67c-0008EC-NT; Wed, 21 Oct 2020 04:53:12 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kV67b-0008E1-9I for linux-f2fs-devel@lists.sourceforge.net; Wed, 21 Oct 2020 04:53:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QzVy02rz/R8AWIaTwnjHayt1MdHuFzNS5Poi8ZMTdmc=; b=gJ6IMG35NPGqk9d8JnjthJ95Y/ GWjHG9uNNQYTqlQibmkYPTH1FdixdqHlrh5gM816nY6ibTuZG9GIXJWA/y0wQHbbobEOD16d6cnhJ L4A8bTkH6q7fToSvGeZ4lDVCx97tghGpL76kgm37siYRdjTgOrYelF+JC1YMjDYpjq2c=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QzVy02rz/R8AWIaTwnjHayt1MdHuFzNS5Poi8ZMTdmc=; b=G4O0RAWaXJcGRHubwnJyU2xs6K 5Otlmt5qUsICNIHOYGk3SxOKIigVGu8K337UYi/kGdjPyNvIbvgeNu7933qhrMHwBqhU1OjY7XSoR lAYqVQWlvLqtendlfuRlP4IE+wIP6UE12LulHPiDmfEI5juzilSLw79fDXXRxAj4AMsQ=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kV67T-006ZNh-BP for linux-f2fs-devel@lists.sourceforge.net; Wed, 21 Oct 2020 04:53:11 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A664C207FF; Wed, 21 Oct 2020 04:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603255977; bh=UraehopB91mJB0sVQ3c9WR4rOSBImtDbOcY3TERhXzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jzl/5GKkO/PhDhfyZu328++s/nVgy36QFKK22ppo1rhvoc1zgHe/EnBUycMrPUDAS i3Zg8DC1oamM9qGPQlZWVqiQwOD8+fbK7fdU6vHAcqnzJ+/U2lctcou2YzNghVDlBA qGWKjMHG494eqO6sf5GjzZWFgxt7GYtY3UFUV34I= Date: Tue, 20 Oct 2020 21:52:57 -0700 From: jaegeuk@kernel.org To: Can Guo Message-ID: <20201021045257.GC3004521@google.com> References: <20201020195258.2005605-1-jaegeuk@kernel.org> <20201020195258.2005605-4-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1kV67T-006ZNh-BP Subject: Re: [f2fs-dev] [PATCH v2 3/5] scsi: ufs: use WQ_HIGHPRI for gating work X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Avri Altman , Alim Akhtar , kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 10/21, Can Guo wrote: > On 2020-10-21 03:52, Jaegeuk Kim wrote: > > From: Jaegeuk Kim > > > > Must have WQ_MEM_RECLAIM > > ``WQ_MEM_RECLAIM`` > > All wq which might be used in the memory reclaim paths **MUST** > > have this flag set. The wq is guaranteed to have at least one > > execution context regardless of memory pressure. > > > > You misunderstood my point. I meant you need to give more info about why > we are adding WQ_HIGHPRI flag but not why WQ_MEM_RECLAIM must be there. Oh, I thought that WQ_HIGHPRI is telling everything tho. > > Thanks, > > Can Guo. > > > Cc: Alim Akhtar > > Cc: Avri Altman > > Cc: Can Guo > > Signed-off-by: Jaegeuk Kim > > --- > > drivers/scsi/ufs/ufshcd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index feb10ebf7a35..0858c0b55eac 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -1867,7 +1867,7 @@ static void ufshcd_init_clk_gating(struct ufs_hba > > *hba) > > snprintf(wq_name, ARRAY_SIZE(wq_name), "ufs_clk_gating_%d", > > hba->host->host_no); > > hba->clk_gating.clk_gating_workq = alloc_ordered_workqueue(wq_name, > > - WQ_MEM_RECLAIM); > > + WQ_MEM_RECLAIM | WQ_HIGHPRI); > > > > hba->clk_gating.is_enabled = true; _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel