From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============2788950548475253531=="
MIME-Version: 1.0
From: Jakub Kicinski <kuba at kernel.org>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net] mptcp: depends on IPV6 but not as a module
Date: Wed, 21 Oct 2020 08:08:36 -0700
Message-ID: <20201021080836.5ad77e45@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: 20201021105154.628257-1-matthieu.baerts@tessares.net
X-Status: 
X-Keywords:                  
X-UID: 6392

--===============2788950548475253531==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Wed, 21 Oct 2020 12:51:53 +0200 Matthieu Baerts wrote:
> Like TCP, MPTCP cannot be compiled as a module. Obviously, MPTCP IPv6'
> support also depends on CONFIG_IPV6. But not all functions from IPv6
> code are exported.
> =

> To simplify the code and reduce modifications outside MPTCP, it was
> decided from the beginning to support MPTCP with IPv6 only if
> CONFIG_IPV6 was built inlined. That's also why CONFIG_MPTCP_IPV6 was
> created. More modifications are needed to support CONFIG_IPV6=3Dm.

Applied, thanks!
--===============2788950548475253531==--

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=7Dd5=D4=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1356CC388F9
	for <linux-kernel@archiver.kernel.org>; Wed, 21 Oct 2020 15:08:42 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 9C4742225F
	for <linux-kernel@archiver.kernel.org>; Wed, 21 Oct 2020 15:08:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1603292921;
	bh=CWtby+TblFCsj7hiKNeGlWF7bXc2sJ9RQ/P5oSDZnjc=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=sz41XNOx1GM2iYebxpMNr+kxU3+4azGDFGN00PcJ/yY5hfu6L5F/U3etgySoLb9dY
	 n+XsslY/dc8uQJkPtu4kfUp9yoUZ8IfpdS8iYIQPPJUt3C6w0xICfzDTSm57fszf3/
	 EsBHzk7J5UeoBgcFNeNqJ38upeR/Hdie1DpvBlA8=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2444032AbgJUPIk (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 21 Oct 2020 11:08:40 -0400
Received: from mail.kernel.org ([198.145.29.99]:40406 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2443878AbgJUPIk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Oct 2020 11:08:40 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 402E720BED;
        Wed, 21 Oct 2020 15:08:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1603292919;
        bh=CWtby+TblFCsj7hiKNeGlWF7bXc2sJ9RQ/P5oSDZnjc=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=CKNkJCD1mKR7Nm14SOvrvM+JzMuE/EfE5SnNQVOXWtrxuWYt+KeXHmER4vioslHRG
         boQB8/RdFtj4fL6VSAonl4UmH64kve75uGIXHCVfXsg9ljnc4PDdJsRLsDWMDtWlKK
         XZcp2B5Cwjz/HizvrkYkMbSAtqFnipv22flvruIw=
Date:   Wed, 21 Oct 2020 08:08:36 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Matthieu Baerts <matthieu.baerts@tessares.net>
Cc:     Mat Martineau <mathew.j.martineau@linux.intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        netdev@vger.kernel.org, mptcp@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] mptcp: depends on IPV6 but not as a module
Message-ID: <20201021080836.5ad77e45@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201021105154.628257-1-matthieu.baerts@tessares.net>
References: <20201021105154.628257-1-matthieu.baerts@tessares.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 21 Oct 2020 12:51:53 +0200 Matthieu Baerts wrote:
> Like TCP, MPTCP cannot be compiled as a module. Obviously, MPTCP IPv6'
> support also depends on CONFIG_IPV6. But not all functions from IPv6
> code are exported.
> 
> To simplify the code and reduce modifications outside MPTCP, it was
> decided from the beginning to support MPTCP with IPv6 only if
> CONFIG_IPV6 was built inlined. That's also why CONFIG_MPTCP_IPV6 was
> created. More modifications are needed to support CONFIG_IPV6=m.

Applied, thanks!