From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD04CC4363A for ; Wed, 21 Oct 2020 10:26:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27F6B2237B for ; Wed, 21 Oct 2020 10:26:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=veeam.com header.i=@veeam.com header.b="jrDBfzIY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392144AbgJUK0l (ORCPT ); Wed, 21 Oct 2020 06:26:41 -0400 Received: from mx4.veeam.com ([104.41.138.86]:35840 "EHLO mx4.veeam.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390048AbgJUK0k (ORCPT ); Wed, 21 Oct 2020 06:26:40 -0400 Received: from mail.veeam.com (spbmbx01.amust.local [172.17.17.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx4.veeam.com (Postfix) with ESMTPS id B5A348A76E; Wed, 21 Oct 2020 13:26:37 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=veeam.com; s=mx4; t=1603275998; bh=/p6v/6SAhY5h2ewrJ9FDQ7iNuIivMlmHNS95z40vB54=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=jrDBfzIYLZTU18COuJMG0YH/YRmu3Q2RULo8V7nTZTWqSfnco57Gjh+9xOeIo3NaI DD/wJhV5nzj4GgE0Gu4lUnVWX35iD1GJuqg39VSgVYIWx4tn/xt9ulFjk+JltEEkS1 opM1cZ9QZI/RTdxiEPExGJcHHduM+DtFPWfA6B5o= Received: from veeam.com (172.24.14.5) by spbmbx01.amust.local (172.17.17.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.595.3; Wed, 21 Oct 2020 13:26:35 +0300 Date: Wed, 21 Oct 2020 13:27:24 +0300 From: Sergei Shtepa To: Damien Le Moal CC: "axboe@kernel.dk" , "viro@zeniv.linux.org.uk" , "hch@infradead.org" , "darrick.wong@oracle.com" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "rjw@rjwysocki.net" , "len.brown@intel.com" , "pavel@ucw.cz" , "akpm@linux-foundation.org" , Johannes Thumshirn , "ming.lei@redhat.com" , "jack@suse.cz" , "tj@kernel.org" , "gustavo@embeddedor.com" , "bvanassche@acm.org" , "osandov@fb.com" , "koct9i@gmail.com" , "steve@sk2.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 1/2] Block layer filter - second version Message-ID: <20201021102724.GC20749@veeam.com> References: <1603271049-20681-1-git-send-email-sergei.shtepa@veeam.com> <1603271049-20681-2-git-send-email-sergei.shtepa@veeam.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: X-Originating-IP: [172.24.14.5] X-ClientProxiedBy: spbmbx02.amust.local (172.17.17.172) To spbmbx01.amust.local (172.17.17.171) X-EsetResult: clean, is OK X-EsetId: 37303A295605D26A677560 X-Veeam-MMEX: True Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org EXPORT_SYMBOL_GPL - ok. #ifdef CONFIG_BLK_FILTER or IS_ENABLED() - It's a matter of habit. > double blank line Ok, I did. Looks like a candidate for ./scripts/checkpatch.pl. > Separate into multiple patches: one that introduces the filter > functions/ops code and another that changes the block layer where needed. I'll think about it. Personally, it seems to me that this separation does not make it easier to understand the code. It is important for me to know immediately where the function is called, and this determines its behavior. -- Sergei Shtepa Veeam Software developer.