From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4596FC388F2 for ; Thu, 22 Oct 2020 05:12:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E19C02098B for ; Thu, 22 Oct 2020 05:12:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ju9bd5gp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502677AbgJVFMs (ORCPT ); Thu, 22 Oct 2020 01:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2444218AbgJVFMs (ORCPT ); Thu, 22 Oct 2020 01:12:48 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD2F8C0613D2 for ; Wed, 21 Oct 2020 22:12:46 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id b26so413834pff.3 for ; Wed, 21 Oct 2020 22:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2Zb63bH1NbEum/OLuzSIrhnLWeKUO8Zod+ndrWM7EmA=; b=Ju9bd5gphU99uj/yh0ufc8gQO+ePImeOwBqeesvMqPmC3AyeC0tO/3AyY71FcT8+UJ lhZWTwfk556SigBHRAMOs+x8SrDWcBTfqbt/rKeOSeiEtgT6Omg8FDoJz9Y8tVjy/mhy W2gpzNN+/VLnHnzOpW4uuZITN/dre75uqO3aoFILFRAcb3Fyub7jadMs9KCSgq8W0A+W XvDueW/cbwwS/N78UYnh07M9h5ohJTKWRx8DJqlXS5WfrN/BMHxA/wyRdGF3bMBvo3G7 Azv+j0mVpLtSIkuEjWr8jdSb/cEP4Ve+suem9ZNycndWhPZeLNj0QwF5kLLQh69akiXK Z4HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2Zb63bH1NbEum/OLuzSIrhnLWeKUO8Zod+ndrWM7EmA=; b=i6JXkyomZqaijna+wYxqZQhPRrnJKuWrnLVV8PrCr1lGLw3LklB0aXMHcdnmAkSQdd b7dl4Bkmv99zqxO7yrenxP1LMqwYqj2MCcrlKBozYvm8BRkCuCggHJTcWs8jcQ8Li+EC QAopY1lRVJrZHUxRnrWoS48hx0EopuQ7140t89+QpD30LBfFAEs0muvn+zJm8+m1t7BY LeppbLJWqhBheOY1Z/EpBoPA6zgI04+7QuraNKtrHQaoqdiUnsAH5LnisOuIjg/Iyfhg imRCkx2IxAdr1/WojKZ5t7fMrGkdBnxLcFp3v1yCg9YTffHaLehkt0Evg1aC3jqbNItW Agew== X-Gm-Message-State: AOAM532AJ5odqJ8n15iPVHsw/HB4oxiieRlu5ZUgeA1SJQ+nSrlNkg9o FBasaBBLV8deP2G8pHHQvT1PMA== X-Google-Smtp-Source: ABdhPJyeB2dOc+PbV3anGzAlbLWOVkX8Lfo6+NfKbVZ5BbJKHOgDEoPAhSmOXTX5LGmjkYXRJZQ01A== X-Received: by 2002:a63:24c2:: with SMTP id k185mr870579pgk.421.1603343565998; Wed, 21 Oct 2020 22:12:45 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id q66sm505225pfc.109.2020.10.21.22.12.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2020 22:12:45 -0700 (PDT) Date: Thu, 22 Oct 2020 10:42:43 +0530 From: Viresh Kumar To: Rob Clark Cc: Rajendra Nayak , Sean Paul , Linux PM , Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Douglas Anderson , Naresh Kamboju , linux-arm-msm , dri-devel , freedreno , Linux Kernel Mailing List Subject: Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table() Message-ID: <20201022051243.gsjx2ksoilec4wo2@vireshk-i7> References: <6e4110032f8711e8bb0acbeccfe66dec3b09d5c1.1598594714.git.viresh.kumar@linaro.org> <20201005062633.ejpehkpeuwksrx3e@vireshk-i7> <20201021072404.y43tjzd2ehclrejp@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21-10-20, 09:58, Rob Clark wrote: > On Wed, Oct 21, 2020 at 12:24 AM Viresh Kumar wrote: > > > > On 05-10-20, 11:56, Viresh Kumar wrote: > > > On 28-08-20, 11:37, Viresh Kumar wrote: > > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > > > find the OPP table with error -ENODEV (i.e. OPP table not present for > > > > the device). And we can call dev_pm_opp_of_remove_table() > > > > unconditionally here. > > > > > > > > While at it, also create a label to put clkname. > > > > > > > > Signed-off-by: Viresh Kumar > > > > > > Can someone please apply this and the other drm patch (2/8) ? > > > > Rob/Rajendra, can someone please have a look at these patches ? > > Oh, sorry I missed that, could someone re-send it and CC > freedreno@lists.freedesktop.org so it shows up in patchworks.. that is > more reliable counting on me to not overlook something in my mail I have just bounced it back to you and freedreno was already cc'd, though I have bounced it there again. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B028AC4363A for ; Thu, 22 Oct 2020 07:28:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 347C620848 for ; Thu, 22 Oct 2020 07:28:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ju9bd5gp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 347C620848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C83176F3DA; Thu, 22 Oct 2020 07:27:49 +0000 (UTC) Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6FCC86F3A2 for ; Thu, 22 Oct 2020 05:12:46 +0000 (UTC) Received: by mail-pf1-x441.google.com with SMTP id c20so400219pfr.8 for ; Wed, 21 Oct 2020 22:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2Zb63bH1NbEum/OLuzSIrhnLWeKUO8Zod+ndrWM7EmA=; b=Ju9bd5gphU99uj/yh0ufc8gQO+ePImeOwBqeesvMqPmC3AyeC0tO/3AyY71FcT8+UJ lhZWTwfk556SigBHRAMOs+x8SrDWcBTfqbt/rKeOSeiEtgT6Omg8FDoJz9Y8tVjy/mhy W2gpzNN+/VLnHnzOpW4uuZITN/dre75uqO3aoFILFRAcb3Fyub7jadMs9KCSgq8W0A+W XvDueW/cbwwS/N78UYnh07M9h5ohJTKWRx8DJqlXS5WfrN/BMHxA/wyRdGF3bMBvo3G7 Azv+j0mVpLtSIkuEjWr8jdSb/cEP4Ve+suem9ZNycndWhPZeLNj0QwF5kLLQh69akiXK Z4HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2Zb63bH1NbEum/OLuzSIrhnLWeKUO8Zod+ndrWM7EmA=; b=roouJoKPdxPOnlkxzSOt1KzISFyFzhJMtYXkkVcmyEMorEgvbVnDK6Z1yjDJ7Iuo7T iKR4+5OERuT0y4MCSr8Jpgo+RcEtD7Iabn5hp3O3ZWCByr8HMO6RqpSVXeN1mbTZXgWs XRlFzCQ6Q/mNMdL62cCeRg1/vUvl3CIxf4jnveLC28NROAXGjzeFlNYdt7CWF6NwtODS Ec66ZWRboxa63EBPC+7+fbD9DoZLPHeYh4rhgvfj6WclBARGOoXMCgC/75OKZSHBQhb3 MhrG0mwjPBcbQaWxcrp59RulurGLAco2Bhsr0osgzwuizQKU1Ok+9/RedLLeegVuLTI+ Mp4Q== X-Gm-Message-State: AOAM530dUIJwxEpmmWG9d4+/k9XoTG7qof6yOAuBjC9oVC8FNw1YFo9G ffgKPWZLGwFwaFRbiJ/nL8s4/A== X-Google-Smtp-Source: ABdhPJyeB2dOc+PbV3anGzAlbLWOVkX8Lfo6+NfKbVZ5BbJKHOgDEoPAhSmOXTX5LGmjkYXRJZQ01A== X-Received: by 2002:a63:24c2:: with SMTP id k185mr870579pgk.421.1603343565998; Wed, 21 Oct 2020 22:12:45 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id q66sm505225pfc.109.2020.10.21.22.12.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2020 22:12:45 -0700 (PDT) Date: Thu, 22 Oct 2020 10:42:43 +0530 From: Viresh Kumar To: Rob Clark Subject: Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table() Message-ID: <20201022051243.gsjx2ksoilec4wo2@vireshk-i7> References: <6e4110032f8711e8bb0acbeccfe66dec3b09d5c1.1598594714.git.viresh.kumar@linaro.org> <20201005062633.ejpehkpeuwksrx3e@vireshk-i7> <20201021072404.y43tjzd2ehclrejp@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-Mailman-Approved-At: Thu, 22 Oct 2020 07:27:48 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , freedreno , Rajendra Nayak , Linux PM , Stephen Boyd , linux-arm-msm , Naresh Kamboju , Rafael Wysocki , Douglas Anderson , dri-devel , Linux Kernel Mailing List , Vincent Guittot , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 21-10-20, 09:58, Rob Clark wrote: > On Wed, Oct 21, 2020 at 12:24 AM Viresh Kumar wrote: > > > > On 05-10-20, 11:56, Viresh Kumar wrote: > > > On 28-08-20, 11:37, Viresh Kumar wrote: > > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > > > find the OPP table with error -ENODEV (i.e. OPP table not present for > > > > the device). And we can call dev_pm_opp_of_remove_table() > > > > unconditionally here. > > > > > > > > While at it, also create a label to put clkname. > > > > > > > > Signed-off-by: Viresh Kumar > > > > > > Can someone please apply this and the other drm patch (2/8) ? > > > > Rob/Rajendra, can someone please have a look at these patches ? > > Oh, sorry I missed that, could someone re-send it and CC > freedreno@lists.freedesktop.org so it shows up in patchworks.. that is > more reliable counting on me to not overlook something in my mail I have just bounced it back to you and freedreno was already cc'd, though I have bounced it there again. -- viresh _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel