From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A132CC388F2 for ; Thu, 22 Oct 2020 05:15:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E7B32145D for ; Thu, 22 Oct 2020 05:15:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yOA8f8kv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2507847AbgJVFO7 (ORCPT ); Thu, 22 Oct 2020 01:14:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2507838AbgJVFO6 (ORCPT ); Thu, 22 Oct 2020 01:14:58 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 108E7C0613CE for ; Wed, 21 Oct 2020 22:14:57 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id w21so404919pfc.7 for ; Wed, 21 Oct 2020 22:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9N4AwJ1uFCW577znU9D4xEwyN9NsDba4VzTyi1307gQ=; b=yOA8f8kva3txVhVULf+6KyqMM6X6M5+Xq4kyU1AaaaeiRmVBHtfho0ndnz7P7+ksgb W2XD8LnIqe4xOqonit7kehkgF+JZvgSGPfhjNDzWxpcHS646OOK8Oy/L48/DVwIkJuYO UgvmCwGCf28d9+rxPSjbDBdwXk3YJ5o3rHKw8gw5dB3lYEv14YjymPgNjCJsTWFB3bOb fPWrK3+Q6/dnEzTjIo15k0gfucqhX08ixAMmzbXz7iLoAnG7g2ClLIDG2i4sATiuDCxq TRv2Lnax6EY1hdZkDGSJwIiZvtvt7dWcO60+ED8uAgRt3gWh/GBsdSZn196afU1z76WC SW2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9N4AwJ1uFCW577znU9D4xEwyN9NsDba4VzTyi1307gQ=; b=Fr4Trk3fkOS2el1C506fU2OjMNghyzshy1gTfRMu3NIWaC/PsxfgJ47MEjIzV8bAdH Ionjn2PkRCkGGZ0JKLJArYcWOw3GhrvmrhpjHFZ2+Pi5Da1UQ+m9jrgQV8iXTwJqh4XH dU2uYCpP4UT7lpVX/lK+izEDiPVuYWGlyGxgtwiIb6QT43Bi3w9si2QzTP2y0uC5S8JB lYqOmV75ufWwniDPJh1rqkn1BYrqvJ3tIOhtf2r8TxkHQxboM9D1Ru5VInw5xqeJrEI+ ceV7bc801PXwDLJKm50tenByEWwBG0cB6Naw8F3ii1OdlGu1EOyg/09YKBGu5MDyVP3Q uXng== X-Gm-Message-State: AOAM5322hVaO+ct3vyUVO4Q6NPDAkasnfVz8ZQfpO8iO0jBXFRR5zzns 0OKcjKFKzkfTtOtvJuZoqw5d8A== X-Google-Smtp-Source: ABdhPJy/Aaj8vx5eIZaXacCj6mJYxS7bjf6e3Y9pPqYEIm1OT+kS0t3cdteyul8PjIUtlKAzs3Sbnw== X-Received: by 2002:a63:3d48:: with SMTP id k69mr880965pga.269.1603343696496; Wed, 21 Oct 2020 22:14:56 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id z18sm482300pfn.158.2020.10.21.22.14.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2020 22:14:55 -0700 (PDT) Date: Thu, 22 Oct 2020 10:44:53 +0530 From: Viresh Kumar To: rnayak@codeaurora.org, Qiang Yu , David Airlie , Daniel Vetter Cc: linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Douglas Anderson , Naresh Kamboju , dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/8] drm/lima: Unconditionally call dev_pm_opp_of_remove_table() Message-ID: <20201022051453.xufcga7icohm74rg@vireshk-i7> References: <62d944bdac75ec696828daad49fc1ddb6c637bcf.1598594714.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62d944bdac75ec696828daad49fc1ddb6c637bcf.1598594714.git.viresh.kumar@linaro.org> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28-08-20, 11:37, Viresh Kumar wrote: > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > find the OPP table with error -ENODEV (i.e. OPP table not present for > the device). And we can call dev_pm_opp_of_remove_table() > unconditionally here. > > Reviewed-by: Qiang Yu > Signed-off-by: Viresh Kumar > > --- > V2: Applied Reviewed by tag. > --- > drivers/gpu/drm/lima/lima_devfreq.c | 6 +----- > drivers/gpu/drm/lima/lima_devfreq.h | 1 - > 2 files changed, 1 insertion(+), 6 deletions(-) Qiang, can you please pick it up ? -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBC7C388F7 for ; Thu, 22 Oct 2020 07:28:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0159120848 for ; Thu, 22 Oct 2020 07:28:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yOA8f8kv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0159120848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C01996F51D; Thu, 22 Oct 2020 07:28:18 +0000 (UTC) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD03A6F3A2 for ; Thu, 22 Oct 2020 05:14:56 +0000 (UTC) Received: by mail-pg1-x541.google.com with SMTP id r10so240152pgb.10 for ; Wed, 21 Oct 2020 22:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9N4AwJ1uFCW577znU9D4xEwyN9NsDba4VzTyi1307gQ=; b=yOA8f8kva3txVhVULf+6KyqMM6X6M5+Xq4kyU1AaaaeiRmVBHtfho0ndnz7P7+ksgb W2XD8LnIqe4xOqonit7kehkgF+JZvgSGPfhjNDzWxpcHS646OOK8Oy/L48/DVwIkJuYO UgvmCwGCf28d9+rxPSjbDBdwXk3YJ5o3rHKw8gw5dB3lYEv14YjymPgNjCJsTWFB3bOb fPWrK3+Q6/dnEzTjIo15k0gfucqhX08ixAMmzbXz7iLoAnG7g2ClLIDG2i4sATiuDCxq TRv2Lnax6EY1hdZkDGSJwIiZvtvt7dWcO60+ED8uAgRt3gWh/GBsdSZn196afU1z76WC SW2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9N4AwJ1uFCW577znU9D4xEwyN9NsDba4VzTyi1307gQ=; b=sUlPFDQgDrZiOGepAw5b4KHbCGHGSeIsfv4Yx8V+Yz69X/8ncnxRpZpvkF6ja+CiHZ cd5D4aZxW4XO2xPG7CGw52+KtSJ5T6spv3IpfiuDBYEch22P3WNCjKCf3QUwHpyrZlIn LHqFzR1GbyTl9gaOlmUz4nysU4iz1nVanSSZPmetMHHYyfzGep0Y0V4pxqBffQfp73Cm ZCGX9YFfKDU72I2A2TRr1uQ9OrzXUXIeQwKoi9l5H1CfNI/hM4HAa5VMJ4UxwHM4YLxA FSszF/wwNTiE4pp3jsyt831eMGvrKk+A0Ycdaxj+yrFbCN55eaQOjwOjJ9PEqmlSL5sU PciQ== X-Gm-Message-State: AOAM532E1L2j6z6jhnKEBdBpHjHZqjCOQRXWXqflJzjd+22cxdo+IzFU wPezqAKTTV2TX10uKnUqigUdIA== X-Google-Smtp-Source: ABdhPJy/Aaj8vx5eIZaXacCj6mJYxS7bjf6e3Y9pPqYEIm1OT+kS0t3cdteyul8PjIUtlKAzs3Sbnw== X-Received: by 2002:a63:3d48:: with SMTP id k69mr880965pga.269.1603343696496; Wed, 21 Oct 2020 22:14:56 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id z18sm482300pfn.158.2020.10.21.22.14.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2020 22:14:55 -0700 (PDT) Date: Thu, 22 Oct 2020 10:44:53 +0530 From: Viresh Kumar To: rnayak@codeaurora.org, Qiang Yu , David Airlie , Daniel Vetter Subject: Re: [PATCH V2 2/8] drm/lima: Unconditionally call dev_pm_opp_of_remove_table() Message-ID: <20201022051453.xufcga7icohm74rg@vireshk-i7> References: <62d944bdac75ec696828daad49fc1ddb6c637bcf.1598594714.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <62d944bdac75ec696828daad49fc1ddb6c637bcf.1598594714.git.viresh.kumar@linaro.org> User-Agent: NeoMutt/20180716-391-311a52 X-Mailman-Approved-At: Thu, 22 Oct 2020 07:27:48 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , lima@lists.freedesktop.org, linux-pm@vger.kernel.org, Stephen Boyd , Naresh Kamboju , Rafael Wysocki , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28-08-20, 11:37, Viresh Kumar wrote: > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > find the OPP table with error -ENODEV (i.e. OPP table not present for > the device). And we can call dev_pm_opp_of_remove_table() > unconditionally here. > > Reviewed-by: Qiang Yu > Signed-off-by: Viresh Kumar > > --- > V2: Applied Reviewed by tag. > --- > drivers/gpu/drm/lima/lima_devfreq.c | 6 +----- > drivers/gpu/drm/lima/lima_devfreq.h | 1 - > 2 files changed, 1 insertion(+), 6 deletions(-) Qiang, can you please pick it up ? -- viresh _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel