From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FCF1C388F7 for ; Thu, 22 Oct 2020 07:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B80521707 for ; Thu, 22 Oct 2020 07:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="E/MPYUGe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2508715AbgJVHjt (ORCPT ); Thu, 22 Oct 2020 03:39:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2506737AbgJVHjs (ORCPT ); Thu, 22 Oct 2020 03:39:48 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B99F5C0613CF for ; Thu, 22 Oct 2020 00:39:47 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id y12so867306wrp.6 for ; Thu, 22 Oct 2020 00:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FUnmmeK5QmN6I6X95NR6HhlReLcd0WiZp6VBOWMixY8=; b=E/MPYUGexYpX5poBWZtyJ39mlDhFG9B6MQdMbkqfAlosbuXR0KbLsXkH8XsRroHwK0 /z7PTmxv54Le3uyVqgU2BJoYAcDBAKDf93cFoIPUObTp1nwUXkwW9LrbIa/QW11E9gxi dUfc5MnZ1w7Z5dq/D5VWhQ+QyH68LGgtFOW8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=FUnmmeK5QmN6I6X95NR6HhlReLcd0WiZp6VBOWMixY8=; b=EZid21r/Ja7t55kfGHYpqrkQRoXGC5VNTd0OJk8z2eV+pWUE7qEBGfXwv0B7rY7TNz KUYCeNen4tqf6y9MSXADPQ1t6UdVdVdQvPKGETnpLtBCgKQ7pKc47qA9CtVe4rnhUcZb kep+RAn7i/WFGE++g7feWPPnaYIMPrR3CUb/OflpYlhUl/Yb5uB2Btb806oeo96tpDIz NIGr3PQc8eXr0knfW1vXLtFePgfeiJJ0GqPpU23rgkEbw8256KaNiuW3jxMRVWgchwR8 XZTjYwIawZ7MktgJfzpMw0F3MgkHK75HvS+sfePedVrB3gLrcwX8e8/+gjlbd/xt7szp 3gMw== X-Gm-Message-State: AOAM531h4aRAV+IIdbc14HBm8fjMKjj5SJkM+hGjnWFsYJcwBJCwp/jl y87F14twM7k0lx6LS2srqAESQQ== X-Google-Smtp-Source: ABdhPJw5HQV9NuUaTW2fOSG+4dZhqrMNCjk+Neg7/gkBYNKwDOO+9vGK8A43OgHPliV3xlB5PKsA7A== X-Received: by 2002:adf:f986:: with SMTP id f6mr1319485wrr.38.1603352386434; Thu, 22 Oct 2020 00:39:46 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j7sm2061526wrn.81.2020.10.22.00.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 00:39:45 -0700 (PDT) Date: Thu, 22 Oct 2020 09:39:43 +0200 From: Daniel Vetter To: Niklas Schnelle Cc: DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Gerald Schaefer , Daniel Vetter , Jason Gunthorpe , Dan Williams , Kees Cook , Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , Jan Kara Subject: Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates Message-ID: <20201022073943.GS401619@phenom.ffwll.local> Mail-Followup-To: Niklas Schnelle , DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Gerald Schaefer , Daniel Vetter , Jason Gunthorpe , Dan Williams , Kees Cook , Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , Jan Kara References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-9-daniel.vetter@ffwll.ch> <6deb08dd-46f3-bf26-5362-fdc696f6fd74@linux.ibm.com> <20201012141906.GX438822@phenom.ffwll.local> <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2020 at 09:55:57AM +0200, Niklas Schnelle wrote: > Hi Daniel, > > friendly ping. I haven't seen a new version of this patch series, > as I said I think your change for s390/pci is generally useful so > I'm curious, are you planning on sending a new version soon? > If you want you can also just sent this patch with the last few > nitpicks (primarily the mail address) fixed and I'll happily apply. (I think this was stuck somewhere in moderation, only showed up just now) I was waiting for the testing result for the habana driver from Oded, but I guess Oded was waiting for v3. Hence the delay. Cheers, Daniel > > Best regards, > Niklas Schnelle > > On 10/12/20 4:19 PM, Daniel Vetter wrote: > > On Mon, Oct 12, 2020 at 04:03:28PM +0200, Niklas Schnelle wrote: > ... snip .... > >>> Cc: Jason Gunthorpe > >>> Cc: Dan Williams > >>> Cc: Kees Cook > >>> Cc: Andrew Morton > >>> Cc: John Hubbard > >>> Cc: Jérôme Glisse > >>> Cc: Jan Kara > >>> Cc: Dan Williams > >> > >> The above Cc: line for Dan Williams is a duplicate > >> > >>> Cc: linux-mm@kvack.org > >>> Cc: linux-arm-kernel@lists.infradead.org > >>> Cc: linux-samsung-soc@vger.kernel.org > >>> Cc: linux-media@vger.kernel.org > >>> Cc: Niklas Schnelle > >>> Cc: Gerald Schaefer > >>> Cc: linux-s390@vger.kernel.org > >>> -- > >>> v2: Move VM_IO | VM_PFNMAP checks around so they keep returning EINVAL > >>> like before (Gerard) > >> > >> I think the above should go before the CC/Signed-off/Reviewev block. > > > > This is a per-subsystem bikeshed :-) drivers/gpu definitely wants it > > above, but most core subsystems want it below. I'll move it. > > > >>> --- > >>> arch/s390/pci/pci_mmio.c | 98 +++++++++++++++++++++++----------------- > >>> 1 file changed, 57 insertions(+), 41 deletions(-) > >>> > >>> diff --git a/arch/s390/pci/pci_mmio.c b/arch/s390/pci/pci_mmio.c > >>> index 401cf670a243..1a6adbc68ee8 100644 > >>> --- a/arch/s390/pci/pci_mmio.c > >>> +++ b/arch/s390/pci/pci_mmio.c > >>> @@ -119,33 +119,15 @@ static inline int __memcpy_toio_inuser(void __iomem *dst, > >>> return rc; > >>> } > >>> > >>> -static long get_pfn(unsigned long user_addr, unsigned long access, > >>> - unsigned long *pfn) > >>> -{ > >>> - struct vm_area_struct *vma; > >>> - long ret; > >>> - > >>> - mmap_read_lock(current->mm); > >>> - ret = -EINVAL; > >>> - vma = find_vma(current->mm, user_addr); > >>> - if (!vma) > >>> - goto out; > >>> - ret = -EACCES; > >>> - if (!(vma->vm_flags & access)) > >>> - goto out; > >>> - ret = follow_pfn(vma, user_addr, pfn); > >>> -out: > >>> - mmap_read_unlock(current->mm); > >>> - return ret; > >>> -} > >>> - > >>> SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, mmio_addr, > >>> const void __user *, user_buffer, size_t, length) > >>> { > >>> u8 local_buf[64]; > >>> void __iomem *io_addr; > >>> void *buf; > >>> - unsigned long pfn; > >>> + struct vm_area_struct *vma; > >>> + pte_t *ptep; > >>> + spinlock_t *ptl; > >> > >> With checkpatch.pl --strict the above yields a complained > >> "CHECK: spinlock_t definition without comment" but I think > >> that's really okay since your commit description is very clear. > >> Same oin line 277. > > > > I think this is a falls positive, checkpatch doesn't realize that > > SYSCALL_DEFINE3 is a function, not a structure. And in a structure I'd > > have added the kerneldoc or comment. > > > > I'll fix up all the nits you've found for the next round. Thanks for > > taking a look. > > -Daniel > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2506719AbgJVHjs (ORCPT ); Thu, 22 Oct 2020 03:39:48 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC60C0613CE for ; Thu, 22 Oct 2020 00:39:47 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h7so875672wre.4 for ; Thu, 22 Oct 2020 00:39:47 -0700 (PDT) Date: Thu, 22 Oct 2020 09:39:43 +0200 From: Daniel Vetter Subject: Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates Message-ID: <20201022073943.GS401619@phenom.ffwll.local> References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-9-daniel.vetter@ffwll.ch> <6deb08dd-46f3-bf26-5362-fdc696f6fd74@linux.ibm.com> <20201012141906.GX438822@phenom.ffwll.local> <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> List-ID: To: Niklas Schnelle Cc: DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Gerald Schaefer , Daniel Vetter , Jason Gunthorpe , Dan Williams , Kees Cook , Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , Jan Kara On Wed, Oct 21, 2020 at 09:55:57AM +0200, Niklas Schnelle wrote: > Hi Daniel, >=20 > friendly ping. I haven't seen a new version of this patch series, > as I said I think your change for s390/pci is generally useful so > I'm curious, are you planning on sending a new version soon? > If you want you can also just sent this patch with the last few > nitpicks (primarily the mail address) fixed and I'll happily apply. (I think this was stuck somewhere in moderation, only showed up just now) I was waiting for the testing result for the habana driver from Oded, but I guess Oded was waiting for v3. Hence the delay. Cheers, Daniel >=20 > Best regards, > Niklas Schnelle >=20 > On 10/12/20 4:19 PM, Daniel Vetter wrote: > > On Mon, Oct 12, 2020 at 04:03:28PM +0200, Niklas Schnelle wrote: > ... snip .... > >>> Cc: Jason Gunthorpe > >>> Cc: Dan Williams > >>> Cc: Kees Cook > >>> Cc: Andrew Morton > >>> Cc: John Hubbard > >>> Cc: J=EF=BF=BDr=EF=BF=BDme Glisse > >>> Cc: Jan Kara > >>> Cc: Dan Williams > >> > >> The above Cc: line for Dan Williams is a duplicate > >> > >>> Cc: linux-mm@kvack.org > >>> Cc: linux-arm-kernel@lists.infradead.org > >>> Cc: linux-samsung-soc@vger.kernel.org > >>> Cc: linux-media@vger.kernel.org > >>> Cc: Niklas Schnelle > >>> Cc: Gerald Schaefer > >>> Cc: linux-s390@vger.kernel.org > >>> -- > >>> v2: Move VM_IO | VM_PFNMAP checks around so they keep returning EINVAL > >>> like before (Gerard) > >> > >> I think the above should go before the CC/Signed-off/Reviewev block. > >=20 > > This is a per-subsystem bikeshed :-) drivers/gpu definitely wants it > > above, but most core subsystems want it below. I'll move it. > >=20 > >>> --- > >>> arch/s390/pci/pci_mmio.c | 98 +++++++++++++++++++++++---------------= -- > >>> 1 file changed, 57 insertions(+), 41 deletions(-) > >>> > >>> diff --git a/arch/s390/pci/pci_mmio.c b/arch/s390/pci/pci_mmio.c > >>> index 401cf670a243..1a6adbc68ee8 100644 > >>> --- a/arch/s390/pci/pci_mmio.c > >>> +++ b/arch/s390/pci/pci_mmio.c > >>> @@ -119,33 +119,15 @@ static inline int __memcpy_toio_inuser(void __i= omem *dst, > >>> return rc; > >>> } > >>> =20 > >>> -static long get_pfn(unsigned long user_addr, unsigned long access, > >>> - unsigned long *pfn) > >>> -{ > >>> - struct vm_area_struct *vma; > >>> - long ret; > >>> - > >>> - mmap_read_lock(current->mm); > >>> - ret =3D -EINVAL; > >>> - vma =3D find_vma(current->mm, user_addr); > >>> - if (!vma) > >>> - goto out; > >>> - ret =3D -EACCES; > >>> - if (!(vma->vm_flags & access)) > >>> - goto out; > >>> - ret =3D follow_pfn(vma, user_addr, pfn); > >>> -out: > >>> - mmap_read_unlock(current->mm); > >>> - return ret; > >>> -} > >>> - > >>> SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, mmio_addr, > >>> const void __user *, user_buffer, size_t, length) > >>> { > >>> u8 local_buf[64]; > >>> void __iomem *io_addr; > >>> void *buf; > >>> - unsigned long pfn; > >>> + struct vm_area_struct *vma; > >>> + pte_t *ptep; > >>> + spinlock_t *ptl; > >> > >> With checkpatch.pl --strict the above yields a complained > >> "CHECK: spinlock_t definition without comment" but I think > >> that's really okay since your commit description is very clear. > >> Same oin line 277. > >=20 > > I think this is a falls positive, checkpatch doesn't realize that > > SYSCALL_DEFINE3 is a function, not a structure. And in a structure I'd > > have added the kerneldoc or comment. > >=20 > > I'll fix up all the nits you've found for the next round. Thanks for > > taking a look. > > -Daniel > >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 875C8C56201 for ; Thu, 22 Oct 2020 07:42:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1765D21707 for ; Thu, 22 Oct 2020 07:42:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NuuiBahU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="E/MPYUGe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1765D21707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Uh5IwfMsdLIgnahAb0zONhfb3qbvq3HCQxzg+aWngsU=; b=NuuiBahUPeropw9WYfJgNahDi 2mB4JZxO8sg8OmXKzwp/E9G2lqlFuvqUaGMEc1SWg6RrWI745HjyIt85vOjCy2Pl5Ve/7z6csdFX/ BDhvYtybdNqSWa4qi128fvPbmjFRzw0epMA1+O3HHSBYo9i0jgKyrtu53I+5PDVGC5KBewq++idt3 xPSrqd0YKWAV5UeS3Zi27pdHuOQMlkriybUYVicVS0m+fkiBaM5WD/Yi52Guizz0BxC270p6Pz+ve 5JYVJ2BhcLQoWNP/PXF6sme69E1XS0cbTHJZ9ZiSjEcb98agWJUt8kseM+jmdXVcJfBCOyxCLgpS4 hayzSeIRw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVVCS-0005Zu-Ct; Thu, 22 Oct 2020 07:39:52 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVVCO-0005Y4-U5 for linux-arm-kernel@lists.infradead.org; Thu, 22 Oct 2020 07:39:50 +0000 Received: by mail-wr1-x444.google.com with SMTP id s9so861999wro.8 for ; Thu, 22 Oct 2020 00:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FUnmmeK5QmN6I6X95NR6HhlReLcd0WiZp6VBOWMixY8=; b=E/MPYUGexYpX5poBWZtyJ39mlDhFG9B6MQdMbkqfAlosbuXR0KbLsXkH8XsRroHwK0 /z7PTmxv54Le3uyVqgU2BJoYAcDBAKDf93cFoIPUObTp1nwUXkwW9LrbIa/QW11E9gxi dUfc5MnZ1w7Z5dq/D5VWhQ+QyH68LGgtFOW8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=FUnmmeK5QmN6I6X95NR6HhlReLcd0WiZp6VBOWMixY8=; b=UjBdrSXZoHxifh6JJllyzJJ96IpfdDnLANDWL8Tl2Y7W+SNBtU64585IxNxLgZw42m buugefysE+xMLFFKMzhq0pwGlaZn+VNxCuEis8ZEenuIWdKSQW5a3rLjcHH69Nmh9mfi shBuvn1IWG+WXzeLGnoFmZKRJY50DVUFLyYrMA/9kmnycMIThXTnenER5hTJnIwIkD1Z 7YS1X5cXA42p8/SIKjs02x3J8qv/6RH/YY2L8Bx9ePtNgyvCHNHDZrEqBagE3467L7DQ +7pQpucWTXyrhA+oI+ITiAg5+BtxXfJwpY4x9VxZzKbGmGkpWz6C/iJ8qWHaKF16rzMu aGIw== X-Gm-Message-State: AOAM533z33gpDfwvIC07rOzKAKZA7yU4QwtGlbn51zOUcePaPJ1Keyq9 S5f4s3vwjmRhDYNolf78nK/7ioMljbF7C4TX X-Google-Smtp-Source: ABdhPJw5HQV9NuUaTW2fOSG+4dZhqrMNCjk+Neg7/gkBYNKwDOO+9vGK8A43OgHPliV3xlB5PKsA7A== X-Received: by 2002:adf:f986:: with SMTP id f6mr1319485wrr.38.1603352386434; Thu, 22 Oct 2020 00:39:46 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j7sm2061526wrn.81.2020.10.22.00.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 00:39:45 -0700 (PDT) Date: Thu, 22 Oct 2020 09:39:43 +0200 From: Daniel Vetter To: Niklas Schnelle Subject: Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates Message-ID: <20201022073943.GS401619@phenom.ffwll.local> Mail-Followup-To: Niklas Schnelle , DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Gerald Schaefer , Daniel Vetter , Jason Gunthorpe , Dan Williams , Kees Cook , Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , Jan Kara References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-9-daniel.vetter@ffwll.ch> <6deb08dd-46f3-bf26-5362-fdc696f6fd74@linux.ibm.com> <20201012141906.GX438822@phenom.ffwll.local> <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201022_033948_973015_3126454F X-CRM114-Status: GOOD ( 32.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jan Kara , Kees Cook , kvm@vger.kernel.org, Jason Gunthorpe , John Hubbard , LKML , DRI Development , Andrew Morton , linux-mm@kvack.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Daniel Vetter , Gerald Schaefer , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 21, 2020 at 09:55:57AM +0200, Niklas Schnelle wrote: > Hi Daniel, > = > friendly ping. I haven't seen a new version of this patch series, > as I said I think your change for s390/pci is generally useful so > I'm curious, are you planning on sending a new version soon? > If you want you can also just sent this patch with the last few > nitpicks (primarily the mail address) fixed and I'll happily apply. (I think this was stuck somewhere in moderation, only showed up just now) I was waiting for the testing result for the habana driver from Oded, but I guess Oded was waiting for v3. Hence the delay. Cheers, Daniel > = > Best regards, > Niklas Schnelle > = > On 10/12/20 4:19 PM, Daniel Vetter wrote: > > On Mon, Oct 12, 2020 at 04:03:28PM +0200, Niklas Schnelle wrote: > ... snip .... > >>> Cc: Jason Gunthorpe > >>> Cc: Dan Williams > >>> Cc: Kees Cook > >>> Cc: Andrew Morton > >>> Cc: John Hubbard > >>> Cc: J=E9r=F4me Glisse > >>> Cc: Jan Kara > >>> Cc: Dan Williams > >> > >> The above Cc: line for Dan Williams is a duplicate > >> > >>> Cc: linux-mm@kvack.org > >>> Cc: linux-arm-kernel@lists.infradead.org > >>> Cc: linux-samsung-soc@vger.kernel.org > >>> Cc: linux-media@vger.kernel.org > >>> Cc: Niklas Schnelle > >>> Cc: Gerald Schaefer > >>> Cc: linux-s390@vger.kernel.org > >>> -- > >>> v2: Move VM_IO | VM_PFNMAP checks around so they keep returning EINVAL > >>> like before (Gerard) > >> > >> I think the above should go before the CC/Signed-off/Reviewev block. > > = > > This is a per-subsystem bikeshed :-) drivers/gpu definitely wants it > > above, but most core subsystems want it below. I'll move it. > > = > >>> --- > >>> arch/s390/pci/pci_mmio.c | 98 +++++++++++++++++++++++---------------= -- > >>> 1 file changed, 57 insertions(+), 41 deletions(-) > >>> > >>> diff --git a/arch/s390/pci/pci_mmio.c b/arch/s390/pci/pci_mmio.c > >>> index 401cf670a243..1a6adbc68ee8 100644 > >>> --- a/arch/s390/pci/pci_mmio.c > >>> +++ b/arch/s390/pci/pci_mmio.c > >>> @@ -119,33 +119,15 @@ static inline int __memcpy_toio_inuser(void __i= omem *dst, > >>> return rc; > >>> } > >>> = > >>> -static long get_pfn(unsigned long user_addr, unsigned long access, > >>> - unsigned long *pfn) > >>> -{ > >>> - struct vm_area_struct *vma; > >>> - long ret; > >>> - > >>> - mmap_read_lock(current->mm); > >>> - ret =3D -EINVAL; > >>> - vma =3D find_vma(current->mm, user_addr); > >>> - if (!vma) > >>> - goto out; > >>> - ret =3D -EACCES; > >>> - if (!(vma->vm_flags & access)) > >>> - goto out; > >>> - ret =3D follow_pfn(vma, user_addr, pfn); > >>> -out: > >>> - mmap_read_unlock(current->mm); > >>> - return ret; > >>> -} > >>> - > >>> SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, mmio_addr, > >>> const void __user *, user_buffer, size_t, length) > >>> { > >>> u8 local_buf[64]; > >>> void __iomem *io_addr; > >>> void *buf; > >>> - unsigned long pfn; > >>> + struct vm_area_struct *vma; > >>> + pte_t *ptep; > >>> + spinlock_t *ptl; > >> > >> With checkpatch.pl --strict the above yields a complained > >> "CHECK: spinlock_t definition without comment" but I think > >> that's really okay since your commit description is very clear. > >> Same oin line 277. > > = > > I think this is a falls positive, checkpatch doesn't realize that > > SYSCALL_DEFINE3 is a function, not a structure. And in a structure I'd > > have added the kerneldoc or comment. > > = > > I'll fix up all the nits you've found for the next round. Thanks for > > taking a look. > > -Daniel > > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411CFC388F2 for ; Thu, 22 Oct 2020 07:39:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C1F0222E9 for ; Thu, 22 Oct 2020 07:39:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="E/MPYUGe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C1F0222E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 92D1A6F3E4; Thu, 22 Oct 2020 07:39:48 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id B522E6F3E4 for ; Thu, 22 Oct 2020 07:39:47 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id i1so878714wro.1 for ; Thu, 22 Oct 2020 00:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FUnmmeK5QmN6I6X95NR6HhlReLcd0WiZp6VBOWMixY8=; b=E/MPYUGexYpX5poBWZtyJ39mlDhFG9B6MQdMbkqfAlosbuXR0KbLsXkH8XsRroHwK0 /z7PTmxv54Le3uyVqgU2BJoYAcDBAKDf93cFoIPUObTp1nwUXkwW9LrbIa/QW11E9gxi dUfc5MnZ1w7Z5dq/D5VWhQ+QyH68LGgtFOW8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=FUnmmeK5QmN6I6X95NR6HhlReLcd0WiZp6VBOWMixY8=; b=cfengXD0p3nhFLa7Fx+pweWKS/0PHR+UYgifP1WBjzR8VLDLpA8V4UkcdYgOzuO0CF 7Wzg4Bcat1RMazSy5j+qEufTvbmnw5DqNmqSavJQmu7A/GoyCfdHoFgRz1xQZ483s4QV fCKvAFfbPY1ZdGhWB62hTUmt2SxVK+wdloqqwAZAcnDZ32o+GBDNb1Q5/vHd7buZHJba 8XXcY4gdlc1GH+0HZa/m5fmomw/vERL52LworPZ7J8awnUPQATvQPwsr7FEaCI95X5Pj 9dE7dwqGE4lUUGqavsval96EQ+a5rVPoxBEWoH67iK7vF+UfDhCrfGUa/bZ1YzZL6O7g Gviw== X-Gm-Message-State: AOAM533abFDrByQf4vvP5rSBwWF0Z1QS/ib55UYkIITL4ttw7zefgM8Q GcQVvPYq2uEOlZHtF9EkCfMlsA== X-Google-Smtp-Source: ABdhPJw5HQV9NuUaTW2fOSG+4dZhqrMNCjk+Neg7/gkBYNKwDOO+9vGK8A43OgHPliV3xlB5PKsA7A== X-Received: by 2002:adf:f986:: with SMTP id f6mr1319485wrr.38.1603352386434; Thu, 22 Oct 2020 00:39:46 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j7sm2061526wrn.81.2020.10.22.00.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 00:39:45 -0700 (PDT) Date: Thu, 22 Oct 2020 09:39:43 +0200 From: Daniel Vetter To: Niklas Schnelle Subject: Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates Message-ID: <20201022073943.GS401619@phenom.ffwll.local> Mail-Followup-To: Niklas Schnelle , DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Gerald Schaefer , Daniel Vetter , Jason Gunthorpe , Dan Williams , Kees Cook , Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , Jan Kara References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-9-daniel.vetter@ffwll.ch> <6deb08dd-46f3-bf26-5362-fdc696f6fd74@linux.ibm.com> <20201012141906.GX438822@phenom.ffwll.local> <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jan Kara , Kees Cook , kvm@vger.kernel.org, Jason Gunthorpe , John Hubbard , LKML , DRI Development , Andrew Morton , linux-mm@kvack.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Daniel Vetter , Gerald Schaefer , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 21, 2020 at 09:55:57AM +0200, Niklas Schnelle wrote: > Hi Daniel, > = > friendly ping. I haven't seen a new version of this patch series, > as I said I think your change for s390/pci is generally useful so > I'm curious, are you planning on sending a new version soon? > If you want you can also just sent this patch with the last few > nitpicks (primarily the mail address) fixed and I'll happily apply. (I think this was stuck somewhere in moderation, only showed up just now) I was waiting for the testing result for the habana driver from Oded, but I guess Oded was waiting for v3. Hence the delay. Cheers, Daniel > = > Best regards, > Niklas Schnelle > = > On 10/12/20 4:19 PM, Daniel Vetter wrote: > > On Mon, Oct 12, 2020 at 04:03:28PM +0200, Niklas Schnelle wrote: > ... snip .... > >>> Cc: Jason Gunthorpe > >>> Cc: Dan Williams > >>> Cc: Kees Cook > >>> Cc: Andrew Morton > >>> Cc: John Hubbard > >>> Cc: J=E9r=F4me Glisse > >>> Cc: Jan Kara > >>> Cc: Dan Williams > >> > >> The above Cc: line for Dan Williams is a duplicate > >> > >>> Cc: linux-mm@kvack.org > >>> Cc: linux-arm-kernel@lists.infradead.org > >>> Cc: linux-samsung-soc@vger.kernel.org > >>> Cc: linux-media@vger.kernel.org > >>> Cc: Niklas Schnelle > >>> Cc: Gerald Schaefer > >>> Cc: linux-s390@vger.kernel.org > >>> -- > >>> v2: Move VM_IO | VM_PFNMAP checks around so they keep returning EINVAL > >>> like before (Gerard) > >> > >> I think the above should go before the CC/Signed-off/Reviewev block. > > = > > This is a per-subsystem bikeshed :-) drivers/gpu definitely wants it > > above, but most core subsystems want it below. I'll move it. > > = > >>> --- > >>> arch/s390/pci/pci_mmio.c | 98 +++++++++++++++++++++++---------------= -- > >>> 1 file changed, 57 insertions(+), 41 deletions(-) > >>> > >>> diff --git a/arch/s390/pci/pci_mmio.c b/arch/s390/pci/pci_mmio.c > >>> index 401cf670a243..1a6adbc68ee8 100644 > >>> --- a/arch/s390/pci/pci_mmio.c > >>> +++ b/arch/s390/pci/pci_mmio.c > >>> @@ -119,33 +119,15 @@ static inline int __memcpy_toio_inuser(void __i= omem *dst, > >>> return rc; > >>> } > >>> = > >>> -static long get_pfn(unsigned long user_addr, unsigned long access, > >>> - unsigned long *pfn) > >>> -{ > >>> - struct vm_area_struct *vma; > >>> - long ret; > >>> - > >>> - mmap_read_lock(current->mm); > >>> - ret =3D -EINVAL; > >>> - vma =3D find_vma(current->mm, user_addr); > >>> - if (!vma) > >>> - goto out; > >>> - ret =3D -EACCES; > >>> - if (!(vma->vm_flags & access)) > >>> - goto out; > >>> - ret =3D follow_pfn(vma, user_addr, pfn); > >>> -out: > >>> - mmap_read_unlock(current->mm); > >>> - return ret; > >>> -} > >>> - > >>> SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, mmio_addr, > >>> const void __user *, user_buffer, size_t, length) > >>> { > >>> u8 local_buf[64]; > >>> void __iomem *io_addr; > >>> void *buf; > >>> - unsigned long pfn; > >>> + struct vm_area_struct *vma; > >>> + pte_t *ptep; > >>> + spinlock_t *ptl; > >> > >> With checkpatch.pl --strict the above yields a complained > >> "CHECK: spinlock_t definition without comment" but I think > >> that's really okay since your commit description is very clear. > >> Same oin line 277. > > = > > I think this is a falls positive, checkpatch doesn't realize that > > SYSCALL_DEFINE3 is a function, not a structure. And in a structure I'd > > have added the kerneldoc or comment. > > = > > I'll fix up all the nits you've found for the next round. Thanks for > > taking a look. > > -Daniel > > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel