From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4CE7C388F9 for ; Fri, 23 Oct 2020 18:18:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DFA62192A for ; Fri, 23 Oct 2020 18:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603477125; bh=ylITAyPxL1iTJDK7oIOh/4MeeDKSIBOSRZU9Lcrcnl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=EWpClgxyrL56XfUHrTOwRJMK5NwThPi1BE6RW3c3hSKqBJAo1NQH63P/Hq2Mn7ce3 qSacSAlqQqVKmoU+VfRWRlYllVKaSHSpXV0J+sDWJL31ndTrqFXQTzNiJVuuc3/axR w/wFhlrN1heB26jNz4GJoKV8qFQ7rxD7gfMjRJAA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750127AbgJWSSo (ORCPT ); Fri, 23 Oct 2020 14:18:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:51100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750086AbgJWSSn (ORCPT ); Fri, 23 Oct 2020 14:18:43 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFBF6208E4; Fri, 23 Oct 2020 18:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603477123; bh=ylITAyPxL1iTJDK7oIOh/4MeeDKSIBOSRZU9Lcrcnl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sF864kXITXfnbH35wqTtEx/g7TDbHkqBfFTLfisF3CDHjRcDAiIVkY6wT6P9rRA8i i4lApyeRYlYtpeHsZsrGaWzpEfMvU7cb+yQmCLsUsCvWOPakqaNaUtGeLArl2DLSN3 Gu/U0Wscm7wjCw+HP5/try4AP8w+TOU74N8S4tt8= Date: Fri, 23 Oct 2020 11:18:41 -0700 From: Jakub Kicinski To: Hangbin Liu Cc: netdev@vger.kernel.org, Alexey Kuznetsov , Hideaki YOSHIFUJI , Eric Dumazet , "David S . Miller" , Willem de Bruijn Subject: Re: [PATCHv3 net 2/2] IPv6: reply ICMP error if the first fragment doesn't include all headers Message-ID: <20201023111841.5b0991cc@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201023064347.206431-3-liuhangbin@gmail.com> References: <20201021042005.736568-1-liuhangbin@gmail.com> <20201023064347.206431-1-liuhangbin@gmail.com> <20201023064347.206431-3-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 23 Oct 2020 14:43:47 +0800 Hangbin Liu wrote: > diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c > index ec448b71bf9a..0bda77d7e6b8 100644 > --- a/net/ipv6/icmp.c > +++ b/net/ipv6/icmp.c > @@ -145,6 +145,7 @@ static bool is_ineligible(const struct sk_buff *skb) > int ptr =3D (u8 *)(ipv6_hdr(skb) + 1) - skb->data; > int len =3D skb->len - ptr; > __u8 nexthdr =3D ipv6_hdr(skb)->nexthdr; > + unsigned int offs =3D 0; > __be16 frag_off; > =20 > if (len < 0) net/ipv6/icmp.c: In function =E2=80=98is_ineligible=E2=80=99: net/ipv6/icmp.c:148:15: warning: unused variable =E2=80=98offs=E2=80=99 [-W= unused-variable] 148 | unsigned int offs =3D 0; | ^~~~