From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kVxPr-0001UN-P2 for mharc-grub-devel@gnu.org; Fri, 23 Oct 2020 09:47:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVxPq-0001SF-He for grub-devel@gnu.org; Fri, 23 Oct 2020 09:47:34 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:49729) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1kVxPp-0004hB-1B for grub-devel@gnu.org; Fri, 23 Oct 2020 09:47:34 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:40450 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2051383AbgJWMOy (ORCPT ); Fri, 23 Oct 2020 14:14:54 +0200 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Fri, 23 Oct 2020 14:14:52 +0200 From: Daniel Kiper To: Glenn Washburn Cc: grub-devel@gnu.org, Patrick Steinhardt Subject: Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot. Message-ID: <20201023121452.pncn6i7i3yjkjnw2@tomti.i.net-space.pl> References: <20201009100122.GH2088@tanuki> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/23 09:47:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2020 13:47:34 -0000 On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote: > Introduce new variables keyslot_key, digest_key, and segment_key which > represent the integer key of the item in the respective associative array > when looping over the array items. This replaces using a generically > named variable named "idx" used for all three values. The parameter "i" > is renamed to "keyslot_idx" and the loop variable "j" is renamed to "i". > Error messages now distinguish between indexes and keys. The former > include "index" in the error string, and the later are surrounded in quotes. I think this patch does too many things in one step. Please do one rename per patch if possible. Additionally, I think this patch, or series of the patches, should be before current patch #1. Daniel