From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D124C4363A for ; Fri, 23 Oct 2020 16:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E935E241A3 for ; Fri, 23 Oct 2020 16:54:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=memsql.com header.i=@memsql.com header.b="XouObT07" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941AbgJWQyp (ORCPT ); Fri, 23 Oct 2020 12:54:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S461382AbgJWQyk (ORCPT ); Fri, 23 Oct 2020 12:54:40 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11D29C0613CE for ; Fri, 23 Oct 2020 09:54:39 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l20so937896wme.0 for ; Fri, 23 Oct 2020 09:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memsql.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K/qAKVNNr7wl3mXeW+C/WxE4lTp0V1uMbin6dmRbxag=; b=XouObT07eojqBuUiHvYdvMokjC72+Z+smBHV6j4LW5+m7y/km3e8ZUPzd7IDCXwXnh G8U2HJ/l+KsuHo2YciqnELix1fTIGXembfvZHz1B3klCGnR4oUWM9UBhKA1gcE7p2Lhg VaMrH7UYS8nDV5HwdKpjEx/tc0XdM2CKKVWiM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K/qAKVNNr7wl3mXeW+C/WxE4lTp0V1uMbin6dmRbxag=; b=LnnkdjxZ3L+0K6BvUpqbQF0zNmggZYWdWBbbSDEba9yF4FcB7x61pURS7iin8bV2om +/CGceahDOeBredRothbl5OpvPf22oGL3tKbmlwgqnA++q4crMbGGs7sp3b+cX4B13jY S4+NfgBkaqmXSDm8A9TF33RSOS0tiMSGpfM74rndA71Lx2NC03kV9m0TU8ahnbBHtGxb 5l6VNVq7NX5ldYm2DESDi7ZCUraAeepol6Bg/iSHi+2cAljAtEmAwcjF/054Lljy+6iI 4AkuvtBsHnodZQ8vfig1TbhaHcKS5LTPSyteYmYVVHridD60cjd15RO5VUWJ5mR1ECL2 Ne6Q== X-Gm-Message-State: AOAM531Wjb1zvs2ZCQEiUF4Xwl4jekrolcvW+FeOFzhEcFahpcKgIyUd 0v+814BL6V+XmcoQR38CAOO15Q== X-Google-Smtp-Source: ABdhPJyNrgrau3DojAcnXmQFDdSfdeIgU0ugIkZlGccaI9B0TbblNh6PPdoIjAl/fR7Y6IOufJYoXw== X-Received: by 2002:a7b:c349:: with SMTP id l9mr3235560wmj.148.1603472077767; Fri, 23 Oct 2020 09:54:37 -0700 (PDT) Received: from rdias-suse-pc.lan (bl13-26-148.dsl.telepac.pt. [85.246.26.148]) by smtp.gmail.com with ESMTPSA id c18sm4063228wmk.36.2020.10.23.09.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 09:54:37 -0700 (PDT) Date: Fri, 23 Oct 2020 17:54:35 +0100 From: Ricardo Dias To: Eric Dumazet Cc: David Miller , Jakub Kicinski , Alexey Kuznetsov , Hideaki YOSHIFUJI , netdev , LKML Subject: Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies Message-ID: <20201023165435.GA322147@rdias-suse-pc.lan> References: <20201023111352.GA289522@rdias-suse-pc.lan> <20201023155145.GA316015@rdias-suse-pc.lan> <20201023160628.GA316690@rdias-suse-pc.lan> <20201023164825.GA321826@rdias-suse-pc.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2020 at 06:51:05PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 6:48 PM Ricardo Dias wrote: > > > > > In that case, I can change the patch to only iterate the ehash bucket > > only when the listening socket is using the loopback interface, correct? > > No, the fix should be generic. > > We could still have bad NIC, or bad configuration, spreading packets > on random cpus ;) Ah, got it!