From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F80C4363A for ; Fri, 23 Oct 2020 18:11:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22A2F2168B for ; Fri, 23 Oct 2020 18:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754439AbgJWSLv (ORCPT ); Fri, 23 Oct 2020 14:11:51 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:51956 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754320AbgJWSLY (ORCPT ); Fri, 23 Oct 2020 14:11:24 -0400 Received: from relay8-d.mail.gandi.net (unknown [217.70.183.201]) by mslow2.mail.gandi.net (Postfix) with ESMTP id C3B643B09B3; Fri, 23 Oct 2020 17:47:00 +0000 (UTC) X-Originating-IP: 93.29.109.196 Received: from localhost.localdomain (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 02EB11BF203; Fri, 23 Oct 2020 17:46:37 +0000 (UTC) From: Paul Kocialkowski To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-sunxi@googlegroups.com Cc: Mauro Carvalho Chehab , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Yong Deng , Kishon Vijay Abraham I , Vinod Koul , Helen Koike , Greg Kroah-Hartman , Philipp Zabel , Paul Kocialkowski , Hans Verkuil , Sakari Ailus , Thomas Petazzoni , Hans Verkuil , kevin.lhopital@hotmail.com Subject: [PATCH 14/14] media: sunxi: sun8i-a83t-mipi-csi2: Avoid using the (unsolicited) interrupt Date: Fri, 23 Oct 2020 19:45:46 +0200 Message-Id: <20201023174546.504028-15-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201023174546.504028-1-paul.kocialkowski@bootlin.com> References: <20201023174546.504028-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The A83T MIPI CSI-2 apparently produces interrupts regardless of the mask registers, for example when a transmission error occurs. This generates quite a flood when unsolicited interrupts are received on each received frame. As a result, disable the interrupt for now since we are not currently using it for error reporting. Signed-off-by: Paul Kocialkowski --- .../sun8i_a83t_mipi_csi2.c | 40 ------------------- 1 file changed, 40 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c index 1ff6f5dfd81a..26af3e3f5f89 100644 --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c @@ -25,34 +25,6 @@ /* Core */ -static irqreturn_t sun8i_a83t_mipi_csi2_isr(int irq, void *dev_id) -{ - struct sun8i_a83t_mipi_csi2_dev *cdev = - (struct sun8i_a83t_mipi_csi2_dev *)dev_id; - struct regmap *regmap = cdev->regmap; - u32 status; - - WARN_ONCE(1, MODULE_NAME - ": Unsolicited interrupt, an error likely occurred!\n"); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA0_REG, &status); - regmap_write(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA0_REG, status); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA1_REG, &status); - regmap_write(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA1_REG, status); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_MSK0_REG, &status); - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_MSK1_REG, &status); - - /* - * The interrupt can be used to catch transmission errors. - * However, we currently lack plumbing for reporting that to the - * A31 CSI controller driver. - */ - - return IRQ_HANDLED; -} - static void sun8i_a83t_mipi_csi2_init(struct sun8i_a83t_mipi_csi2_dev *cdev) { struct regmap *regmap = cdev->regmap; @@ -587,7 +559,6 @@ static int sun8i_a83t_mipi_csi2_resource_request(struct sun8i_a83t_mipi_csi2_dev { struct resource *res; void __iomem *io_base; - int irq; int ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -626,17 +597,6 @@ static int sun8i_a83t_mipi_csi2_resource_request(struct sun8i_a83t_mipi_csi2_dev return PTR_ERR(cdev->reset); } - irq = platform_get_irq(pdev, 0); - if (irq < 0) - return -ENXIO; - - ret = devm_request_irq(&pdev->dev, irq, sun8i_a83t_mipi_csi2_isr, 0, - MODULE_NAME, cdev); - if (ret) { - dev_err(&pdev->dev, "failed to request MIPI CSI-2 IRQ\n"); - return ret; - } - ret = sun8i_a83t_dphy_register(cdev); if (ret) { dev_err(&pdev->dev, "failed to init MIPI D-PHY\n"); -- 2.28.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FF1C388F9 for ; Fri, 23 Oct 2020 17:46:53 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6029621527 for ; Fri, 23 Oct 2020 17:46:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6029621527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1E18E87432; Fri, 23 Oct 2020 17:46:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xmBHpeaPkwTn; Fri, 23 Oct 2020 17:46:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 546D88742A; Fri, 23 Oct 2020 17:46:46 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id BCED11BF3CC for ; Fri, 23 Oct 2020 17:46:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B995B876FC for ; Fri, 23 Oct 2020 17:46:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZEyZWe-DRAhP for ; Fri, 23 Oct 2020 17:46:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by whitealder.osuosl.org (Postfix) with ESMTPS id 1589F876C7 for ; Fri, 23 Oct 2020 17:46:40 +0000 (UTC) X-Originating-IP: 93.29.109.196 Received: from localhost.localdomain (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 02EB11BF203; Fri, 23 Oct 2020 17:46:37 +0000 (UTC) From: Paul Kocialkowski To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-sunxi@googlegroups.com Subject: [PATCH 14/14] media: sunxi: sun8i-a83t-mipi-csi2: Avoid using the (unsolicited) interrupt Date: Fri, 23 Oct 2020 19:45:46 +0200 Message-Id: <20201023174546.504028-15-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201023174546.504028-1-paul.kocialkowski@bootlin.com> References: <20201023174546.504028-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hans Verkuil , Philipp Zabel , Thomas Petazzoni , Greg Kroah-Hartman , Helen Koike , Vinod Koul , Maxime Ripard , Kishon Vijay Abraham I , Paul Kocialkowski , Chen-Yu Tsai , Rob Herring , Hans Verkuil , Yong Deng , Sakari Ailus , Mauro Carvalho Chehab , kevin.lhopital@hotmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" The A83T MIPI CSI-2 apparently produces interrupts regardless of the mask registers, for example when a transmission error occurs. This generates quite a flood when unsolicited interrupts are received on each received frame. As a result, disable the interrupt for now since we are not currently using it for error reporting. Signed-off-by: Paul Kocialkowski --- .../sun8i_a83t_mipi_csi2.c | 40 ------------------- 1 file changed, 40 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c index 1ff6f5dfd81a..26af3e3f5f89 100644 --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c @@ -25,34 +25,6 @@ /* Core */ -static irqreturn_t sun8i_a83t_mipi_csi2_isr(int irq, void *dev_id) -{ - struct sun8i_a83t_mipi_csi2_dev *cdev = - (struct sun8i_a83t_mipi_csi2_dev *)dev_id; - struct regmap *regmap = cdev->regmap; - u32 status; - - WARN_ONCE(1, MODULE_NAME - ": Unsolicited interrupt, an error likely occurred!\n"); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA0_REG, &status); - regmap_write(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA0_REG, status); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA1_REG, &status); - regmap_write(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA1_REG, status); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_MSK0_REG, &status); - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_MSK1_REG, &status); - - /* - * The interrupt can be used to catch transmission errors. - * However, we currently lack plumbing for reporting that to the - * A31 CSI controller driver. - */ - - return IRQ_HANDLED; -} - static void sun8i_a83t_mipi_csi2_init(struct sun8i_a83t_mipi_csi2_dev *cdev) { struct regmap *regmap = cdev->regmap; @@ -587,7 +559,6 @@ static int sun8i_a83t_mipi_csi2_resource_request(struct sun8i_a83t_mipi_csi2_dev { struct resource *res; void __iomem *io_base; - int irq; int ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -626,17 +597,6 @@ static int sun8i_a83t_mipi_csi2_resource_request(struct sun8i_a83t_mipi_csi2_dev return PTR_ERR(cdev->reset); } - irq = platform_get_irq(pdev, 0); - if (irq < 0) - return -ENXIO; - - ret = devm_request_irq(&pdev->dev, irq, sun8i_a83t_mipi_csi2_isr, 0, - MODULE_NAME, cdev); - if (ret) { - dev_err(&pdev->dev, "failed to request MIPI CSI-2 IRQ\n"); - return ret; - } - ret = sun8i_a83t_dphy_register(cdev); if (ret) { dev_err(&pdev->dev, "failed to init MIPI D-PHY\n"); -- 2.28.0 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBFDDC4363A for ; Fri, 23 Oct 2020 17:50:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D78421582 for ; Fri, 23 Oct 2020 17:50:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wAC8cKoh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D78421582 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mjTjG6g8ph8wE1m2ULmJpNu0/SJBUGSjOYzTfcgHi+4=; b=wAC8cKoh9v1qg1ciYlkIfDaRg l/37Na6RG+UyMw7IvKZ2rg1hxNO3PbEH8tXWoq8j8S82mQHxvb/LvLidoBKc49f29VXphwIjeeR4k M5MtFW4O2fjJpOsrzl7uYieHMsKcXMGtELnf5yNmo2ig6YD0Vnm5Jsi+b3YXLQ34PoS7Qyn8oLvFv AIroKLXhucxJO6PZHlojDbCtiT2+2iJp1b+a7vQRVhdNIq5YQlsVUWzgPpcuUrhQHn7A4Oml7jfLq LHUX3nmLnRYQGRigC4il2xC2JjAEyLdROB/btbxuo0SDOUDBqJthOqa+6OIf5PjhfUwbSdgLU9pNr qAEiAtC9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kW1B6-0001oT-D4; Fri, 23 Oct 2020 17:48:36 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kW19E-0000vT-Ip for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 17:46:49 +0000 X-Originating-IP: 93.29.109.196 Received: from localhost.localdomain (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 02EB11BF203; Fri, 23 Oct 2020 17:46:37 +0000 (UTC) From: Paul Kocialkowski To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-sunxi@googlegroups.com Subject: [PATCH 14/14] media: sunxi: sun8i-a83t-mipi-csi2: Avoid using the (unsolicited) interrupt Date: Fri, 23 Oct 2020 19:45:46 +0200 Message-Id: <20201023174546.504028-15-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201023174546.504028-1-paul.kocialkowski@bootlin.com> References: <20201023174546.504028-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_134640_958540_A2CDC76D X-CRM114-Status: GOOD ( 15.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hans Verkuil , Philipp Zabel , Thomas Petazzoni , Greg Kroah-Hartman , Helen Koike , Vinod Koul , Maxime Ripard , Kishon Vijay Abraham I , Paul Kocialkowski , Chen-Yu Tsai , Rob Herring , Hans Verkuil , Yong Deng , Sakari Ailus , Mauro Carvalho Chehab , kevin.lhopital@hotmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The A83T MIPI CSI-2 apparently produces interrupts regardless of the mask registers, for example when a transmission error occurs. This generates quite a flood when unsolicited interrupts are received on each received frame. As a result, disable the interrupt for now since we are not currently using it for error reporting. Signed-off-by: Paul Kocialkowski --- .../sun8i_a83t_mipi_csi2.c | 40 ------------------- 1 file changed, 40 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c index 1ff6f5dfd81a..26af3e3f5f89 100644 --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c @@ -25,34 +25,6 @@ /* Core */ -static irqreturn_t sun8i_a83t_mipi_csi2_isr(int irq, void *dev_id) -{ - struct sun8i_a83t_mipi_csi2_dev *cdev = - (struct sun8i_a83t_mipi_csi2_dev *)dev_id; - struct regmap *regmap = cdev->regmap; - u32 status; - - WARN_ONCE(1, MODULE_NAME - ": Unsolicited interrupt, an error likely occurred!\n"); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA0_REG, &status); - regmap_write(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA0_REG, status); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA1_REG, &status); - regmap_write(regmap, SUN8I_A83T_MIPI_CSI2_INT_STA1_REG, status); - - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_MSK0_REG, &status); - regmap_read(regmap, SUN8I_A83T_MIPI_CSI2_INT_MSK1_REG, &status); - - /* - * The interrupt can be used to catch transmission errors. - * However, we currently lack plumbing for reporting that to the - * A31 CSI controller driver. - */ - - return IRQ_HANDLED; -} - static void sun8i_a83t_mipi_csi2_init(struct sun8i_a83t_mipi_csi2_dev *cdev) { struct regmap *regmap = cdev->regmap; @@ -587,7 +559,6 @@ static int sun8i_a83t_mipi_csi2_resource_request(struct sun8i_a83t_mipi_csi2_dev { struct resource *res; void __iomem *io_base; - int irq; int ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -626,17 +597,6 @@ static int sun8i_a83t_mipi_csi2_resource_request(struct sun8i_a83t_mipi_csi2_dev return PTR_ERR(cdev->reset); } - irq = platform_get_irq(pdev, 0); - if (irq < 0) - return -ENXIO; - - ret = devm_request_irq(&pdev->dev, irq, sun8i_a83t_mipi_csi2_isr, 0, - MODULE_NAME, cdev); - if (ret) { - dev_err(&pdev->dev, "failed to request MIPI CSI-2 IRQ\n"); - return ret; - } - ret = sun8i_a83t_dphy_register(cdev); if (ret) { dev_err(&pdev->dev, "failed to init MIPI D-PHY\n"); -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel