From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF92CC56201 for ; Sat, 24 Oct 2020 15:44:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A76AF22254 for ; Sat, 24 Oct 2020 15:44:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kvnx4TOK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762059AbgJXPoa (ORCPT ); Sat, 24 Oct 2020 11:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756857AbgJXPo3 (ORCPT ); Sat, 24 Oct 2020 11:44:29 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2922AC0613CE; Sat, 24 Oct 2020 08:44:29 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id h20so4875395lji.9; Sat, 24 Oct 2020 08:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iVvngnWeIDGhbxLx06m+FoOELtVvu4vONgAX93A/tXY=; b=kvnx4TOKigpxlEKazViL6WLSKKrbU0dOmb5zHP7dZbPHHdved9KAw96ScO0YXfUbBL GWMcOZvfKBSte7uOI8XI+79DsSEDU+kukxn/3vHWgEJrM397fkjibfcIczl9akmjgoII XwGNe7impjNc3/qRrYCgpprD0BDRXXPjYBPnZjF9Qgp/cHwOBebv/QCnoYNh3y3RWTzP 41HwRVcWSBJ4ojwoRWAMt/zZYBpN7UcTuoFJQe0bl42A83RmUNmDnihz18wCpUx1Av// mD0S0NHOQpzevaYzpcSIGNTViExTnluNLcOqoeL3JonjEVjRVKI8Cwzi9/5MtGCmEqXN 3myg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iVvngnWeIDGhbxLx06m+FoOELtVvu4vONgAX93A/tXY=; b=HqAmHaLgOvf8THcbS2kLNpzBMHM7EimI0z86qShhw1z9PfJVQ+kCe9R9/V3xhoCM0B wPKhmERvoooG3SHOdHt9/imgV5bf3Z2hQJjhkVDklzHCTbf3GQzHXOU+sTaontKYDfGj B0r6VyAlFlH8MJDLnuvCmu6LijtA3JMbHEtj18/kQBTUapgdja6ahtGAwriWOYke9K1V XJp/3d75qZRwbLkQARBHsMo2ZuVJBb7DhWsaGXdr7KOgWu44mtAlciG1wwO4nxkvIP1T 9K27xIDZrB7n5C66ekHP01JtxhqhjmrtswQgj33FDAdpcB3doey1iNkjsLz5iI6tA53f OSQw== X-Gm-Message-State: AOAM530QzFlhQuzuFFJivuJ50rfTjjixFFRPrJ5IzIkcmY2vdxFRQuzV phFGcfvRuW+fokpc36rzG7Z0alt3/48= X-Google-Smtp-Source: ABdhPJz/klHWcs3bRbKDkYASeDigVNP3nTTs5rtGYA7UaR3O9h/X1CTwcak2v4Vg9hMKBIhvW+fi3w== X-Received: by 2002:a2e:87cd:: with SMTP id v13mr2689614ljj.146.1603554266621; Sat, 24 Oct 2020 08:44:26 -0700 (PDT) Received: from localhost.localdomain ([2a02:a315:5445:5300:e9e3:358e:a790:ce1c]) by smtp.googlemail.com with ESMTPSA id 76sm472536lfn.128.2020.10.24.08.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2020 08:44:25 -0700 (PDT) From: =?UTF-8?q?Pawe=C5=82=20Chmiel?= To: kgene@kernel.org, krzk@kernel.org, mturquette@baylibre.com, sboyd@kernel.org Cc: s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Pawe=C5=82=20Chmiel?= Subject: [PATCH] clk: exynos7: Mark aclk_fsys1_200 as critical Date: Sat, 24 Oct 2020 17:43:46 +0200 Message-Id: <20201024154346.9589-1-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This clock must be always enabled to allow access to any registers in fsys1 CMU. Until proper solution based on runtime PM is applied (similar to what was done for Exynos5433), mark that clock as critical so it won't be disabled. It was observed on Samsung Galaxy S6 device (based on Exynos7420), where UFS module is probed before pmic used to power that device. In this case defer probe was happening and that clock was disabled by UFS driver, causing whole boot to hang on next CMU access. Signed-off-by: Paweł Chmiel --- drivers/clk/samsung/clk-exynos7.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-exynos7.c b/drivers/clk/samsung/clk-exynos7.c index c1ff715e960c..1048d83f097b 100644 --- a/drivers/clk/samsung/clk-exynos7.c +++ b/drivers/clk/samsung/clk-exynos7.c @@ -538,7 +538,8 @@ static const struct samsung_gate_clock top1_gate_clks[] __initconst = { ENABLE_ACLK_TOP13, 28, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL, 0), GATE(CLK_ACLK_FSYS1_200, "aclk_fsys1_200", "dout_aclk_fsys1_200", - ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT, 0), + ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT | + CLK_IS_CRITICAL, 0), GATE(CLK_SCLK_PHY_FSYS1_26M, "sclk_phy_fsys1_26m", "dout_sclk_phy_fsys1_26m", ENABLE_SCLK_TOP1_FSYS11, -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DB3C2D0A3 for ; Sat, 24 Oct 2020 15:46:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD31622254 for ; Sat, 24 Oct 2020 15:46:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PycwXkgt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kvnx4TOK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD31622254 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=7tTwe84bjogC0rEz2xcGeSVHwhkMDXRbjpnPZ8wD3Ok=; b=PycwXkgtdE5o55kQ1XG0hL0dBX FEVdlCGvzwcpj3GvHczU6e6gzakvWf1WBNOAz98t68wG4d13yWCVB7jIisxErgLSMnBgf/WvWJe8W a7Jhmc5DtwHFxV5PvMedXpTE0uxBMXUkwtrk6GmuoRC5FDXOWgwPrsn3jYzM1fg+8jC/zOYlquZiY mKHgQdjd31PIjRW0n6yGfE/qbhjIeOjuGPvgTTxfwpy0ZlNPb09rcY2N4zwtm1bP7a0Cm4XNd3xp1 ky3FsFvjmrFL7kyY5GVDmPt7QJTUZ3qdqyQC/nDr89U9L5RKxBOlLj72p2B2mREIIB9qUf/KaKIDv 6nM0N9OQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWLia-0000Rp-8S; Sat, 24 Oct 2020 15:44:32 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWLiX-0000QY-N8 for linux-arm-kernel@lists.infradead.org; Sat, 24 Oct 2020 15:44:31 +0000 Received: by mail-lj1-x243.google.com with SMTP id m20so4882746ljj.5 for ; Sat, 24 Oct 2020 08:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iVvngnWeIDGhbxLx06m+FoOELtVvu4vONgAX93A/tXY=; b=kvnx4TOKigpxlEKazViL6WLSKKrbU0dOmb5zHP7dZbPHHdved9KAw96ScO0YXfUbBL GWMcOZvfKBSte7uOI8XI+79DsSEDU+kukxn/3vHWgEJrM397fkjibfcIczl9akmjgoII XwGNe7impjNc3/qRrYCgpprD0BDRXXPjYBPnZjF9Qgp/cHwOBebv/QCnoYNh3y3RWTzP 41HwRVcWSBJ4ojwoRWAMt/zZYBpN7UcTuoFJQe0bl42A83RmUNmDnihz18wCpUx1Av// mD0S0NHOQpzevaYzpcSIGNTViExTnluNLcOqoeL3JonjEVjRVKI8Cwzi9/5MtGCmEqXN 3myg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iVvngnWeIDGhbxLx06m+FoOELtVvu4vONgAX93A/tXY=; b=Esp7dGtG/9qh3ylbC60THDPNNRMHlqPtTKDJt6WTuoDT+DGuY8qn8m/5pH+hHdV+AG mA0T5deJfWqieBaGvq10ovPjDpSGgyngDPdcM65/XfHpDW/rma6CGXuWRG8f7KPX3ABy nUqeMP7MEPAY3vcWFGM+t3FHyZAX8g/NTSwc2wty3lOggWcsBjcoQsmScn/hCgEdgnLi rHC6qbqcr4r3abcCu7J/5WzwNenNRdnQTisFbOh3wYI8O9ZtBEw0w8fFH55mBXzWtwXy 3l/KBtc4OJwklrWSea7XtT62g7p2ZlQLnDAba7B09vPpxULds+Nge6Tu3hKoc2IDpntS SoCA== X-Gm-Message-State: AOAM532hmfAj5tVrwNy3UvXKLGfC/mhrCNSRXfVRqPM3gGgBNKjmCLoO K/yKrAgBrglfTpGTknUDf7g= X-Google-Smtp-Source: ABdhPJz/klHWcs3bRbKDkYASeDigVNP3nTTs5rtGYA7UaR3O9h/X1CTwcak2v4Vg9hMKBIhvW+fi3w== X-Received: by 2002:a2e:87cd:: with SMTP id v13mr2689614ljj.146.1603554266621; Sat, 24 Oct 2020 08:44:26 -0700 (PDT) Received: from localhost.localdomain ([2a02:a315:5445:5300:e9e3:358e:a790:ce1c]) by smtp.googlemail.com with ESMTPSA id 76sm472536lfn.128.2020.10.24.08.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2020 08:44:25 -0700 (PDT) From: =?UTF-8?q?Pawe=C5=82=20Chmiel?= To: kgene@kernel.org, krzk@kernel.org, mturquette@baylibre.com, sboyd@kernel.org Subject: [PATCH] clk: exynos7: Mark aclk_fsys1_200 as critical Date: Sat, 24 Oct 2020 17:43:46 +0200 Message-Id: <20201024154346.9589-1-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201024_114429_926429_0516F5A0 X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, tomasz.figa@gmail.com, linux-kernel@vger.kernel.org, cw00.choi@samsung.com, s.nawrocki@samsung.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Pawe=C5=82=20Chmiel?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhpcyBjbG9jayBtdXN0IGJlIGFsd2F5cyBlbmFibGVkIHRvIGFsbG93IGFjY2VzcyB0byBhbnkg cmVnaXN0ZXJzIGluCmZzeXMxIENNVS4gVW50aWwgcHJvcGVyIHNvbHV0aW9uIGJhc2VkIG9uIHJ1 bnRpbWUgUE0gaXMgYXBwbGllZAooc2ltaWxhciB0byB3aGF0IHdhcyBkb25lIGZvciBFeHlub3M1 NDMzKSwgbWFyayB0aGF0IGNsb2NrIGFzIGNyaXRpY2FsCnNvIGl0IHdvbid0IGJlIGRpc2FibGVk LgoKSXQgd2FzIG9ic2VydmVkIG9uIFNhbXN1bmcgR2FsYXh5IFM2IGRldmljZSAoYmFzZWQgb24g RXh5bm9zNzQyMCksIHdoZXJlClVGUyBtb2R1bGUgaXMgcHJvYmVkIGJlZm9yZSBwbWljIHVzZWQg dG8gcG93ZXIgdGhhdCBkZXZpY2UuCkluIHRoaXMgY2FzZSBkZWZlciBwcm9iZSB3YXMgaGFwcGVu aW5nIGFuZCB0aGF0IGNsb2NrIHdhcyBkaXNhYmxlZCBieQpVRlMgZHJpdmVyLCBjYXVzaW5nIHdo b2xlIGJvb3QgdG8gaGFuZyBvbiBuZXh0IENNVSBhY2Nlc3MuCgpTaWduZWQtb2ZmLWJ5OiBQYXdl xYIgQ2htaWVsIDxwYXdlbC5taWtvbGFqLmNobWllbEBnbWFpbC5jb20+Ci0tLQogZHJpdmVycy9j bGsvc2Ftc3VuZy9jbGstZXh5bm9zNy5jIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2Nsay9zYW1zdW5n L2Nsay1leHlub3M3LmMgYi9kcml2ZXJzL2Nsay9zYW1zdW5nL2Nsay1leHlub3M3LmMKaW5kZXgg YzFmZjcxNWU5NjBjLi4xMDQ4ZDgzZjA5N2IgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvY2xrL3NhbXN1 bmcvY2xrLWV4eW5vczcuYworKysgYi9kcml2ZXJzL2Nsay9zYW1zdW5nL2Nsay1leHlub3M3LmMK QEAgLTUzOCw3ICs1MzgsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHNhbXN1bmdfZ2F0ZV9jbG9j ayB0b3AxX2dhdGVfY2xrc1tdIF9faW5pdGNvbnN0ID0gewogCQlFTkFCTEVfQUNMS19UT1AxMywg MjgsIENMS19TRVRfUkFURV9QQVJFTlQgfAogCQlDTEtfSVNfQ1JJVElDQUwsIDApLAogCUdBVEUo Q0xLX0FDTEtfRlNZUzFfMjAwLCAiYWNsa19mc3lzMV8yMDAiLCAiZG91dF9hY2xrX2ZzeXMxXzIw MCIsCi0JCUVOQUJMRV9BQ0xLX1RPUDEzLCAyNCwgQ0xLX1NFVF9SQVRFX1BBUkVOVCwgMCksCisJ CUVOQUJMRV9BQ0xLX1RPUDEzLCAyNCwgQ0xLX1NFVF9SQVRFX1BBUkVOVCB8CisJCUNMS19JU19D UklUSUNBTCwgMCksCiAKIAlHQVRFKENMS19TQ0xLX1BIWV9GU1lTMV8yNk0sICJzY2xrX3BoeV9m c3lzMV8yNm0iLAogCQkiZG91dF9zY2xrX3BoeV9mc3lzMV8yNm0iLCBFTkFCTEVfU0NMS19UT1Ax X0ZTWVMxMSwKLS0gCjIuMjUuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK