* [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia
@ 2020-10-25 11:49 Bernd Kuhls
2020-10-25 14:53 ` Thomas Petazzoni
2020-10-26 21:05 ` Thomas Petazzoni
0 siblings, 2 replies; 7+ messages in thread
From: Bernd Kuhls @ 2020-10-25 11:49 UTC (permalink / raw)
To: buildroot
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +-
package/kodi-texturepacker/kodi-texturepacker.mk | 2 +-
package/kodi/kodi.hash | 2 +-
package/kodi/kodi.mk | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk b/package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk
index 7d0772fb78..2c7f77d050 100644
--- a/package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk
+++ b/package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk
@@ -6,7 +6,7 @@
# Not possible to directly refer to kodi variables, because of
# first/second expansion trickery...
-KODI_JSONSCHEMABUILDER_VERSION = 18.8-Leia
+KODI_JSONSCHEMABUILDER_VERSION = 18.9-Leia
KODI_JSONSCHEMABUILDER_SITE = $(call github,xbmc,xbmc,$(KODI_JSONSCHEMABUILDER_VERSION))
KODI_JSONSCHEMABUILDER_SOURCE = kodi-$(KODI_JSONSCHEMABUILDER_VERSION).tar.gz
KODI_JSONSCHEMABUILDER_DL_SUBDIR = kodi
diff --git a/package/kodi-texturepacker/kodi-texturepacker.mk b/package/kodi-texturepacker/kodi-texturepacker.mk
index c83cc3165e..7b13904ef4 100644
--- a/package/kodi-texturepacker/kodi-texturepacker.mk
+++ b/package/kodi-texturepacker/kodi-texturepacker.mk
@@ -6,7 +6,7 @@
# Not possible to directly refer to kodi variables, because of
# first/second expansion trickery...
-KODI_TEXTUREPACKER_VERSION = 18.8-Leia
+KODI_TEXTUREPACKER_VERSION = 18.9-Leia
KODI_TEXTUREPACKER_SITE = $(call github,xbmc,xbmc,$(KODI_TEXTUREPACKER_VERSION))
KODI_TEXTUREPACKER_SOURCE = kodi-$(KODI_TEXTUREPACKER_VERSION).tar.gz
KODI_TEXTUREPACKER_DL_SUBDIR = kodi
diff --git a/package/kodi/kodi.hash b/package/kodi/kodi.hash
index 06a33efa85..545f87909f 100644
--- a/package/kodi/kodi.hash
+++ b/package/kodi/kodi.hash
@@ -1,5 +1,5 @@
# Locally computed
-sha256 6deb28f725880b1ab6c5920b55ef1190a79b0684ffb30b6e13b199d23a0af296 kodi-18.8-Leia.tar.gz
+sha256 bdf8afa9356b1f815de9984801d3e0d2b46a719e747895b75528f20995c59d2b kodi-18.9-Leia.tar.gz
sha256 e11e7594af35f36ab2711252c3d6bb106908f26605498aef4a9be2d7bc001db2 kodi-ffmpeg-4.0.4-Leia-18.4.tar.gz
sha256 38816f8373e243bc5950449b4f3b18938c4e1c59348e3411e23f31db4072e40d kodi-libdvdcss-1.4.2-Leia-Beta-5.tar.gz
sha256 071e414e61b795f2ff9015b21a85fc009dde967f27780d23092643916538a57a kodi-libdvdnav-6.0.0-Leia-Alpha-3.tar.gz
diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index d8144c0c38..80a8d4e6bf 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -6,7 +6,7 @@
# When updating the version, please also update kodi-jsonschemabuilder
# and kodi-texturepacker
-KODI_VERSION = 18.8-Leia
+KODI_VERSION = 18.9-Leia
KODI_SITE = $(call github,xbmc,xbmc,$(KODI_VERSION))
KODI_LICENSE = GPL-2.0
KODI_LICENSE_FILES = LICENSE.md
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia
2020-10-25 11:49 [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia Bernd Kuhls
@ 2020-10-25 14:53 ` Thomas Petazzoni
2020-10-25 15:02 ` Bernd Kuhls
2020-10-26 21:05 ` Thomas Petazzoni
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2020-10-25 14:53 UTC (permalink / raw)
To: buildroot
On Sun, 25 Oct 2020 12:49:59 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +-
> package/kodi-texturepacker/kodi-texturepacker.mk | 2 +-
You are changing the version of those packages, without updating their
hash files. This doesn't seem right.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia
2020-10-25 14:53 ` Thomas Petazzoni
@ 2020-10-25 15:02 ` Bernd Kuhls
2020-10-26 21:04 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Bernd Kuhls @ 2020-10-25 15:02 UTC (permalink / raw)
To: buildroot
Am Sun, 25 Oct 2020 15:53:38 +0100 schrieb Thomas Petazzoni:
>> package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +-
>> package/kodi-texturepacker/kodi-texturepacker.mk | 2 +-
>
> You are changing the version of those packages, without updating their
> hash files. This doesn't seem right.
Hi Thomas,
both .hash files are links to ../kodi/kodi.hash
Regards, Bernd
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia
2020-10-25 15:02 ` Bernd Kuhls
@ 2020-10-26 21:04 ` Thomas Petazzoni
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2020-10-26 21:04 UTC (permalink / raw)
To: buildroot
On Sun, 25 Oct 2020 16:02:39 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> both .hash files are links to ../kodi/kodi.hash
Ah, yes, indeed, sorry about missing that. I've applied now.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia
2020-10-25 11:49 [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia Bernd Kuhls
2020-10-25 14:53 ` Thomas Petazzoni
@ 2020-10-26 21:05 ` Thomas Petazzoni
2020-10-26 21:23 ` Yann E. MORIN
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2020-10-26 21:05 UTC (permalink / raw)
To: buildroot
Hello Bernd,
On Sun, 25 Oct 2020 12:49:59 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +-
> package/kodi-texturepacker/kodi-texturepacker.mk | 2 +-
> package/kodi/kodi.hash | 2 +-
> package/kodi/kodi.mk | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
Applied to master, thanks. Do you know why we have separate
kodi-texturepacker/kodi-jsconschemabuilder packages instead of having a
host-kodi package that would just build those two tools out of the Kodi
code base ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia
2020-10-26 21:05 ` Thomas Petazzoni
@ 2020-10-26 21:23 ` Yann E. MORIN
2020-10-27 8:29 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2020-10-26 21:23 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-10-26 22:05 +0100, Thomas Petazzoni spake thusly:
> On Sun, 25 Oct 2020 12:49:59 +0100
> Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> > ---
> > package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +-
> > package/kodi-texturepacker/kodi-texturepacker.mk | 2 +-
> > package/kodi/kodi.hash | 2 +-
> > package/kodi/kodi.mk | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
>
> Applied to master, thanks. Do you know why we have separate
> kodi-texturepacker/kodi-jsconschemabuilder packages instead of having a
> host-kodi package that would just build those two tools out of the Kodi
> code base ?
I guess there is a bit of "historical reasons" behind it.
However, there is a good technical reason: our package infrastructure
can only build in one FOO_SUBDIR per pacakge, but here we have two:
- tools/depends/native/JsonSchemaBuilder/
- tools/depends/native/TexturePacker/
Regards,
Yann E. MORIN.
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia
2020-10-26 21:23 ` Yann E. MORIN
@ 2020-10-27 8:29 ` Thomas Petazzoni
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2020-10-27 8:29 UTC (permalink / raw)
To: buildroot
On Mon, 26 Oct 2020 22:23:52 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> I guess there is a bit of "historical reasons" behind it.
>
> However, there is a good technical reason: our package infrastructure
> can only build in one FOO_SUBDIR per pacakge, but here we have two:
>
> - tools/depends/native/JsonSchemaBuilder/
> - tools/depends/native/TexturePacker/
Indeed. After a quick look, I thought this could be solved simply with
a custom BUILD_CMDS that invokes make in those two folders. But it's
more complicated: we would need a custom configure cmd that also calls
CMake in those two folders.
So, meh: what we have today is probably reasonable.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-27 8:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-25 11:49 [Buildroot] [PATCH 1/1] package/kodi: bump version to 18.9-Leia Bernd Kuhls
2020-10-25 14:53 ` Thomas Petazzoni
2020-10-25 15:02 ` Bernd Kuhls
2020-10-26 21:04 ` Thomas Petazzoni
2020-10-26 21:05 ` Thomas Petazzoni
2020-10-26 21:23 ` Yann E. MORIN
2020-10-27 8:29 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.