From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD927C2D0A3 for ; Mon, 26 Oct 2020 18:52:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F1762168B for ; Mon, 26 Oct 2020 18:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603738361; bh=t2EQbcyl5c3xdLTzNkFpT08fzGpuuYyPqlb0/xDd3r4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=OVtvx2+OQR+4wrJTB7HNzDZZYp0pR5fnIhGnLSTBxkPVw9jM7fkLwCHpu71/FBrbw NcmqDoibfcaC2ls96pp37GeTEZc6uvZ2lCPHDoRUzQBzBKNinPkiMlSc53KPSjTTBd 0ZaYqg9U1cedNePYiSTJ/Xx/CutXTKcREhqnCGU4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1790481AbgJZSwj (ORCPT ); Mon, 26 Oct 2020 14:52:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:42836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1790466AbgJZSwj (ORCPT ); Mon, 26 Oct 2020 14:52:39 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1FB9207E8; Mon, 26 Oct 2020 18:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603738359; bh=t2EQbcyl5c3xdLTzNkFpT08fzGpuuYyPqlb0/xDd3r4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JckPPeS6Q4j3QYgNH76zNGhEI+P2JRsz0T+do+ZJ0jXBaGM/h3iWH2jzj+1PmQ4yh qsl/JLRqufoBVgCw8TWFwiDAnMyBF0gzRXIKT8uv0Gm8e5QCTQZuBT9ARs90+bIeoM jA3gBYtw+K4gukXB97CGMg0jaj6i8HzU5aol5USc= Date: Mon, 26 Oct 2020 11:52:37 -0700 From: Jakub Kicinski To: Michal Suchanek Cc: Thomas Bogendoerfer , netdev@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Cristobal Forno , "David S. Miller" , Cris Forno , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge. Message-ID: <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201026104221.26570-1-msuchanek@suse.de> References: <20201026104221.26570-1-msuchanek@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > From: Thomas Bogendoerfer > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > but now suppresses bridged frames, which are accepted by the hypervisor > otherwise bridging won't work at all. > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > Signed-off-by: Michal Suchanek Since the From: line says Thomas we need a signoff from him. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B880C4363A for ; Mon, 26 Oct 2020 18:57:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FB50207E8 for ; Mon, 26 Oct 2020 18:57:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JckPPeS6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FB50207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CKkbM5KJrzDqPj for ; Tue, 27 Oct 2020 05:57:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=kuba@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=JckPPeS6; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CKkVL1d4TzDqDX for ; Tue, 27 Oct 2020 05:52:42 +1100 (AEDT) Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1FB9207E8; Mon, 26 Oct 2020 18:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603738359; bh=t2EQbcyl5c3xdLTzNkFpT08fzGpuuYyPqlb0/xDd3r4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JckPPeS6Q4j3QYgNH76zNGhEI+P2JRsz0T+do+ZJ0jXBaGM/h3iWH2jzj+1PmQ4yh qsl/JLRqufoBVgCw8TWFwiDAnMyBF0gzRXIKT8uv0Gm8e5QCTQZuBT9ARs90+bIeoM jA3gBYtw+K4gukXB97CGMg0jaj6i8HzU5aol5USc= Date: Mon, 26 Oct 2020 11:52:37 -0700 From: Jakub Kicinski To: Michal Suchanek Subject: Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge. Message-ID: <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201026104221.26570-1-msuchanek@suse.de> References: <20201026104221.26570-1-msuchanek@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cristobal Forno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Bogendoerfer , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Cris Forno Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > From: Thomas Bogendoerfer > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > but now suppresses bridged frames, which are accepted by the hypervisor > otherwise bridging won't work at all. > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > Signed-off-by: Michal Suchanek Since the From: line says Thomas we need a signoff from him.