From: Rob Herring <robh@kernel.org>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver.
Date: Mon, 26 Oct 2020 08:13:24 -0500 [thread overview]
Message-ID: <20201026131324.GA7627@bogus> (raw)
In-Reply-To: <20201016165602.55720-2-zhouyanjie@wanyeetech.com>
On Sat, Oct 17, 2020 at 12:56:02AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> The new OST has one global timer and two or four percpu timers, so there
> will be three combinations in the upcoming new OST driver: the original
> GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and
> GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition
> about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the
> combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER
> and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any
> combinations, the clock can be registered (by calling clk_hw_register())
> from index 0.
You need to state why breaking the ABI is okay.
>
> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> ---
>
> Notes:
> v1->v2:
> Rewrite the commit message so that each line is less than 80 characters.
>
> include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/include/dt-bindings/clock/ingenic,sysost.h b/include/dt-bindings/clock/ingenic,sysost.h
> index 9ac88e90babf..063791b01ab3 100644
> --- a/include/dt-bindings/clock/ingenic,sysost.h
> +++ b/include/dt-bindings/clock/ingenic,sysost.h
> @@ -1,12 +1,16 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
> - * This header provides clock numbers for the ingenic,tcu DT binding.
> + * This header provides clock numbers for the Ingenic OST DT binding.
> */
>
> #ifndef __DT_BINDINGS_CLOCK_INGENIC_OST_H__
> #define __DT_BINDINGS_CLOCK_INGENIC_OST_H__
>
> -#define OST_CLK_PERCPU_TIMER 0
> -#define OST_CLK_GLOBAL_TIMER 1
> +#define OST_CLK_PERCPU_TIMER 1
> +#define OST_CLK_GLOBAL_TIMER 0
> +#define OST_CLK_PERCPU_TIMER0 1
> +#define OST_CLK_PERCPU_TIMER1 2
> +#define OST_CLK_PERCPU_TIMER2 3
> +#define OST_CLK_PERCPU_TIMER3 4
>
> #endif /* __DT_BINDINGS_CLOCK_INGENIC_OST_H__ */
> --
> 2.11.0
>
next prev parent reply other threads:[~2020-10-26 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 16:56 [PATCH v2 0/1] Add macro definition for the upcoming new OST driver 周琰杰 (Zhou Yanjie)
2020-10-16 16:56 ` [PATCH v2 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie)
2020-10-26 13:13 ` Rob Herring [this message]
2020-10-26 14:36 ` Zhou Yanjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026131324.GA7627@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.