From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5094EC2D0A3 for ; Mon, 26 Oct 2020 14:50:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2B3D22263 for ; Mon, 26 Oct 2020 14:50:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Y6nZxaqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1782065AbgJZOuj (ORCPT ); Mon, 26 Oct 2020 10:50:39 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:37470 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1782056AbgJZOuj (ORCPT ); Mon, 26 Oct 2020 10:50:39 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09QEoWjc097759; Mon, 26 Oct 2020 09:50:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1603723832; bh=MsywtBpRGFNcQQmKNNDaQqYeG3MCDYWN9AXhYEX29OU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Y6nZxaqwJ13Rblm6S0bCz6Fo6bAJGkpm9MbdJINwqtthIWmBFUQt9fXtyYkyHEYz7 1zm3GYk3KUoMNuObjy+fuPOqB1ijpoZU6ZgCFBbkHkMbfcjqls4F2KTyEMyIx+fwpF zWfLQm+iGflv+q/pOwItgF+ScTVCVfK1hjicPVQA= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09QEoWIT051952 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 26 Oct 2020 09:50:32 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 26 Oct 2020 09:50:31 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 26 Oct 2020 09:50:31 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09QEoVEp095279; Mon, 26 Oct 2020 09:50:31 -0500 Date: Mon, 26 Oct 2020 09:50:31 -0500 From: Nishanth Menon To: Peter Ujfalusi CC: , , , , Subject: Re: [PATCH] arm64: dts: ti: k3-j7200-main: Add McASP nodes Message-ID: <20201026145031.ggfugctq65zvgwp2@dismiss> References: <20201005074850.11247-1-peter.ujfalusi@ti.com> <20201005115805.d6yhykn7oc6x2tbu@charm> <5a9ed7d3-fcfd-edbf-fc34-112a7e55aa1c@ti.com> <20201005120837.75cwdmcpvzbvayq7@kinfolk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter, On 13:38-20201007, Peter Ujfalusi wrote: [...] > >>>> + status = "disabled"; > >>> > >>> I see that there is inconsistent usage of "disabled" in our SoC.dts > >>> > >>> Our generic rule has been set them to disabled in board.dtsi > >>> McASP and DSS for existing SoC dts do not follow this.. which is a tad > >>> confusing.. (considering that not even all uarts come out on every board > >>> and every uart needs pinmux to function..) > >> > >> "keep them disabled because several required properties are not present > >> as they are board specific." > >> > >> In board file the enabled mcasp must be updated with options that is > >> required for operation. Without those option the McASP can not be > >> initialized. > >> > >> I think we have been revisiting the very same discussion every time we > >> have a new SoC with McASP... > >> > > > > Yep.. This doe'snt really follow the rest of the SoC definition. [1] > > came to mind. The McASP discussion is a variation in the debate of the > > same. > > Right, saying status = "okay" to a node which is missing required > properties (which can only be added by boards when the McASP is > connected up) does not sound a good solution. > How should the SW handle that? Fail the device probe and return with > -EINVAL or eat up the error and just probe with broken configuration. > Since the peripheral is not used, the broken configuration will not > cause much runtime errors as there will be no runtime use of the peripheral. > > status of fail or fail-sss is not a good one either, their definition is: > "Indicates that the device is not operational. A serious error was > detected in the device, and it is unlikely to become operational without > repair." > > The peripheral is fine, we are just trying to enable it without > providing the needed properties. > > > I'd argue Serdes, or for that matter any IP that has a link to > > outside-the-SoC world has the same discussion point. > > status = "disabled" is still the closest thing for everything which have > external dependencies. There is not much point to enable an i2c bus > without making sure that the signals are actually routed to the pins > where they supposed to go. > > Or from other pow: a board design is not based on what is _not_ > connected to outside world, but you actually _connect_ or _enable_ > certain peripherals to external components, connectors. OK, I will buy the argument that the current status thingy is a bit overloaded and does'nt imply the correct state we need it to imply with "fail-sss" either - I remember an argument for "fail-incomplete", but that never happened anyways. Lets add this argument to the commit message and repost after testing on 5.10-rc1 please? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B34C4363A for ; Mon, 26 Oct 2020 14:51:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2ED922263 for ; Mon, 26 Oct 2020 14:51:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wrogTqN2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Y6nZxaqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2ED922263 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CW2A7TbXUFf1apDcfCZd44DjuYHkI2MdciztoadZHII=; b=wrogTqN2mCSFCUVJLrZBjHzjq P22qrXOxgnw391z5HcOMkAnVsNTGbDQsrSKZBG+RZlyxli0yH+TaH0JZfvYZ7uKhChzo357uubf5g XQ+HdDgYnopgUt4Xf3bNt//KQOXfnLjHR7fphJi6rvV/WKyrocMTnPPv/HIuKfOcmpMRR2+ZEpLNU 95pthfpPo+6wHvO7Hoc8ldMqamxnXGFoYJSuIVZ6YWP1oOWFve3GzBQvs+bYJxy5CtAKNsRzrkHD9 Prcz60CAi8FiYJD6FPcMawi2KP/QwWcPBXkDIbKDq+mdV8z09WlmjyBLmhs8e9KbPGbxXj3DuEYfW qxQ5Sw7BQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX3pW-0005Xa-Kt; Mon, 26 Oct 2020 14:50:38 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX3pT-0005W6-Ow for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2020 14:50:37 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09QEoWjc097759; Mon, 26 Oct 2020 09:50:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1603723832; bh=MsywtBpRGFNcQQmKNNDaQqYeG3MCDYWN9AXhYEX29OU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Y6nZxaqwJ13Rblm6S0bCz6Fo6bAJGkpm9MbdJINwqtthIWmBFUQt9fXtyYkyHEYz7 1zm3GYk3KUoMNuObjy+fuPOqB1ijpoZU6ZgCFBbkHkMbfcjqls4F2KTyEMyIx+fwpF zWfLQm+iGflv+q/pOwItgF+ScTVCVfK1hjicPVQA= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09QEoWIT051952 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 26 Oct 2020 09:50:32 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 26 Oct 2020 09:50:31 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 26 Oct 2020 09:50:31 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09QEoVEp095279; Mon, 26 Oct 2020 09:50:31 -0500 Date: Mon, 26 Oct 2020 09:50:31 -0500 From: Nishanth Menon To: Peter Ujfalusi Subject: Re: [PATCH] arm64: dts: ti: k3-j7200-main: Add McASP nodes Message-ID: <20201026145031.ggfugctq65zvgwp2@dismiss> References: <20201005074850.11247-1-peter.ujfalusi@ti.com> <20201005115805.d6yhykn7oc6x2tbu@charm> <5a9ed7d3-fcfd-edbf-fc34-112a7e55aa1c@ti.com> <20201005120837.75cwdmcpvzbvayq7@kinfolk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_105036_751062_48C12875 X-CRM114-Status: GOOD ( 28.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: t-kristo@ti.com, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Peter, On 13:38-20201007, Peter Ujfalusi wrote: [...] > >>>> + status = "disabled"; > >>> > >>> I see that there is inconsistent usage of "disabled" in our SoC.dts > >>> > >>> Our generic rule has been set them to disabled in board.dtsi > >>> McASP and DSS for existing SoC dts do not follow this.. which is a tad > >>> confusing.. (considering that not even all uarts come out on every board > >>> and every uart needs pinmux to function..) > >> > >> "keep them disabled because several required properties are not present > >> as they are board specific." > >> > >> In board file the enabled mcasp must be updated with options that is > >> required for operation. Without those option the McASP can not be > >> initialized. > >> > >> I think we have been revisiting the very same discussion every time we > >> have a new SoC with McASP... > >> > > > > Yep.. This doe'snt really follow the rest of the SoC definition. [1] > > came to mind. The McASP discussion is a variation in the debate of the > > same. > > Right, saying status = "okay" to a node which is missing required > properties (which can only be added by boards when the McASP is > connected up) does not sound a good solution. > How should the SW handle that? Fail the device probe and return with > -EINVAL or eat up the error and just probe with broken configuration. > Since the peripheral is not used, the broken configuration will not > cause much runtime errors as there will be no runtime use of the peripheral. > > status of fail or fail-sss is not a good one either, their definition is: > "Indicates that the device is not operational. A serious error was > detected in the device, and it is unlikely to become operational without > repair." > > The peripheral is fine, we are just trying to enable it without > providing the needed properties. > > > I'd argue Serdes, or for that matter any IP that has a link to > > outside-the-SoC world has the same discussion point. > > status = "disabled" is still the closest thing for everything which have > external dependencies. There is not much point to enable an i2c bus > without making sure that the signals are actually routed to the pins > where they supposed to go. > > Or from other pow: a board design is not based on what is _not_ > connected to outside world, but you actually _connect_ or _enable_ > certain peripherals to external components, connectors. OK, I will buy the argument that the current status thingy is a bit overloaded and does'nt imply the correct state we need it to imply with "fail-sss" either - I remember an argument for "fail-incomplete", but that never happened anyways. Lets add this argument to the commit message and repost after testing on 5.10-rc1 please? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel