From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7C6C4363A for ; Mon, 26 Oct 2020 19:13:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDE742080A for ; Mon, 26 Oct 2020 19:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1792616AbgJZTN1 convert rfc822-to-8bit (ORCPT ); Mon, 26 Oct 2020 15:13:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:42044 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404222AbgJZTEK (ORCPT ); Mon, 26 Oct 2020 15:04:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E8A94AE2B; Mon, 26 Oct 2020 19:04:08 +0000 (UTC) Date: Mon, 26 Oct 2020 20:04:07 +0100 From: Thomas Bogendoerfer To: Jakub Kicinski Cc: Michal Suchanek , netdev@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Cristobal Forno , "David S. Miller" , Cris Forno , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge. Message-Id: <20201026200407.fcf43678ba4cef7fe0cb7c98@suse.de> In-Reply-To: <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> References: <20201026104221.26570-1-msuchanek@suse.de> <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Oct 2020 11:52:37 -0700 Jakub Kicinski wrote: > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > > From: Thomas Bogendoerfer > > > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > > but now suppresses bridged frames, which are accepted by the hypervisor > > otherwise bridging won't work at all. > > > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > > Signed-off-by: Michal Suchanek > > Since the From: line says Thomas we need a signoff from him. you can add Signed-off-by: tbogendoerfer@suse.de Thomas. -- SUSE Software Solutions Germany GmbH HRB 36809 (AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B203EC4363A for ; Mon, 26 Oct 2020 21:09:23 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAE992076A for ; Mon, 26 Oct 2020 21:09:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAE992076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CKnWz4n32zDqN9 for ; Tue, 27 Oct 2020 08:09:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.de (client-ip=195.135.220.15; helo=mx2.suse.de; envelope-from=tbogendoerfer@suse.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CKklh4gfTzDqMK for ; Tue, 27 Oct 2020 06:04:12 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E8A94AE2B; Mon, 26 Oct 2020 19:04:08 +0000 (UTC) Date: Mon, 26 Oct 2020 20:04:07 +0100 From: Thomas Bogendoerfer To: Jakub Kicinski Subject: Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge. Message-Id: <20201026200407.fcf43678ba4cef7fe0cb7c98@suse.de> In-Reply-To: <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> References: <20201026104221.26570-1-msuchanek@suse.de> <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 27 Oct 2020 08:07:47 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cristobal Forno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Michal Suchanek , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Cris Forno Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 26 Oct 2020 11:52:37 -0700 Jakub Kicinski wrote: > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > > From: Thomas Bogendoerfer > >=20 > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > > but now suppresses bridged frames, which are accepted by the hypervisor > > otherwise bridging won't work at all. > >=20 > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sendin= g to the hypervisor") > > Signed-off-by: Michal Suchanek >=20 > Since the From: line says Thomas we need a signoff from him. you can add Signed-off-by: tbogendoerfer@suse.de Thomas. --=20 SUSE Software Solutions Germany GmbH HRB 36809 (AG N=FCrnberg) Gesch=E4ftsf=FChrer: Felix Imend=F6rffer