From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC99AC63777 for ; Tue, 27 Oct 2020 00:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC134216FD for ; Tue, 27 Oct 2020 00:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603759302; bh=FkpRkYZDBHzgwCdDMC+6K5UDKJIXKq4ENQKu9yOeDbE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=d5pmv6/qs6qCHlBWpo/9gn5fyAVE+3mp5uxHBNsps6A48U9MFvfRyxHsdtQqE3qfX UtBH8DYV+3kEsbW5T3P7LsUx7XGXd/Oo5ZnDqpHOcMx8qLYM/AFP39oSwENtIhXj3n N1pOz32O0ToZgvO1r6qN58O+hXJqupSaZop9OHmU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2444474AbgJ0Aiu (ORCPT ); Mon, 26 Oct 2020 20:38:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:48872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408991AbgJZXuD (ORCPT ); Mon, 26 Oct 2020 19:50:03 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8196421707; Mon, 26 Oct 2020 23:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603756202; bh=FkpRkYZDBHzgwCdDMC+6K5UDKJIXKq4ENQKu9yOeDbE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N/S22EE2JAtZj6cK9S/Vwl7gGXirdsxU9jcDn16DZe5suOyub5eN4yiA6f3vxw5Oe PzyvBnEVXm96Hl/JzLg0y/YiyveCo6SARprb+eedgK/XvTfqvA+pglkJLsmG00aMnw Z2+uJcxBKnFkypuwAYxVNmzxvH/zu+a6xunDCaaU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= , Greg Kroah-Hartman , Sasha Levin , devel@driverdev.osuosl.org Subject: [PATCH AUTOSEL 5.9 045/147] staging: wfx: fix potential use before init Date: Mon, 26 Oct 2020 19:47:23 -0400 Message-Id: <20201026234905.1022767-45-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201026234905.1022767-1-sashal@kernel.org> References: <20201026234905.1022767-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jérôme Pouiller [ Upstream commit ce3653a8d3db096aa163fc80239d8ec1305c81fa ] The trace below can appear: [83613.832200] INFO: trying to register non-static key. [83613.837248] the code is fine but needs lockdep annotation. [83613.842808] turning off the locking correctness validator. [83613.848375] CPU: 3 PID: 141 Comm: kworker/3:2H Tainted: G O 5.6.13-silabs15 #2 [83613.857019] Hardware name: BCM2835 [83613.860605] Workqueue: events_highpri bh_work [wfx] [83613.865552] Backtrace: [83613.868041] [] (dump_backtrace) from [] (show_stack+0x20/0x24) [83613.881463] [] (show_stack) from [] (dump_stack+0xe8/0x114) [83613.888882] [] (dump_stack) from [] (register_lock_class+0x748/0x768) [83613.905035] [] (register_lock_class) from [] (__lock_acquire+0x88/0x13dc) [83613.924192] [] (__lock_acquire) from [] (lock_acquire+0xe8/0x274) [83613.942644] [] (lock_acquire) from [] (_raw_spin_lock_irqsave+0x58/0x6c) [83613.961714] [] (_raw_spin_lock_irqsave) from [] (skb_dequeue+0x24/0x78) [83613.974967] [] (skb_dequeue) from [] (wfx_tx_queues_get+0x96c/0x1294 [wfx]) [83613.989728] [] (wfx_tx_queues_get [wfx]) from [] (bh_work+0x454/0x26d8 [wfx]) [83614.009337] [] (bh_work [wfx]) from [] (process_one_work+0x23c/0x7ec) [83614.028141] [] (process_one_work) from [] (worker_thread+0x4c/0x55c) [83614.046861] [] (worker_thread) from [] (kthread+0x138/0x168) [83614.064876] [] (kthread) from [] (ret_from_fork+0x14/0x20) [83614.072200] Exception stack(0xecad3fb0 to 0xecad3ff8) [83614.077323] 3fa0: 00000000 00000000 00000000 00000000 [83614.085620] 3fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [83614.093914] 3fe0: 00000000 00000000 00000000 00000000 00000013 00000000 Indeed, the code of wfx_add_interface() shows that the interface is enabled to early. So, the spinlock associated with some skb_queue may not yet initialized when wfx_tx_queues_get() is called. Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20200825085828.399505-8-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/wfx/sta.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 4e30ab17a93d4..b96c83671caeb 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -760,17 +760,6 @@ int wfx_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) return -EOPNOTSUPP; } - for (i = 0; i < ARRAY_SIZE(wdev->vif); i++) { - if (!wdev->vif[i]) { - wdev->vif[i] = vif; - wvif->id = i; - break; - } - } - if (i == ARRAY_SIZE(wdev->vif)) { - mutex_unlock(&wdev->conf_mutex); - return -EOPNOTSUPP; - } // FIXME: prefer use of container_of() to get vif wvif->vif = vif; wvif->wdev = wdev; @@ -787,12 +776,22 @@ int wfx_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) init_completion(&wvif->scan_complete); INIT_WORK(&wvif->scan_work, wfx_hw_scan_work); - mutex_unlock(&wdev->conf_mutex); + wfx_tx_queues_init(wvif); + wfx_tx_policy_init(wvif); + + for (i = 0; i < ARRAY_SIZE(wdev->vif); i++) { + if (!wdev->vif[i]) { + wdev->vif[i] = vif; + wvif->id = i; + break; + } + } + WARN(i == ARRAY_SIZE(wdev->vif), "try to instantiate more vif than supported"); hif_set_macaddr(wvif, vif->addr); - wfx_tx_queues_init(wvif); - wfx_tx_policy_init(wvif); + mutex_unlock(&wdev->conf_mutex); + wvif = NULL; while ((wvif = wvif_iterate(wdev, wvif)) != NULL) { // Combo mode does not support Block Acks. We can re-enable them @@ -824,6 +823,7 @@ void wfx_remove_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) wvif->vif = NULL; mutex_unlock(&wdev->conf_mutex); + wvif = NULL; while ((wvif = wvif_iterate(wdev, wvif)) != NULL) { // Combo mode does not support Block Acks. We can re-enable them -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9126C63699 for ; Mon, 26 Oct 2020 23:50:06 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54DE721741 for ; Mon, 26 Oct 2020 23:50:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N/S22EE2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54DE721741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1224A860CD; Mon, 26 Oct 2020 23:50:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KFS2cPej6LZV; Mon, 26 Oct 2020 23:50:05 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3B9CB855CE; Mon, 26 Oct 2020 23:50:05 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 4A2651BF3DE for ; Mon, 26 Oct 2020 23:50:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3E47A203ED for ; Mon, 26 Oct 2020 23:50:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l+OvpSqP+fjn for ; Mon, 26 Oct 2020 23:50:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id 850312037E for ; Mon, 26 Oct 2020 23:50:02 +0000 (UTC) Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8196421707; Mon, 26 Oct 2020 23:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603756202; bh=FkpRkYZDBHzgwCdDMC+6K5UDKJIXKq4ENQKu9yOeDbE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N/S22EE2JAtZj6cK9S/Vwl7gGXirdsxU9jcDn16DZe5suOyub5eN4yiA6f3vxw5Oe PzyvBnEVXm96Hl/JzLg0y/YiyveCo6SARprb+eedgK/XvTfqvA+pglkJLsmG00aMnw Z2+uJcxBKnFkypuwAYxVNmzxvH/zu+a6xunDCaaU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.9 045/147] staging: wfx: fix potential use before init Date: Mon, 26 Oct 2020 19:47:23 -0400 Message-Id: <20201026234905.1022767-45-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201026234905.1022767-1-sashal@kernel.org> References: <20201026234905.1022767-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Greg Kroah-Hartman , devel@driverdev.osuosl.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" RnJvbTogSsOpcsO0bWUgUG91aWxsZXIgPGplcm9tZS5wb3VpbGxlckBzaWxhYnMuY29tPgoKWyBV cHN0cmVhbSBjb21taXQgY2UzNjUzYThkM2RiMDk2YWExNjNmYzgwMjM5ZDhlYzEzMDVjODFmYSBd CgpUaGUgdHJhY2UgYmVsb3cgY2FuIGFwcGVhcjoKCiAgICBbODM2MTMuODMyMjAwXSBJTkZPOiB0 cnlpbmcgdG8gcmVnaXN0ZXIgbm9uLXN0YXRpYyBrZXkuCiAgICBbODM2MTMuODM3MjQ4XSB0aGUg Y29kZSBpcyBmaW5lIGJ1dCBuZWVkcyBsb2NrZGVwIGFubm90YXRpb24uCiAgICBbODM2MTMuODQy ODA4XSB0dXJuaW5nIG9mZiB0aGUgbG9ja2luZyBjb3JyZWN0bmVzcyB2YWxpZGF0b3IuCiAgICBb ODM2MTMuODQ4Mzc1XSBDUFU6IDMgUElEOiAxNDEgQ29tbToga3dvcmtlci8zOjJIIFRhaW50ZWQ6 IEcgICAgICAgICAgIE8gICAgICA1LjYuMTMtc2lsYWJzMTUgIzIKICAgIFs4MzYxMy44NTcwMTld IEhhcmR3YXJlIG5hbWU6IEJDTTI4MzUKICAgIFs4MzYxMy44NjA2MDVdIFdvcmtxdWV1ZTogZXZl bnRzX2hpZ2hwcmkgYmhfd29yayBbd2Z4XQogICAgWzgzNjEzLjg2NTU1Ml0gQmFja3RyYWNlOgog ICAgWzgzNjEzLjg2ODA0MV0gWzxjMDEwZjJjYz5dIChkdW1wX2JhY2t0cmFjZSkgZnJvbSBbPGMw MTBmN2I4Pl0gKHNob3dfc3RhY2srMHgyMC8weDI0KQogICAgWzgzNjEzLjg4MTQ2M10gWzxjMDEw Zjc5OD5dIChzaG93X3N0YWNrKSBmcm9tIFs8YzBkODIxMzg+XSAoZHVtcF9zdGFjaysweGU4LzB4 MTE0KQogICAgWzgzNjEzLjg4ODg4Ml0gWzxjMGQ4MjA1MD5dIChkdW1wX3N0YWNrKSBmcm9tIFs8 YzAxYTAyZWM+XSAocmVnaXN0ZXJfbG9ja19jbGFzcysweDc0OC8weDc2OCkKICAgIFs4MzYxMy45 MDUwMzVdIFs8YzAxOWZiYTQ+XSAocmVnaXN0ZXJfbG9ja19jbGFzcykgZnJvbSBbPGMwMTlkYTA0 Pl0gKF9fbG9ja19hY3F1aXJlKzB4ODgvMHgxM2RjKQogICAgWzgzNjEzLjkyNDE5Ml0gWzxjMDE5 ZDk3Yz5dIChfX2xvY2tfYWNxdWlyZSkgZnJvbSBbPGMwMTlmNmE0Pl0gKGxvY2tfYWNxdWlyZSsw eGU4LzB4Mjc0KQogICAgWzgzNjEzLjk0MjY0NF0gWzxjMDE5ZjViYz5dIChsb2NrX2FjcXVpcmUp IGZyb20gWzxjMGRhYTVkYz5dIChfcmF3X3NwaW5fbG9ja19pcnFzYXZlKzB4NTgvMHg2YykKICAg IFs4MzYxMy45NjE3MTRdIFs8YzBkYWE1ODQ+XSAoX3Jhd19zcGluX2xvY2tfaXJxc2F2ZSkgZnJv bSBbPGMwYWIzMjQ4Pl0gKHNrYl9kZXF1ZXVlKzB4MjQvMHg3OCkKICAgIFs4MzYxMy45NzQ5Njdd IFs8YzBhYjMyMjQ+XSAoc2tiX2RlcXVldWUpIGZyb20gWzxiZjMzMGRiMD5dICh3ZnhfdHhfcXVl dWVzX2dldCsweDk2Yy8weDEyOTQgW3dmeF0pCiAgICBbODM2MTMuOTg5NzI4XSBbPGJmMzMwNDQ0 Pl0gKHdmeF90eF9xdWV1ZXNfZ2V0IFt3ZnhdKSBmcm9tIFs8YmYzMjA0NTQ+XSAoYmhfd29yaysw eDQ1NC8weDI2ZDggW3dmeF0pCiAgICBbODM2MTQuMDA5MzM3XSBbPGJmMzIwMDAwPl0gKGJoX3dv cmsgW3dmeF0pIGZyb20gWzxjMDE0YzkyMD5dIChwcm9jZXNzX29uZV93b3JrKzB4MjNjLzB4N2Vj KQogICAgWzgzNjE0LjAyODE0MV0gWzxjMDE0YzZlND5dIChwcm9jZXNzX29uZV93b3JrKSBmcm9t IFs8YzAxNGNmMWM+XSAod29ya2VyX3RocmVhZCsweDRjLzB4NTVjKQogICAgWzgzNjE0LjA0Njg2 MV0gWzxjMDE0Y2VkMD5dICh3b3JrZXJfdGhyZWFkKSBmcm9tIFs8YzAxNTRjMDQ+XSAoa3RocmVh ZCsweDEzOC8weDE2OCkKICAgIFs4MzYxNC4wNjQ4NzZdIFs8YzAxNTRhY2M+XSAoa3RocmVhZCkg ZnJvbSBbPGMwMTAxMGI0Pl0gKHJldF9mcm9tX2ZvcmsrMHgxNC8weDIwKQogICAgWzgzNjE0LjA3 MjIwMF0gRXhjZXB0aW9uIHN0YWNrKDB4ZWNhZDNmYjAgdG8gMHhlY2FkM2ZmOCkKICAgIFs4MzYx NC4wNzczMjNdIDNmYTA6ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDAwMDAw MDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwCiAgICBbODM2MTQuMDg1NjIwXSAzZmMwOiAw MDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAw MDAwMCAwMDAwMDAwMAogICAgWzgzNjE0LjA5MzkxNF0gM2ZlMDogMDAwMDAwMDAgMDAwMDAwMDAg MDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMTMgMDAwMDAwMDAKCkluZGVlZCwgdGhlIGNvZGUgb2Yg d2Z4X2FkZF9pbnRlcmZhY2UoKSBzaG93cyB0aGF0IHRoZSBpbnRlcmZhY2UgaXMKZW5hYmxlZCB0 byBlYXJseS4gU28sIHRoZSBzcGlubG9jayBhc3NvY2lhdGVkIHdpdGggc29tZSBza2JfcXVldWUg bWF5Cm5vdCB5ZXQgaW5pdGlhbGl6ZWQgd2hlbiB3ZnhfdHhfcXVldWVzX2dldCgpIGlzIGNhbGxl ZC4KClNpZ25lZC1vZmYtYnk6IErDqXLDtG1lIFBvdWlsbGVyIDxqZXJvbWUucG91aWxsZXJAc2ls YWJzLmNvbT4KTGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci8yMDIwMDgyNTA4NTgyOC4z OTk1MDUtOC1KZXJvbWUuUG91aWxsZXJAc2lsYWJzLmNvbQpTaWduZWQtb2ZmLWJ5OiBHcmVnIEty b2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgpTaWduZWQtb2ZmLWJ5OiBT YXNoYSBMZXZpbiA8c2FzaGFsQGtlcm5lbC5vcmc+Ci0tLQogZHJpdmVycy9zdGFnaW5nL3dmeC9z dGEuYyB8IDI4ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAx NCBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3N0 YWdpbmcvd2Z4L3N0YS5jIGIvZHJpdmVycy9zdGFnaW5nL3dmeC9zdGEuYwppbmRleCA0ZTMwYWIx N2E5M2Q0Li5iOTZjODM2NzFjYWViIDEwMDY0NAotLS0gYS9kcml2ZXJzL3N0YWdpbmcvd2Z4L3N0 YS5jCisrKyBiL2RyaXZlcnMvc3RhZ2luZy93Zngvc3RhLmMKQEAgLTc2MCwxNyArNzYwLDYgQEAg aW50IHdmeF9hZGRfaW50ZXJmYWNlKHN0cnVjdCBpZWVlODAyMTFfaHcgKmh3LCBzdHJ1Y3QgaWVl ZTgwMjExX3ZpZiAqdmlmKQogCQlyZXR1cm4gLUVPUE5PVFNVUFA7CiAJfQogCi0JZm9yIChpID0g MDsgaSA8IEFSUkFZX1NJWkUod2Rldi0+dmlmKTsgaSsrKSB7Ci0JCWlmICghd2Rldi0+dmlmW2ld KSB7Ci0JCQl3ZGV2LT52aWZbaV0gPSB2aWY7Ci0JCQl3dmlmLT5pZCA9IGk7Ci0JCQlicmVhazsK LQkJfQotCX0KLQlpZiAoaSA9PSBBUlJBWV9TSVpFKHdkZXYtPnZpZikpIHsKLQkJbXV0ZXhfdW5s b2NrKCZ3ZGV2LT5jb25mX211dGV4KTsKLQkJcmV0dXJuIC1FT1BOT1RTVVBQOwotCX0KIAkvLyBG SVhNRTogcHJlZmVyIHVzZSBvZiBjb250YWluZXJfb2YoKSB0byBnZXQgdmlmCiAJd3ZpZi0+dmlm ID0gdmlmOwogCXd2aWYtPndkZXYgPSB3ZGV2OwpAQCAtNzg3LDEyICs3NzYsMjIgQEAgaW50IHdm eF9hZGRfaW50ZXJmYWNlKHN0cnVjdCBpZWVlODAyMTFfaHcgKmh3LCBzdHJ1Y3QgaWVlZTgwMjEx X3ZpZiAqdmlmKQogCWluaXRfY29tcGxldGlvbigmd3ZpZi0+c2Nhbl9jb21wbGV0ZSk7CiAJSU5J VF9XT1JLKCZ3dmlmLT5zY2FuX3dvcmssIHdmeF9od19zY2FuX3dvcmspOwogCi0JbXV0ZXhfdW5s b2NrKCZ3ZGV2LT5jb25mX211dGV4KTsKKwl3ZnhfdHhfcXVldWVzX2luaXQod3ZpZik7CisJd2Z4 X3R4X3BvbGljeV9pbml0KHd2aWYpOworCisJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUod2Rl di0+dmlmKTsgaSsrKSB7CisJCWlmICghd2Rldi0+dmlmW2ldKSB7CisJCQl3ZGV2LT52aWZbaV0g PSB2aWY7CisJCQl3dmlmLT5pZCA9IGk7CisJCQlicmVhazsKKwkJfQorCX0KKwlXQVJOKGkgPT0g QVJSQVlfU0laRSh3ZGV2LT52aWYpLCAidHJ5IHRvIGluc3RhbnRpYXRlIG1vcmUgdmlmIHRoYW4g c3VwcG9ydGVkIik7CiAKIAloaWZfc2V0X21hY2FkZHIod3ZpZiwgdmlmLT5hZGRyKTsKIAotCXdm eF90eF9xdWV1ZXNfaW5pdCh3dmlmKTsKLQl3ZnhfdHhfcG9saWN5X2luaXQod3ZpZik7CisJbXV0 ZXhfdW5sb2NrKCZ3ZGV2LT5jb25mX211dGV4KTsKKwogCXd2aWYgPSBOVUxMOwogCXdoaWxlICgo d3ZpZiA9IHd2aWZfaXRlcmF0ZSh3ZGV2LCB3dmlmKSkgIT0gTlVMTCkgewogCQkvLyBDb21ibyBt b2RlIGRvZXMgbm90IHN1cHBvcnQgQmxvY2sgQWNrcy4gV2UgY2FuIHJlLWVuYWJsZSB0aGVtCkBA IC04MjQsNiArODIzLDcgQEAgdm9pZCB3ZnhfcmVtb3ZlX2ludGVyZmFjZShzdHJ1Y3QgaWVlZTgw MjExX2h3ICpodywgc3RydWN0IGllZWU4MDIxMV92aWYgKnZpZikKIAl3dmlmLT52aWYgPSBOVUxM OwogCiAJbXV0ZXhfdW5sb2NrKCZ3ZGV2LT5jb25mX211dGV4KTsKKwogCXd2aWYgPSBOVUxMOwog CXdoaWxlICgod3ZpZiA9IHd2aWZfaXRlcmF0ZSh3ZGV2LCB3dmlmKSkgIT0gTlVMTCkgewogCQkv LyBDb21ibyBtb2RlIGRvZXMgbm90IHN1cHBvcnQgQmxvY2sgQWNrcy4gV2UgY2FuIHJlLWVuYWJs ZSB0aGVtCi0tIAoyLjI1LjEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3Jn Cmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaXZlcmRldi1kZXZlbAo=